New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610424 link

Starred by 4 users

Issue metadata

Status: Archived
Owner:
Closed: Aug 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Fix and re-enable rasterize_and_record_micro.key_silk_cases failure on chromium.perf at <revisionrange>

Project Member Reported by oysteine@chromium.org, May 9 2016

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4f81162912dd035f78f9e696dd2338cfb93df98

commit c4f81162912dd035f78f9e696dd2338cfb93df98
Author: oysteine <oysteine@chromium.org>
Date: Mon May 09 22:03:34 2016

Disabled rasterize_and_record_micro.key_silk_cases for flakiness

TBR=nednguyen
BUG= 610424 

Review-Url: https://codereview.chromium.org/1966433002
Cr-Commit-Position: refs/heads/master@{#392432}

[modify] https://crrev.com/c4f81162912dd035f78f9e696dd2338cfb93df98/tools/perf/benchmarks/rasterize_and_record_micro.py

Cc: -vmp...@chromium.org
Labels: -Pri-1 Pri-2
Owner: vmp...@chromium.org
Summary: Fix and re-enable rasterize_and_record_micro.key_silk_cases failure on chromium.perf at <revisionrange> (was: rasterize_and_record_micro.key_silk_cases failure on chromium.perf at <revisionrange>)
Cc: dtu@chromium.org
+dtu do you think you could run your experimental script that looks at flakes and see if you can figure out a good revision range to bisect?
Labels: Performance-Sheriff-BotHealth
Status: Assigned (was: Untriaged)
Blocking: 660048
Blocking: -660048
Cc: rnep...@chromium.org vmp...@chromium.org
 Issue 660048  has been merged into this issue.
Cc: wkorman@chromium.org
Seeing flakiness on Linux start around Oct 4th and more recently get so bad that this test rarely passes completely.  See  issue 660048 .  I'm guessing this flakiness is all related, so I'll just disable on linux against this bug too.
Note that there are a number of other "disabled for flakiness" bugs for rasterize_and_record_micro tests, many of which have now been "Archived" for no activity for over a year.  So it seems like this entire benchmark is perhaps in rough shape :-(
The benchmark is still being used at least for manual testing. Since all of these were disabled pretty far back, I think it's hard to find logs that document the flakiness. Do you think it's valid to enable all of these for a short period of time to see the extent of flakiness? Or are there current logs somewhere?
Also, is there a single bug for general raster_and_record is disabled thing? Should we make one to keep track of all of these various bugs?
Project Member

Comment 12 by bugdroid1@chromium.org, Nov 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/293f34dcb2c73c370727d44eb14662471d879642

commit 293f34dcb2c73c370727d44eb14662471d879642
Author: rbyers <rbyers@chromium.org>
Date: Wed Nov 02 14:30:00 2016

Disable rasterize_and_record_micro.key_silk_cases on linux as well

TBR=nednguyen
BUG= 610424 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq

Review-Url: https://codereview.chromium.org/2463413003
Cr-Commit-Position: refs/heads/master@{#429275}

[modify] https://crrev.com/293f34dcb2c73c370727d44eb14662471d879642/tools/perf/benchmarks/rasterize_and_record_micro.py

The one I just disabled was failing consistently on Linux, so that at least should be easy to reproduce.  Eg. logs here: https://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20%282%29/builds/15428/steps/rasterize_and_record_micro.key_silk_cases/logs/stdio

Once you've confirmed it passes in Linux, then you could kick off a perf try job that re-enables it on all OSes and see if that passes.  If so, then yes sure re-enabling and watch for flakes is fine.

I merged all the rasterize_and_record_micro.key_silk_cases issues into this bug, but it seemed like some of the other issues were possibly separate.  Feel free to dupe them all if you like.
Labels: -Performance-BotHealth
Status: Archived (was: Assigned)

Sign in to add a comment