Restrict usage of non-blinks style bindings inside blink |
|||||||
Issue descriptionBlink should only use blink style bindings, otherwise there's expensive copies and type conversions inside all the mojo types. Today blink generates both styles of bindings, only the .mojom-blink.h headers should be includable from inside blink though, not the stl style .mojom.h ones.
,
May 10 2016
,
May 10 2016
Does anyone have a bandwidth to work on this?
,
May 13 2016
It looks better to fix this bug soon. Otherwise people start using .mojom.h (e.g., https://codereview.chromium.org/1948223004/).
,
May 13 2016
,
May 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/378010a9e3fcf55ec9b63183e06ddc1848734d28 commit 378010a9e3fcf55ec9b63183e06ddc1848734d28 Author: dcheng <dcheng@chromium.org> Date: Fri May 13 05:09:46 2016 Add PRESUBMIT check for including non-Blink variant mojoms in Blink. Blink code should only use the Blink variants of the generated mojom headers. BUG= 610421 R=esprehn@chromium.org,haraken@chromium.org,tkent@chromium.org Review-Url: https://codereview.chromium.org/1976883002 Cr-Commit-Position: refs/heads/master@{#393449} [modify] https://crrev.com/378010a9e3fcf55ec9b63183e06ddc1848734d28/third_party/WebKit/PRESUBMIT.py
,
May 13 2016
,
May 13 2016
(Oh, maybe we want to leave this open as the master bug for the issues that currently exist.)
,
Jun 23 2016
Renaming Blink>Architecture to Blink>Internals
,
Jan 12 2017
,
Jul 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4fbef2b7c59d740551a78f1a6c2c035aff7cb07 commit e4fbef2b7c59d740551a78f1a6c2c035aff7cb07 Author: Matt Falkenhagen <falken@chromium.org> Date: Wed Jul 19 10:03:01 2017 PRESUBMIT: Add more clues to the error about non-Blink variants. The existing message didn't really give the reader advice about what to do, if they hadn't heard of "non-Blink variant mojoms" before. Bug: 610421 Change-Id: Idce6432a28c613d901c3f33f6d64f03f700238d0 Reviewed-on: https://chromium-review.googlesource.com/576605 Reviewed-by: Kent Tamura <tkent@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#487811} [modify] https://crrev.com/e4fbef2b7c59d740551a78f1a6c2c035aff7cb07/third_party/WebKit/PRESUBMIT.py |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by esprehn@chromium.org
, May 9 2016