New issue
Advanced search Search tips

Issue 610399 link

Starred by 1 user
Status: Fixed
Owner:
bengr@chromium.org
Closed: Aug 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

An interrupted precache session should resume where it left off

Project Member Reported by bengr@chromium.org, May 9 2016 
Precaching may be interrupted on a timeout, on a network change, or on a power source change. When interrupted, the feature should store the remaining URLs to prefetch, and schedule a task to complete the work. When that task executes, the URLs should be read from storage and precaching should resume where it left off.
Project Member

Comment 1 by bugdroid1@chromium.org, May 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb5f835faf844ba31f602f6502b7c3f8db30624

commit 0bb5f835faf844ba31f602f6502b7c3f8db30624
Author: bengr <bengr@chromium.org>
Date: Fri May 27 02:25:00 2016

Add pause/resume functionality to precache

This CL serializes an interrupted precache session
to a database and resumes on the next opportunity that
the task scheduler provides.

BUG= 610399 

Review-Url: https://codereview.chromium.org/1961153003
Cr-Commit-Position: refs/heads/master@{#396358}

[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/chrome/browser/precache/precache_manager_factory.cc
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/components_tests.gyp
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache.gypi
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/content/BUILD.gn
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/content/precache_manager.cc
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/content/precache_manager.h
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/content/precache_manager_unittest.cc
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/BUILD.gn
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/fetcher_pool.h
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/precache_database.cc
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/precache_database.h
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/precache_fetcher.cc
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/precache_fetcher.h
[modify] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/precache_fetcher_unittest.cc
[add] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/precache_session_table.cc
[add] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/precache_session_table.h
[add] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/precache_session_table_unittest.cc
[add] https://crrev.com/0bb5f835faf844ba31f602f6502b7c3f8db30624/components/precache/core/proto/unfinished_work.proto
Project Member

Comment 2 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by twif...@chromium.org, Aug 16 2016

Status: Fixed (was: Assigned)
(I think you just forgot to mark this fixed. Reopen if I'm wrong.)
►

Sign in to add a comment