Issue metadata
Sign in to add a comment
|
Fix and re-enable blink_perf.canvas failure on Nexus9/Nexus7v2 |
||||||||||||||||||||
Issue descriptionhttps://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus9%20Perf%20%282%29?numbuilds=200 https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus7v2%20Perf%20%282%29?numbuilds=200 Revision range first seen: 391672 - 391726 Link to failing step log: https://uberchromegw.corp.google.com/i/chromium.perf/builders/Android%20Nexus7v2%20Perf%20%282%29/builds/1717/steps/blink_perf.canvas/logs/stdio If the test is disabled, please downgrade to Pri-2.
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb8007387062b0eec14a40e49da0cc8c5fbdf1b5 commit eb8007387062b0eec14a40e49da0cc8c5fbdf1b5 Author: oysteine <oysteine@chromium.org> Date: Tue May 10 00:26:37 2016 Disabled blink_perf.canvas TBR=nednguyen BUG= 610384 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq Review-Url: https://codereview.chromium.org/1962113002 Cr-Commit-Position: refs/heads/master@{#392488} [modify] https://crrev.com/eb8007387062b0eec14a40e49da0cc8c5fbdf1b5/tools/perf/benchmarks/blink_perf.py
,
May 10 2016
,
May 10 2016
===== BISECT JOB RESULTS ===== Status: completed ===== SUSPECTED CL(s) ===== Subject : [Reland 1] Pepper takes ownership of a mailbox before passing it to the texture layer. Author : erikchen Commit description: This CL makes three changes from the original. 1. Replace a call to std::remove_if() with vec.erase(std::remove_if(), ...). This was a logic error in the original CL that caused a crash any time the size of the buffer was changed. This CL also adds a test that catches this bug. 2. Add some simple reference counting to PepperPluginInstanceImpl to track the fact that a cc::TextureMailbox may be passed to |texture_layer_| more than once. 3. The SyncToken signal is now processed in the context of its own message: WaitSyncToken. > I replaced the IPC message GpuCommandBufferMsg_ProduceFrontBuffer with > GpuCommandBufferMsg_TakeFrontBuffer and GpuCommandBufferMsg_ReturnFrontBuffer. > TakeFrontBuffer gives ownership of the front buffer to the client. When the > client returns it with ReturnFrontBuffer, the command buffer may choose to reuse > it. > > This means that pepper no longer needs to use > SetTextureMailboxWithoutReleaseCallback. BUG= 350204 , 602484 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel TEST=Run Chromium with the Pepper Flash plugin. Visit a site that supports Flash video, such as http://vudu.com. Start playing a video, and then fullscreen the video. Observe that Chromium does not crash. Please extensively test Chromium on Flash 3D games and Flash video and make sure nothing else is working incorrectly. TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org Review-Url: https://codereview.chromium.org/1943513002 Cr-Commit-Position: refs/heads/master@{#391686} Commit : 4734ed1b6740b772201b8accb3e2bd88cdea5c99 Date : Wed May 04 23:25:19 2016 ===== TESTED REVISIONS ===== Revision Exit Code Std Dev N Good? chromium@391371 0 N/A 10 good chromium@391549 0 N/A 10 good chromium@391638 0 N/A 10 good chromium@391682 0 N/A 10 good chromium@391685 0 N/A 10 good chromium@391686 1 N/A 10 bad <-- chromium@391687 1 N/A 10 bad chromium@391688 1 N/A 10 bad chromium@391693 1 N/A 10 bad chromium@391704 1 N/A 10 bad chromium@391726 1 N/A 10 bad Bisect job ran on: android_nexus7_perf_bisect Bug ID: 610384 Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.canvas Test Metric: createImageBitmapFromImageData/createImageBitmapFromImageData Relative Change: Zero to non-zero Score: 0.0 Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/2966 Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013117214546125808 Not what you expected? We'll investigate and get back to you! https://chromeperf.appspot.com/bad_bisect?try_job_id=5832538048692224 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Tests>AutoBisect. Thank you!
,
May 10 2016
Re-enabling in https://codereview.chromium.org/1963123002/
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0d7ec9c034ca5bf8bbdb3e2d4176bf63fb8631ca commit 0d7ec9c034ca5bf8bbdb3e2d4176bf63fb8631ca Author: oysteine <oysteine@chromium.org> Date: Tue May 10 15:18:49 2016 Revert of Disabled blink_perf.canvas (patchset #2 id:20001 of https://codereview.chromium.org/1962113002/ ) Reason for revert: Speculative revert to see if same issue as https://bugs.chromium.org/p/chromium/issues/detail?id=610327 Original issue's description: > Disabled blink_perf.canvas > > TBR=nednguyen > BUG= 610384 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq > > Committed: https://crrev.com/eb8007387062b0eec14a40e49da0cc8c5fbdf1b5 > Cr-Commit-Position: refs/heads/master@{#392488} TBR=nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 610384 Review-Url: https://codereview.chromium.org/1963123002 Cr-Commit-Position: refs/heads/master@{#392608} [modify] https://crrev.com/0d7ec9c034ca5bf8bbdb3e2d4176bf63fb8631ca/tools/perf/benchmarks/blink_perf.py |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by oysteine@chromium.org
, May 9 2016