Translate icon is not showing up on omnibar after "never translate this language" |
|||||||||||
Issue descriptionVersion: Version after 52.0.2729.0 OS: Windows What steps will reproduce the problem? (1) turn on the "Translate 2016Q2 UI" first. Visit "chrome://flags", find "Translate 2016Q2 UI", change from "Default" to "Enabled", click on the "Relaunch Now" blue button on the end of the page. (2) Visit a foreign language site, for example: www.yahoo.co.jp (3) the translate bubble show up, click "Options: Never translate Japanese" (4) visit another Japanese page, such as news.google.co.jp What is the expected output? The Translate icon showing up in omnibar What do you see instead? The Translate icon not showing up in omnibar
,
May 10 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e9194fafbe858338e049ff946d2f844c20f7c944 commit e9194fafbe858338e049ff946d2f844c20f7c944 Author: ftang <ftang@chromium.org> Date: Tue May 10 05:28:50 2016 Call SetTranslateEnable(true) in the 2016Q2 UI even it is blocked language or blocked URL so Omnibar will display the translate icon BUG= 610376 Review-Url: https://codereview.chromium.org/1966443003 Cr-Commit-Position: refs/heads/master@{#392550} [modify] https://crrev.com/e9194fafbe858338e049ff946d2f844c20f7c944/components/translate/core/browser/translate_manager.cc
,
May 13 2016
verified in "Version 52.0.2735.0 canary (64-bit)"
,
Jul 6 2016
juliecattiau@google.com said UX team want us to rollback this design.
,
Jul 6 2016
Julie- could you confirm in this bug you want this design to be rollback.
,
Jul 6 2016
I confirm that we want to roll this change back. Rationale: after users chose to "Never translate" a language or a page, the state in which users are needs to be reflected in the Translate bubble UI. The next time users open the bubble after choosing to "Never translate" by clicking on the omnibox icon, we would ideally show a simplified view of the bubble that informs users they are in a "Never translate" state and gives them the option to undo. For example: "You're not translating German. [Undo] / [Translate Once]". Since this is not something we can easily implement short term, we have decided to rollback the change described in this bug and to not keep the translate icon present in the omnibox after taking a "Never Translate" action for now.
,
Jul 13 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/898979d8cb1874e230621ebf0e4dd0b8208c0894 commit 898979d8cb1874e230621ebf0e4dd0b8208c0894 Author: ftang <ftang@chromium.org> Date: Wed Jul 13 19:47:52 2016 remove the omnibar icon changes based on UX feedback BUG= 610376 Review-Url: https://codereview.chromium.org/2130623002 Cr-Commit-Position: refs/heads/master@{#405235} [modify] https://crrev.com/898979d8cb1874e230621ebf0e4dd0b8208c0894/components/translate/core/browser/translate_manager.cc [modify] https://crrev.com/898979d8cb1874e230621ebf0e4dd0b8208c0894/components/translate/core/browser/translate_ui_delegate.cc [modify] https://crrev.com/898979d8cb1874e230621ebf0e4dd0b8208c0894/components/translate/core/browser/translate_ui_delegate_unittest.cc
,
Jul 14 2016
,
Jul 14 2016
Your change meets the bar and is auto-approved for M53 (branch: 2785)
,
Jul 15 2016
Please merge your change to M53 branch 2785 ASAP (latest by 4:00 PM PST on Monday, 07/18) in order to make it to M53 dev release next week before Beta promotion.
,
Jul 15 2016
groby- could you merge it into M53 for me?
,
Jul 15 2016
This is already merged to M53 branch 2785 - https://chromium.googlesource.com/chromium/src.git/+/81fde70ae27332255d909c9e77493671cccdf0e5. So applying "merge-merged-2785" label and removing "Merge-Approved-53" label. Please correct me if I'm missing anything here. Thank you groby@ for M53 merges.
,
Jul 19 2016
Verified the merge on the latest M-53(53.0.2785.21) on Windows-7 and Linux Ubuntu 14.04 as per the manual steps in C#0. This is working as intended. Attached is the screen-cast of the same.
,
Mar 10 2017
,
Apr 4 2017
,
Apr 27 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by ftang@chromium.org
, May 9 2016