New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610376 link

Starred by 4 users

Issue metadata

Status: Duplicate
Merged: issue 611923
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

Translate icon is not showing up on omnibar after "never translate this language"

Project Member Reported by ftang@chromium.org, May 9 2016

Issue description

Version:  Version after 52.0.2729.0
OS: Windows

What steps will reproduce the problem?
(1) turn on the  "Translate 2016Q2 UI" first.
Visit "chrome://flags", find "Translate 2016Q2 UI", change from "Default" to "Enabled", click on the "Relaunch Now" blue button on the end of the page.
(2) Visit a foreign language site, for example: www.yahoo.co.jp
(3) the translate bubble show up, click "Options: Never translate Japanese"
(4) visit another Japanese page, such as news.google.co.jp

What is the expected output?
The Translate icon showing up in omnibar 

What do you see instead?
The Translate icon not showing up in omnibar 

 

Comment 1 by ftang@chromium.org, May 9 2016

Labels: OS-Linux
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e9194fafbe858338e049ff946d2f844c20f7c944

commit e9194fafbe858338e049ff946d2f844c20f7c944
Author: ftang <ftang@chromium.org>
Date: Tue May 10 05:28:50 2016

Call SetTranslateEnable(true) in the 2016Q2 UI even it is blocked language or blocked URL so Omnibar will display the translate icon

BUG= 610376 

Review-Url: https://codereview.chromium.org/1966443003
Cr-Commit-Position: refs/heads/master@{#392550}

[modify] https://crrev.com/e9194fafbe858338e049ff946d2f844c20f7c944/components/translate/core/browser/translate_manager.cc

Comment 3 by ftang@chromium.org, May 13 2016

Status: Verified (was: Assigned)
verified in "Version 52.0.2735.0 canary (64-bit)"

Comment 4 by ftang@chromium.org, Jul 6 2016

Status: Assigned (was: Verified)
juliecattiau@google.com said UX team want us to rollback this design.

Comment 5 by ftang@chromium.org, Jul 6 2016

Julie- could you confirm in this bug you want this design to be rollback.
Cc: zkoch@chromium.org
I confirm that we want to roll this change back.

Rationale: after users chose to "Never translate" a language or a page, the state in which users are needs to be reflected in the Translate bubble UI. The next time users open the bubble after choosing to "Never translate" by clicking on the omnibox icon, we would ideally show a simplified view of the bubble that informs users they are in a "Never translate" state and gives them the option to undo. For example: "You're not translating German. [Undo] / [Translate Once]". Since this is not something we can easily implement short term, we have decided to rollback the change described in this bug and to not keep the translate icon present in the omnibox after taking a "Never Translate" action for now.

Comment 8 by ftang@chromium.org, Jul 14 2016

Labels: Merge-Request-53

Comment 9 by dimu@google.com, Jul 14 2016

Labels: -Merge-Request-53 Merge-Approved-53 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M53 (branch: 2785)
Please merge your change to M53 branch 2785 ASAP (latest by 4:00 PM PST on Monday, 07/18) in order to make it to M53 dev release next week before Beta promotion.

Comment 11 by ftang@chromium.org, Jul 15 2016

groby- could you merge it into M53 for me?
Labels: -Merge-Approved-53 merge-merged-2785
This is already merged to M53 branch 2785 - https://chromium.googlesource.com/chromium/src.git/+/81fde70ae27332255d909c9e77493671cccdf0e5. So applying "merge-merged-2785" label and removing "Merge-Approved-53" label. Please correct me if I'm missing anything here.

Thank you groby@ for M53 merges.



Comment 13 by ajha@chromium.org, Jul 19 2016

Labels: TE-Verified-M53 TE-Verified-53.0.2785.21
Verified the merge on the latest M-53(53.0.2785.21) on Windows-7 and Linux Ubuntu 14.04 as per the manual steps in C#0. This is working as intended. Attached is the screen-cast of the same.
610376.mp4
1.8 MB View Download
Cc: yyushkina@chromium.org
Mergedinto: 611923
Status: Duplicate (was: Assigned)
Components: -UI>Browser>Translate UI>Browser>Language>Translate

Sign in to add a comment