New issue
Advanced search Search tips

Issue 610374 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 662134
Owner: ----
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move background_sync.mojom from //content to //third_party/WebKit

Project Member Reported by juncai@chromium.org, May 9 2016

Issue description

This thread tracks the move of background_sync.mojom from //content to //third_party/WebKit
 

Comment 1 by juncai@chromium.org, May 10 2016

background_sync implements [1] by having:

1. background_sync related idl files and associated code are in //third_party/WebKit/Source/modules/background_sync

2. //third_party/WebKit/public/platform/modules/background_sync/WebSyncProvider.h
implemented in
//content/child/background_sync/*

3 - a service running in browser at
//content/browser/background_sync/background_sync_service_impl.*
and implementing background_sync_service.mojom.

This bug as part of Onion Soup project tracks removal of [2] by addressing the mojom channel directly from //third_party/WebKit/Source/modules/background_sync.
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30a0e93e8d121381d3674db975ba7ac7838ec7cf

commit 30a0e93e8d121381d3674db975ba7ac7838ec7cf
Author: juncai <juncai@chromium.org>
Date: Wed May 11 00:09:51 2016

[OnionSoup] Move background_sync.mojom from //content to
//third_party/WebKit

This patch is the first step of moving
background_sync.mojom from //content to //third_party/WebKit

BUG= 610374 

Review-Url: https://codereview.chromium.org/1960843002
Cr-Commit-Position: refs/heads/master@{#392779}

[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/app/BUILD.gn
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/BUILD.gn
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/DEPS
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_browsertest.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_context.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_context.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_manager.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_manager.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_manager_unittest.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_registration.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_registration.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_service_impl.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_service_impl.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/browser/background_sync/background_sync_service_impl_unittest.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/child/background_sync/background_sync_provider.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/child/background_sync/background_sync_provider.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/child/background_sync/background_sync_type_converters.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/child/background_sync/background_sync_type_converters.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/child/background_sync/background_sync_type_converters_unittest.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/common/BUILD.gn
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/common/DEPS
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/common/service_worker/service_worker_type_converters.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/common/service_worker/service_worker_type_converters.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/content_common_mojo_bindings.gyp
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/public/browser/BUILD.gn
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/public/common/BUILD.gn
[delete] https://crrev.com/7c46bff409ea163d14af6569b004f7904aa6438e/content/public/common/background_sync.mojom
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/renderer/BUILD.gn
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/renderer/background_sync/background_sync_client_impl.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/renderer/background_sync/background_sync_client_impl.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/renderer/service_worker/service_worker_context_client.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/renderer/service_worker/service_worker_context_client.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/test/BUILD.gn
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/test/test_background_sync_manager.cc
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/test/test_background_sync_manager.h
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/content/utility/BUILD.gn
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/third_party/WebKit/public/platform/modules/background_sync/OWNERS
[rename] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/third_party/WebKit/public/platform/modules/background_sync/background_sync.mojom
[modify] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/third_party/WebKit/public/platform/modules/serviceworker/OWNERS
[rename] https://crrev.com/30a0e93e8d121381d3674db975ba7ac7838ec7cf/third_party/WebKit/public/platform/modules/serviceworker/service_worker_event_status.mojom

Comment 3 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals

Comment 4 by juncai@chromium.org, Sep 15 2016

Owner: ----
Status: Available (was: Started)
Cc: adithyas@chromium.org
Mergedinto: 662134
Status: Duplicate (was: Available)
adithyas@ is working on moving background_sync in  bug 662134 

Sign in to add a comment