New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610370 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Regression: Fullscreen poster image doesn't show.

Project Member Reported by crouleau@chromium.org, May 9 2016

Issue description

Version: broken in 52.0.2729.0, working in 52.0.2723.0
OS: Android

Steps to repro: 
0. Enable Spitzer
1. Go to http://storage.googleapis.com/crouleau-shared/vids/h264_poster.html
2. Click the button to fullscreen the video. 
3. See the the poster image (Google logo) disappears.

Automation shows this problem. See https://av-analysis.corp.google.com/#/get-testpass-details/2/Video%20Stack/130979

Here is a link to last known good version: https://av-analysis.corp.google.com/#/get-testpass-details/2/Video%20Stack/130854, so this was working for 52.0.2723.0
 
Cc: w...@chromium.org
https://chromium.googlesource.com/chromium/src/+log/52.0.2723.0..52.0.2729.0?pretty=fuller&n=10000

This is overlay fullscreen video I think. Which means it's WontFix unless we want janky rotations.

Comment 2 by w...@chromium.org, May 9 2016

Ah, yeah, you're probably right. Do you know whether WMPA shows posters in fullscreen? If not, then I'd agree that it's a wontfix for now.
When I run a test with the flags "--disable-unified-media-pipeline" and "--force-fieldtrials=UnifiedMediaPipelineTrial/Disabled", (which I assume is WMPA), fullscreening the media element results in the poster image disappearing: https://av-analysis.corp.google.com/#/get-testpass-details/2/Video%20Stack/130806

Just to make sure this is clear: this is a regression. So we're trading this ability to display poster images for the ability to reduce fullscreen jankiness. Seems like a reasonable exchange, but I just wanted to be clear.
watk - does adding a check for shouldDisplayVideo() in LayoutVideo::additionalCompositingReasons fix the issue?

not sure that it doesn't have unintended side-effects, though, like "turning off the SV optimization".  the SV was being created properly, but i didn't get a chance to dig deeper to see if it was using the correct drawing path.

Comment 5 by w...@chromium.org, May 9 2016

Good call. Making the condition this works:
    if (shouldDisplayVideo() && element->isFullscreen() && element->usesOverlayFullscreenVideo())

WMPA has seemingly had this bug for no reason. We might have to turn off OverlayFullscreenVideo because of a different but I'm looking at, so we might not need to make this change just yet.
Cc: -w...@chromium.org
Owner: w...@chromium.org
Status: Assigned (was: Untriaged)
Labels: Needs-BlinkMediaTriage
Labels: -Needs-BlinkMediaTriage
Status: Fixed (was: Assigned)

Sign in to add a comment