Regression: Fullscreen poster image doesn't show. |
|||||
Issue descriptionVersion: broken in 52.0.2729.0, working in 52.0.2723.0 OS: Android Steps to repro: 0. Enable Spitzer 1. Go to http://storage.googleapis.com/crouleau-shared/vids/h264_poster.html 2. Click the button to fullscreen the video. 3. See the the poster image (Google logo) disappears. Automation shows this problem. See https://av-analysis.corp.google.com/#/get-testpass-details/2/Video%20Stack/130979 Here is a link to last known good version: https://av-analysis.corp.google.com/#/get-testpass-details/2/Video%20Stack/130854, so this was working for 52.0.2723.0
,
May 9 2016
Ah, yeah, you're probably right. Do you know whether WMPA shows posters in fullscreen? If not, then I'd agree that it's a wontfix for now.
,
May 9 2016
When I run a test with the flags "--disable-unified-media-pipeline" and "--force-fieldtrials=UnifiedMediaPipelineTrial/Disabled", (which I assume is WMPA), fullscreening the media element results in the poster image disappearing: https://av-analysis.corp.google.com/#/get-testpass-details/2/Video%20Stack/130806 Just to make sure this is clear: this is a regression. So we're trading this ability to display poster images for the ability to reduce fullscreen jankiness. Seems like a reasonable exchange, but I just wanted to be clear.
,
May 9 2016
watk - does adding a check for shouldDisplayVideo() in LayoutVideo::additionalCompositingReasons fix the issue? not sure that it doesn't have unintended side-effects, though, like "turning off the SV optimization". the SV was being created properly, but i didn't get a chance to dig deeper to see if it was using the correct drawing path.
,
May 9 2016
Good call. Making the condition this works:
if (shouldDisplayVideo() && element->isFullscreen() && element->usesOverlayFullscreenVideo())
WMPA has seemingly had this bug for no reason. We might have to turn off OverlayFullscreenVideo because of a different but I'm looking at, so we might not need to make this change just yet.
,
May 11 2016
,
Aug 9 2016
,
Nov 3 2016
,
Mar 25 2017
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dalecur...@chromium.org
, May 9 2016