New issue
Advanced search Search tips

Issue 610362 link

Starred by 2 users

Issue metadata

Status: Fixed
Merged: issue 613191
Owner:
Closed: Jun 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug



Sign in to add a comment

ImportSupervisedUserTests is flaky

Project Member Reported by iclell...@chromium.org, May 9 2016

Issue description

Cc: mahmadi@chromium.org
 Issue 610396  has been merged into this issue.
Cc: michae...@chromium.org
michaelpg@, it seems like ImportSupervisedUserTests I merged in https://codereview.chromium.org/1921783002 is flaky in Win7. I can't reproduce the flakiness on linux. I doubt the test logic is wrong. Could checking offsetHeight instead of style.display (to test whether the dialog is visible) be responsible for this?
Cc: rdevlin....@chromium.org
I don't see anything wrong with the tests. I would try adding some logging in the element and the tests to figure out what's going on and run that on Windows trybots.

Devlin settled on checking the results of getBoundingClientRect but I don't see why offsetHeight would return 0.

https://code.google.com/p/chromium/codesearch#chromium/src/chrome/test/data/webui/extensions/extension_test_util.js&q=file:chrome/test/data/webui/extensions%20visible&sq=package:chromium&type=cs&l=79
Mergedinto: 613191
Status: Duplicate (was: Assigned)
Status: Assigned (was: Duplicate)
+jdufault@

 crbug.com/611619  is also causing flakiness in UserManagerBrowserTest.UserManagerTest that relies on offsetHeight calculations.


Owner: jdufault@chromium.org
Also, if you happen to fix this, here's the commit that disabled the flaky tests:

https://chromium.googlesource.com/chromium/src.git/+/1273112816d19f19f1142dfda1ed95b9e8a6de1f


Owner: mahmadi@chromium.org
Status: Started (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e47e3654fd44ec6848cc3bc2123ec5ea08afd111

commit e47e3654fd44ec6848cc3bc2123ec5ea08afd111
Author: mahmadi <mahmadi@chromium.org>
Date: Tue May 31 23:21:08 2016

Use svg icon to avoid lazy loading of Polymer elements for user pods

1) Lazy loading of Polymer was causing flakiness in a set of tests.
2) It also fixes the bug where the overflow menu icon was not appearing on hover.

BUG= 610362 ,  611619 , 615085
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2007133006
Cr-Commit-Position: refs/heads/master@{#396970}

[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/chromeos/login/login_shared.js
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/md_user_manager/user_manager.html
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/md_user_manager/user_manager.js
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/md_user_manager/user_manager_styles.html
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/user_manager/user_manager.html
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/browser/resources/user_manager/user_manager.js
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/test/data/webui/md_user_manager/create_profile_tests.js
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/test/data/webui/md_user_manager/test_profile_browser_proxy.js
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/chrome/test/data/webui/md_user_manager/user_manager_browsertest.js
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/ui/login/account_picker/user_pod_row.css
[modify] https://crrev.com/e47e3654fd44ec6848cc3bc2123ec5ea08afd111/ui/login/account_picker/user_pod_template.html
[delete] https://crrev.com/a8e5d2e3274a104d4a2c54391fc124daaaaae7a7/ui/login/account_picker/user_pod_template.js

Status: Fixed (was: Started)

Sign in to add a comment