md toolbar color doesn't fill all the way to separator at >= 2x scales |
||
Issue descriptionperhaps having something to do with the separator being 1px (not 1dp), the toolbar fill color doesn't go far enough down. See attachment of 3x scale factor --- there are a couple empty rows of pixels at the bottom. This is the opaque browser frame, not sure if other browser frames have this problem.
,
May 13 2016
well I only tested on Linux, I guess there's a chance this only applies there?
,
May 13 2016
Tested my trunk build on Win 10 with --force-device-scale-factor=2 and didn't see any issues with a custom theme (to force the opaque frame) or the default theme (which uses the glass frame). Were you using something with native high DPI? Perhaps that works differently than --force-device-scale-factor somehow for this purpose? Does the problem also show up with custom themes that use the opaque frame, or only the native theme?
,
May 13 2016
> Does the problem also show up with custom themes that use the opaque frame, or only the native theme? I'm only seeing it on classic theme. > Were you using something with native high DPI? no, I was using the flag. I think I found an important clue --- it seems to only happen when the floating bookmark bar is present. I bet it's that bar which is painting a pixel too high. PaintDetachedBookmarkBar is the culprit I bet. BrowserView::Paint1pxHorizontalLine needs to paint the 1px line at the top of the dp area instead of the bottom in this case.
,
May 13 2016
Good find. I can repro on Win with the glass frame with the detached bookmark bar (by default my Chromium build starts up with a couple infobars, in which case this doesn't happen). So that's definitely the critical bit here. I didn't think through your last sentence very closely; I'd just make sure that, when switching tabs back and forth between an NTP with detached bookmark bar, and a "normal" page, the bottom divider of the toolbar doesn't appear to shift up and down at all.
,
May 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b603df9a53ad07971acf622b1ed458279421efe7 commit b603df9a53ad07971acf622b1ed458279421efe7 Author: estade <estade@chromium.org> Date: Sat May 14 20:27:47 2016 [MD] Fix detached bookmark bar top separator in hdpi BUG= 610359 Review-Url: https://codereview.chromium.org/1978943002 Cr-Commit-Position: refs/heads/master@{#393740} [modify] https://crrev.com/b603df9a53ad07971acf622b1ed458279421efe7/chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc [modify] https://crrev.com/b603df9a53ad07971acf622b1ed458279421efe7/chrome/browser/ui/views/frame/browser_view.cc
,
May 16 2016
should be fixed |
||
►
Sign in to add a comment |
||
Comment 1 by pkasting@chromium.org
, May 13 2016Cc: pkasting@chromium.org
Components: UI>Browser>Toolbar