[MD settings] Update order of site settings |
|||||||||||
Issue descriptionThe mocks don't fully specify the order of all the site settings. tbuckley@ suggested that they should match the order in the current content settings dialog. finnur@ suggested that they match the order in Android settings. What order should the site settings be listed in? Here's the order on a Mac laptop (for reference). Cookies Images JavaScript Key Generation Handlers Plugins Pup-ups Location Notifications Microphone Camera Unsandboxed plugin access Automatic Downloads MIDI devices full control USB devices Zoom Leves Mouse cursor lock
,
May 9 2016
The order in the current (legacy) content settings page on Desktop is... weird. I believe it might simply be implementation-order, and not something pre-determined because it seems nonsensical to me (e.g. Location, Mic and Cam buried way down). The Android settings order, on the other hand, was very deliberate. It was ordered by privacy-sensitivity. Most sensitive ones first. Since we're migrating Desktop to what we have on Chrome for Android, we should match that.
,
May 9 2016
Adding a few knowledgeable people on the bug.
,
May 9 2016
,
May 9 2016
I remember sashab@ asking about this when she was working on page info and it came down to we didn't really know why they are listed the way they are, so she proposed the current listing on mobile. I'm OK with either for now (it's not a huge thing to fix later) but consistency is definitely ideal. If we could match mobile that would be great. There might be a few desktop-only though so we can fit them in as seems appropriate.
,
May 10 2016
,
May 20 2016
Agreed-upon order here (via the Chrome Security team) https://docs.google.com/spreadsheets/d/1bVRBeEcJ3YSJNMKq9U9pm-dGFtVRDryzfojoDeYpirI/edit#gid=0
,
May 20 2016
I'll handle Desktop/OIB. I'll re-use this bug for it, if that is OK with you all.
,
May 20 2016
Thanks! SGTM
,
May 23 2016
I put some questions in the spreadsheet: I still have Full Screen and Push Messaging to place somewhere.
,
May 23 2016
CL in progress: https://codereview.chromium.org/2006123002
,
May 24 2016
,
May 24 2016
I'm happy with the "Combined proposal" from the spreadsheet in #7. Assigning to finnur@ to update in MD Settings.
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/16b11315b0cd6a85204055f65f38560ea9c16ca1 commit 16b11315b0cd6a85204055f65f38560ea9c16ca1 Author: finnur <finnur@chromium.org> Date: Wed May 25 19:47:18 2016 Desktop MD Site Settings: Re-order the permission list. Covers both the top-level categories and permission list within the Site Details. No functionality should change as a result. BUG= 610358 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/1998673002 Cr-Commit-Position: refs/heads/master@{#395965} [modify] https://crrev.com/16b11315b0cd6a85204055f65f38560ea9c16ca1/chrome/browser/resources/settings/site_settings/site_details.html [modify] https://crrev.com/16b11315b0cd6a85204055f65f38560ea9c16ca1/chrome/browser/resources/settings/site_settings_page/site_settings_page.html
,
May 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa39cd5f1a36659f95c7eb9c532d97f38536db21 commit aa39cd5f1a36659f95c7eb9c532d97f38536db21 Author: finnur <finnur@chromium.org> Date: Wed May 25 22:30:08 2016 Android Site Settings: Re-order the permission list. Covers both the top-level categories and permission list within the Site Details. No functionality should change as a result. BUG= 610358 Review-Url: https://codereview.chromium.org/1991263002 Cr-Commit-Position: refs/heads/master@{#396011} [modify] https://crrev.com/aa39cd5f1a36659f95c7eb9c532d97f38536db21/chrome/android/java/res/xml/single_website_preferences.xml [modify] https://crrev.com/aa39cd5f1a36659f95c7eb9c532d97f38536db21/chrome/android/java/res/xml/site_settings_preferences.xml
,
May 25 2016
#8: Re-using this bug sounds fine to me. I've re-ordered Android and Desktop (MD). Once you finish Desktop (legacy) and OIB you can probably close this bug out.
,
May 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7715e330567f9aab72ed070618723d533457207d commit 7715e330567f9aab72ed070618723d533457207d Author: palmer <palmer@chromium.org> Date: Fri May 27 00:41:19 2016 New ordering of permissions in the Origin Info Bubble. Per Material Design refresh. BUG= 610358 Review-Url: https://codereview.chromium.org/2006123002 Cr-Commit-Position: refs/heads/master@{#396334} [modify] https://crrev.com/7715e330567f9aab72ed070618723d533457207d/chrome/browser/ui/website_settings/website_settings.cc
,
May 27 2016
Is there any more work to do on this bug?
,
May 27 2016
Don't think so. Unless we want to re-order the old Settings list?
,
May 27 2016
We'll re-order it with the new MD update, right? So I don't know we need to fix the old one.
,
May 27 2016
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by dschuyler@chromium.org
, May 9 2016