New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610357 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

remove ifdef OS_CHROMEOS under chrome/browser/ui/ash

Project Member Reported by osh...@chromium.org, May 9 2016

Issue description

remove ifdef OS_CHROMEOS under chrome/browser/ui/ash and remove views only code.

ben, sky, let me know if you want to keep it.
 
Cc: pelets...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f79172843182eddd6739be5dd9c2c8032a4313c

commit 4f79172843182eddd6739be5dd9c2c8032a4313c
Author: oshima <oshima@chromium.org>
Date: Tue May 10 11:25:03 2016

Remove OS_CHROMEOS from ui/ash code

* Removed unnecessary/unused files
* Remove app_list_shower_views_unittest because app_list on desktop is no longer used.
* Consolidated and eliminated chromeos specific files.
 (new_window_delegate_chromeos, chrome_shell_delegate_chromeos)

I'll rename _chromeos files in a separate CL.

BUG= 610357 

Review-Url: https://codereview.chromium.org/1960293003
Cr-Commit-Position: refs/heads/master@{#392580}

[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/BUILD.gn
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/app_list/app_list_shower_views_unittest.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/accelerator_controller_browsertest.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/app_list/app_list_service_ash.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/app_sync_ui_state.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/ash_init.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/ash_util.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/ash_util.h
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/chrome_new_window_delegate.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/chrome_new_window_delegate.h
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/chrome_new_window_delegate_chromeos.h
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/chrome_screenshot_grabber.h
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/chrome_screenshot_grabber_unittest.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/chrome_shell_content_state.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/chrome_shell_content_state_views.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/chrome_shell_delegate.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/chrome_shell_delegate.h
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/chrome_shell_delegate_chromeos.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/chrome_shell_delegate_views.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/chrome_mash_shelf_controller.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/extension_launcher_context_menu.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/launcher_context_menu.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/launcher/launcher_controller_helper.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/multi_user/multi_user_context_menu.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/multi_user/multi_user_util.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/multi_user/multi_user_window_manager.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/session_state_delegate_views.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/session_state_delegate_views.h
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/ash/session_util.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/system_tray_delegate_common.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/ash/system_tray_delegate_common.h
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/views/chrome_views_delegate.cc
[delete] https://crrev.com/a1ebac8d20d3bd46b3758ef2a949c9fb0e1b30ed/chrome/browser/ui/views/chrome_views_delegate_ash.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/browser/ui/views/desktop_media_picker_views.cc
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/4f79172843182eddd6739be5dd9c2c8032a4313c/chrome/test/BUILD.gn

Comment 3 by osh...@chromium.org, May 12 2016

Status: Fixed (was: Started)
Bulk verified
Status: Verified (was: Fixed)
bulk verified

Sign in to add a comment