New issue
Advanced search Search tips

Issue 610356 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Move presentation_service.mojom from //content to //third_party/WebKit

Project Member Reported by juncai@chromium.org, May 9 2016

Issue description

This thread tracks the move of presentation_service.mojom from //content to //third_party/WebKit
 

Comment 1 by juncai@chromium.org, May 10 2016

presentation implements [1] by having:

1. presentation related idl files and associated code are in //third_party/WebKit/Source/modules/presentation

2. //third_party/WebKit/public/platform/modules/presentation/WebPresentationConnectionClient.h
and
//third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h
implemented in
//content/renderer/presentation/*

3 - a service running in browser at
//content/browser/presentation/presentation_service_impl.*
and implementing presentation_service.mojom.

This bug as part of Onion Soup project tracks removal of [2] by addressing the mojom channel directly from //third_party/WebKit/Source/modules/presentation.
Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e343fd275b527d5bd3d289196a34f05a1f5d784

commit 9e343fd275b527d5bd3d289196a34f05a1f5d784
Author: juncai <juncai@chromium.org>
Date: Thu May 12 00:24:57 2016

[OnionSoup] Move persentation_service.mojom from //content to
//third_party/WebKit

This patch is the first step of moving
persentation_service.mojom from //content to
//third_party/WebKit

BUG= 610356 

Review-Url: https://codereview.chromium.org/1957143002
Cr-Commit-Position: refs/heads/master@{#393117}

[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/browser/DEPS
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/browser/presentation/presentation_service_impl.cc
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/browser/presentation/presentation_service_impl.h
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/browser/presentation/presentation_service_impl_unittest.cc
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/browser/presentation/presentation_type_converters.cc
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/browser/presentation/presentation_type_converters.h
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/browser/presentation/presentation_type_converters_unittest.cc
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/common/BUILD.gn
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/content_common_mojo_bindings.gyp
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/renderer/presentation/presentation_connection_client.cc
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/renderer/presentation/presentation_connection_client.h
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/renderer/presentation/presentation_dispatcher.cc
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/content/renderer/presentation/presentation_dispatcher.h
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/third_party/WebKit/public/blink.gyp
[modify] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/third_party/WebKit/public/platform/modules/presentation/OWNERS
[rename] https://crrev.com/9e343fd275b527d5bd3d289196a34f05a1f5d784/third_party/WebKit/public/platform/modules/presentation/presentation.mojom

Comment 3 by tkent@chromium.org, Jun 23 2016

Components: -Blink>Architecture Blink>Internals
Renaming Blink>Architecture to Blink>Internals

Comment 4 by juncai@chromium.org, Sep 15 2016

Owner: ----
Status: Available (was: Started)
Cc: mfo...@chromium.org yukishiino@chromium.org
Components: Blink>PresentationAPI
Can this be closed now?
I think so.
Status: Fixed (was: Available)

Sign in to add a comment