CronetBidirectionalStreamAdapter leak array |
|||
Issue description
We allocate a JNI array in CronetBidirectionalStreamAdapter::OnDataSent, but we didn't delete it. We should wrap |jbuffers| with ScopedJavaLocalRef to perform cleanup tasks.
jobjectArray jbuffers =
env->NewObjectArray(size, byte_buffer_clazz.obj(), NULL);
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c524bde480633344575ff0a2b0b8a7489ee07156 commit c524bde480633344575ff0a2b0b8a7489ee07156 Author: xunjieli <xunjieli@chromium.org> Date: Mon May 09 23:05:27 2016 Fix leak in CronetBidirectionalStreamAdapter::OnDataSent This CL wraps the newly created jobjectArray with ScopedJavaLocalRef so that the object is deleted when call returns. BUG= 610353 Review-Url: https://codereview.chromium.org/1960243002 Cr-Commit-Position: refs/heads/master@{#392463} [modify] https://crrev.com/c524bde480633344575ff0a2b0b8a7489ee07156/components/cronet/android/cronet_bidirectional_stream_adapter.cc [modify] https://crrev.com/c524bde480633344575ff0a2b0b8a7489ee07156/components/cronet/android/cronet_bidirectional_stream_adapter.h
,
May 9 2016
,
Aug 17 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by xunji...@chromium.org
, May 9 2016Status: Started (was: Assigned)