New issue
Advanced search Search tips

Issue 610349 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

caches.match() should not reject on missing name

Project Member Reported by jsb...@chromium.org, May 9 2016

Issue description

Spec change:

https://github.com/slightlyoff/ServiceWorker/issues/891

Previously:

caches.match(url, {name:'no_such_cache'}) --> rejects

Now:

caches.match(url, {name:'no_such_cache'}) --> resolves undefined

The cache is NOT implicitly created.

 
Hrm, perhaps we're already implemented this way? CacheStorage::MatchCallbacks::onError already maps not found error to undefined resolution...
Owner: jinho.b...@samsung.com
Status: Started (was: Available)
CL: https://codereview.chromium.org/2161423003/
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9916998beca540fc96101352626d49fd0193dca8

commit 9916998beca540fc96101352626d49fd0193dca8
Author: jinho.bang <jinho.bang@samsung.com>
Date: Thu Jul 21 10:57:55 2016

CacheStorage: caches.match with bad cacheName should resolve with undefined.

Make caches.match(request, options)'s promise resolve with undefined (rather
than reject) when options.cacheName is given but no corresponding Cache object
is found.

Related spec issue:
  https://github.com/slightlyoff/ServiceWorker/issues/891

BUG= 610349 

Review-Url: https://codereview.chromium.org/2161423003
Cr-Commit-Position: refs/heads/master@{#406817}

[modify] https://crrev.com/9916998beca540fc96101352626d49fd0193dca8/third_party/WebKit/LayoutTests/http/tests/cachestorage/script-tests/cache-storage-match.js
[modify] https://crrev.com/9916998beca540fc96101352626d49fd0193dca8/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/9916998beca540fc96101352626d49fd0193dca8/third_party/WebKit/Source/modules/cachestorage/CacheStorageError.cpp

Status: Fixed (was: Started)

Sign in to add a comment