Blink test runner: support mocking ImageCapture browser mojo interface |
||||
Issue descriptionBlinkTestRunner uses a MockVideoCapturerSource to fill in the content/ side of the appropriate MediaStream Video Track and Source [1]. Consider extending that functionality, and mocking the ImageCapture mojo interface (usually implemented in renderer_host in [2]) in a similar fashion to USB [3], for LayoutTests. [1] https://code.google.com/p/chromium/codesearch#chromium/src/content/public/renderer/media_stream_utils.cc&sq=package:chromium&type=cs&l=27&rcl=1462792609 [2] https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/media/capture/image_capture_impl.h&sq=package:chromium&type=cs&l=15&q=imagecaptureimpl [3] https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/usb/resources/usb-helpers.js&sq=package:chromium&type=cs&l=35&q=usb%20mojo%20js
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1ac16005aa53c3ceecd666a892371834074d83b commit b1ac16005aa53c3ceecd666a892371834074d83b Author: mcasas <mcasas@chromium.org> Date: Thu May 12 17:36:08 2016 ImageCapture: takePhoto() mock LayoutTest ImageCapture takePhoto() implementation needs a meaningful MediaStream implementation in Browser side, but LayoutTests doesn't have it. Following the example of USB, 'battery-status' and 'payments' Layout Tests, this CL: - creates a LayoutTest entry for image capture - defines a MockImageCapture js class, that simply resolves successfully the takePhoto() Promise - adds a JS test that instantiates said Mock and exercises it. The previous LayoutTest/fast/imagecapture/...takePhoto is removed. BUG= 610333 Review-Url: https://codereview.chromium.org/1966083003 Cr-Commit-Position: refs/heads/master@{#393290} [delete] https://crrev.com/b9592f971b67c5e0bc80c9298a46ad6c06fa478a/third_party/WebKit/LayoutTests/fast/imagecapture/ImageCapture-takePhoto.html [add] https://crrev.com/b1ac16005aa53c3ceecd666a892371834074d83b/third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js [add] https://crrev.com/b1ac16005aa53c3ceecd666a892371834074d83b/third_party/WebKit/LayoutTests/imagecapture/takephoto.html
,
May 12 2016
,
May 23 2016
Renaming Blink>ImageCapture to Blink>MediaStream>ImageCapture. Moving these bugs to the new component.
,
Nov 23 2016
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mcasas@chromium.org
, May 9 2016