New issue
Advanced search Search tips

Issue 610327 link

Starred by 1 user

Issue metadata

Status: Fixed
Merged: issue 609941
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Fix and reenable memory.mobile_memory on three Android devices

Project Member Reported by oysteine@chromium.org, May 9 2016

Issue description

Fails almost ever ytime; disabling in https://codereview.chromium.org/1959073002/
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/971e788d0f58fc7238c11cc8c715c5f0ecc37248

commit 971e788d0f58fc7238c11cc8c715c5f0ecc37248
Author: oysteine <oysteine@chromium.org>
Date: Mon May 09 18:21:12 2016

Disabled memory.mobile_memory

TBR=nednguyen
BUG= 610327 
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review-Url: https://codereview.chromium.org/1959073002
Cr-Commit-Position: refs/heads/master@{#392365}

[modify] https://crrev.com/971e788d0f58fc7238c11cc8c715c5f0ecc37248/tools/perf/benchmarks/memory.py

Summary: Fix and reenable memory.mobile_memory on three Android devices (was: memory.mobile_memory flakiness on three Android devices)
Project Member

Comment 5 by 42576172...@developer.gserviceaccount.com, May 10 2016

Mergedinto: 609941
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : [Reland 1] Pepper takes ownership of a mailbox before passing it to the texture layer.
Author  : erikchen
Commit description:
  
This CL makes three changes from the original.

1. Replace a call to std::remove_if() with vec.erase(std::remove_if(), ...).
This was a logic error in the original CL that caused a crash any time the size
of the buffer was changed. This CL also adds a test that catches this bug.

2. Add some simple reference counting to PepperPluginInstanceImpl to track the
fact that a cc::TextureMailbox may be passed to |texture_layer_| more than once.

3. The SyncToken signal is now processed in the context of its own message:
WaitSyncToken.

> I replaced the IPC message GpuCommandBufferMsg_ProduceFrontBuffer with
> GpuCommandBufferMsg_TakeFrontBuffer and GpuCommandBufferMsg_ReturnFrontBuffer.
> TakeFrontBuffer gives ownership of the front buffer to the client. When the
> client returns it with ReturnFrontBuffer, the command buffer may choose to reuse
> it.
>
> This means that pepper no longer needs to use
> SetTextureMailboxWithoutReleaseCallback.

BUG= 350204 ,  602484 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
TEST=Run Chromium with the Pepper Flash plugin. Visit a site that supports Flash
video, such as http://vudu.com. Start playing a video, and then fullscreen the
video. Observe that Chromium does not crash. Please extensively test Chromium on
Flash 3D games and Flash video and make sure nothing else is working
incorrectly.
TBR=ccameron@chromium.org, bbudge@chromium.org, sky@chromium.org

Review-Url: https://codereview.chromium.org/1943513002
Cr-Commit-Position: refs/heads/master@{#391686}
Commit  : 4734ed1b6740b772201b8accb3e2bd88cdea5c99
Date    : Wed May 04 23:25:19 2016


===== TESTED REVISIONS =====
Revision         Exit Code  Std Dev  N   Good?
chromium@391664  0          N/A      20  good
chromium@391679  0          N/A      20  good
chromium@391683  0          N/A      20  good
chromium@391685  0          N/A      20  good
chromium@391686  1          N/A      20  bad    <--
chromium@391693  1          N/A      20  bad
chromium@391721  1          N/A      20  bad
chromium@391778  1          N/A      20  bad

Bisect job ran on: android_nexus7_perf_bisect
Bug ID: 610327

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests memory.mobile_memory
Test Metric: Memory_BrowserUsed/http___techcrunch.com
Relative Change: Zero to non-zero
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus7_perf_bisect/builds/2962
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013126809961805904


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5790308051189760

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Owner: oysteine@chromium.org
Status: Assigned (was: Duplicate)
Looks like Erik's CL has already been reverted. Oystein, can you re-enable the test?
Project Member

Comment 8 by bugdroid1@chromium.org, May 10 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d48fc855a10604d96b1798beb1fdbc0a065e350

commit 7d48fc855a10604d96b1798beb1fdbc0a065e350
Author: oysteine <oysteine@chromium.org>
Date: Tue May 10 15:05:40 2016

Revert of Disabled memory.mobile_memory (patchset #1 id:1 of https://codereview.chromium.org/1959073002/ )

Reason for revert:
Re-enabling test, crash should be fixed.

Original issue's description:
> Disabled memory.mobile_memory
>
> TBR=nednguyen
> BUG= 610327 
> CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq
>
> Committed: https://crrev.com/971e788d0f58fc7238c11cc8c715c5f0ecc37248
> Cr-Commit-Position: refs/heads/master@{#392365}

TBR=nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 610327 

Review-Url: https://codereview.chromium.org/1961423002
Cr-Commit-Position: refs/heads/master@{#392604}

[modify] https://crrev.com/7d48fc855a10604d96b1798beb1fdbc0a065e350/tools/perf/benchmarks/memory.py

Status: Fixed (was: Assigned)

Sign in to add a comment