New issue
Advanced search Search tips

Issue 610321 link

Starred by 0 users
Status: Fixed
Owner:
k...@chromium.org
Closed: Oct 2016
Cc:
jdonnelly@chromium.org
tedc...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Answer in suggest icon and text spacing discussion

Project Member Reported by k...@chromium.org, May 9 2016 
The new answers in suggest types have triggered an evaluation of
the spacing of the text on the answer line versus the icon, if any.
This issue is to discuss those changes.

Comment 1 by k...@chromium.org, May 9 2016 

chrome-50.png - Chrome v50
chrome-head.png - git head, a few days ago, notice clouds dip below text
chrome-head-with-links.png - how head handles links
chrome-my-proposal.png - moving text down to align with clouds
chrome-my-proposal-with-links.png - displaying how URLs look with change, looks ok to me
chrome-backing-off-icon-move.png - if instead we don't move icon so much, won't require checking hasAnswer(), looks a little crowded to me
chrome-50.png
21.3 KB View Download
chrome-backing-off-icon-move.png
24.9 KB View Download
chrome-head.png
24.4 KB View Download
chrome-head-with-links.png
49.5 KB View Download
chrome-my-proposal.png
24.3 KB View Download
chrome-my-proposal-with-links.png
49.9 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, May 11 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/acc5363c0ee839d955b7bb26054f0d4611d0c3c7

commit acc5363c0ee839d955b7bb26054f0d4611d0c3c7
Author: krb <krb@chromium.org>
Date: Wed May 11 14:42:26 2016

Align suggestion text with icon.

Text was a tad high, since icon was moved down.

Parent bug: 591803.

BUG= 610321 

Review-Url: https://codereview.chromium.org/1924463002
Cr-Commit-Position: refs/heads/master@{#392922}

[modify] https://crrev.com/acc5363c0ee839d955b7bb26054f0d4611d0c3c7/chrome/android/java/src/org/chromium/chrome/browser/omnibox/SuggestionView.java

Comment 3 by rsgav...@chromium.org, May 20 2016

Status: Assigned (was: Unconfirmed)

Comment 4 by k...@chromium.org, Oct 24 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment