font-style-matching-* tests are flaky |
|||
Issue descriptionThree layout tests have been flaking since May 6 (friday) -- I don't see any immediate cause, but the symptom is always the same: Periodic fallback to Times New Roman causing the test to fail. Samples: (Most recent, test #4) https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/12091 (Test #7) https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/12087 (First occurrence I can find: Test #8) https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/12010 This may be related to the still-open crbug.com/516680 , but I'm not sure if it's the same root cause.
,
May 9 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e68443cdd52b78f2b36f02fb8c4fb43e8a21a8f commit 5e68443cdd52b78f2b36f02fb8c4fb43e8a21a8f Author: iclelland <iclelland@chromium.org> Date: Mon May 09 14:05:56 2016 Mark font-style-matching layout tests as flaky TBR=kojii@chromium.org NOTRY=true BUG= 610300 , 516680 Review-Url: https://codereview.chromium.org/1964503002 Cr-Commit-Position: refs/heads/master@{#392305} [modify] https://crrev.com/5e68443cdd52b78f2b36f02fb8c4fb43e8a21a8f/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 27 2016
I just got booted from the CQ for hitting this flake on Windows: https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/246117 I'll disable these tests on all platforms instead of just Linux.
,
Jun 27 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a89a48f2287cae61689b5d413d0cefef5516581a commit a89a48f2287cae61689b5d413d0cefef5516581a Author: rbyers <rbyers@chromium.org> Date: Mon Jun 27 21:51:23 2016 Completely disable flaky font-style-matching tests BUG= 610300 TBR=drott@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2107563002 Cr-Commit-Position: refs/heads/master@{#402303} [modify] https://crrev.com/a89a48f2287cae61689b5d413d0cefef5516581a/third_party/WebKit/LayoutTests/TestExpectations
,
Jun 29 2016
,
Dec 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad5e492f756d2c4fdc78f225da867e0e84cb46f6 commit ad5e492f756d2c4fdc78f225da867e0e84cb46f6 Author: yhirano <yhirano@chromium.org> Date: Tue Dec 20 07:59:51 2016 Mark css3/fonts/font-style-matching-* tests as flaky Some of them have already been marked as flaky, but others look also flaky. BUG= 610300 TBR=drott@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2590793002 Cr-Commit-Position: refs/heads/master@{#439744} [modify] https://crrev.com/ad5e492f756d2c4fdc78f225da867e0e84cb46f6/third_party/WebKit/LayoutTests/TestExpectations
,
Mar 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/42bd5bf1a4db228077a4b44c70bff956470f0a75 commit 42bd5bf1a4db228077a4b44c70bff956470f0a75 Author: ksakamoto <ksakamoto@chromium.org> Date: Mon Mar 06 10:46:09 2017 FontFaceSet.ready should not be resolved if there's pending layouts Currently, FontFaceSet.ready returns resolved promise if there's no loading fonts. But there may be pending stylesheet changes or layout operations, which may cause font loads. So, this patch adds a Document::updateStyleAndLayout() call in FontFaceSet::ready() before returning a resolved promise. This is a speculative fix to deflake css3/fonts/font-style-matching-* tests. BUG= 516680 , 610300 Review-Url: https://codereview.chromium.org/2722493002 Cr-Commit-Position: refs/heads/master@{#454845} [modify] https://crrev.com/42bd5bf1a4db228077a4b44c70bff956470f0a75/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/42bd5bf1a4db228077a4b44c70bff956470f0a75/third_party/WebKit/LayoutTests/fast/css/fontfaceset-ready.html [modify] https://crrev.com/42bd5bf1a4db228077a4b44c70bff956470f0a75/third_party/WebKit/Source/core/css/FontFaceSet.cpp
,
Mar 7 2017
My change {#454845} appears to have fixed font-style-matching-* flakiness.
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=css3%2Ffonts%2Ffont-style-matching
,
Mar 8 2017
Thank you! |
|||
►
Sign in to add a comment |
|||
Comment 1 by iclell...@chromium.org
, May 9 2016