Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 6103 Individual download items on the download shelf are not mirrored on RTL locales
Starred by 3 users Project Member Reported by xji@chromium.org, Jan 7, 2009 Back to list
Status: Fixed
Owner: xji@chromium.org
Closed: Jun 2009
Cc: xlyuan@chromium.org, jeremy@chromium.org, hbono@chromium.org, js...@chromium.org, idana@chromium.org
Components:
OS: All
Pri: 3
Type: Bug
RTL

Restricted
  • Only users with Commit permission may comment.


Sign in to add a comment
<see b\1163334>

What steps will reproduce the problem?
run RTL Chrome and download a file 

What is the expected output? What do you see instead?
When running the Hebrew version on Chrome and downloading files, download 
items on the download shelf correctly appear from right to left. However, 
each individual item is not mirrored. Specifically:

1) The item drop down arrow resides on the right hand side of the item and 
not the left hand side.
2) The animation is drawn on the left and side instead of the right hand 
side.


Please use labels and text to provide additional information.


 
Comment 1 by lafo...@chromium.org, Jan 13, 2009
Status: Assigned
Comment 2 by jeremy@chromium.org, Apr 22, 2009
Status: Started
Hi Idan,
Can I work on this? If you already created patches for this, please let me know.


Comment 4 by jeremy@chromium.org, May 19, 2009
In general if the bug isn't marked as started you can change the status and add yourself 
as an owner, then it's all yours! :)
Thanks for tackling this issue!
Comment 5 by xji@chromium.org, May 19, 2009
Thanks for working on this!

In case you did not notice. 
There are 2 comments about this bug in download_item_view.cc. You can search for 
1163334 for the comments.

One comments mentioned the following which I did not quite understand. Please make 
sure you understand it and keep the animation works when fixing it.

  // We explicitly disable mirroring for the item because the code that draws
  // the download progress animation relies on the View's UI layout setting
  // when positioning the animation so we should make sure that code doesn't
  // treat our View as a mirrored View.
Comment 6 by bugdro...@gmail.com, May 21, 2009
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=16616 

------------------------------------------------------------------------
r16616 | xji@chromium.org | 2009-05-21 10:11:21 -0700 (Thu, 21 May 2009) | 15 lines
Changed paths:
   M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/download_started_animation_win.cc?r1=16616&r2=16615

This is the merge of Yusuke's patch at:
http://codereview.chromium.org/113583

Draw the big arrow animation on the right side on RTL locales.

1) The item drop down arrow resides on the right hand side of the item and 
not the left hand side.
2) The animation is drawn on the left and side instead of the right hand
side.

This patch only fixes the issue 2) above. I'll fix 1) in separate change list.

BUG=http://crbug.com/6103
TBR=Yusuke
Review URL: http://codereview.chromium.org/115609
------------------------------------------------------------------------

Comment 8 by xji@chromium.org, Jun 12, 2009
Status: Fixed
Review URL: http://codereview.chromium.org/118260
fixed in r18292
Comment 9 by lafo...@chromium.org, Mar 19, 2011
Labels: -I18N bulkmove Feature-I18N
Project Member Comment 10 by bugdroid1@chromium.org, Oct 13, 2012
Labels: Restrict-AddIssueComment-Commit
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Project Member Comment 11 by bugdroid1@chromium.org, Mar 11, 2013
Labels: -Feature-I18N Cr-UI-I18N
Project Member Comment 12 by bugdroid1@chromium.org, Mar 20, 2013
Labels: -Cr-UI-I18N Cr-UI-Internationalization
Sign in to add a comment