New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 610299 link

Starred by 6 users
Status: Assigned
Owner:
marcuskoehler@chromium.org
Cc:
█ andra.pa...@intel.com
█ dskaram@chromium.org
█ valentin...@intel.com
steve...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment

Add showInShelf boolean param to chrome.app.window.create()

Project Member Reported by dskaram@google.com, May 9 2016 
Virtualization apps offer a portal for Chrome OS users into legacy operating systems. More advanced implementations even offer a seamless experience by windowing those remote applications making the experience feel almost native. While the windowing integration works, the launcher integration still lags introducing friction into what should be a quasi-native experience.


PRD: https://docs.google.com/document/d/18LzoajII9l7sHSGHDz6sUUKWKVpeTQiuu9xrYwQXyic/
Project Member

Comment 1 by sheriffbot@chromium.org, Jun 2 2016

Labels: Hotlist-Google
Project Member

Comment 2 by sheriffbot@chromium.org, Jul 10 2016

Labels: -M-53 M-54 MovedFrom-53
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3049b971f57ee97b1a602605e90ca18223a30653

commit 3049b971f57ee97b1a602605e90ca18223a30653
Author: valentin.ilie <valentin.ilie@intel.com>
Date: Mon Jul 18 11:41:53 2016

Enhance chrome.app.window API with better shelf integration

Enhance chrome.app.window API with the possibility of creating a window that
will show up separately in the shelf, tied to its own icon.

Added a new property, showInShelf, to CreateWindowOptions. Default value for
the property is false.

Based on https://codereview.chromium.org/1811523002

Co-Authored-By: Paul Sapunaru <paul.sapunaru@intel.com>
Co-Authored-By: Andra Paraschiv <andra.paraschiv@intel.com>

BUG=610299
TEST=interactive_ui_tests
Implement a simple extension that creates windows with the property set
to true. Observe that the newly created windows are added as separate icons in
the shelf.

Review-Url: https://codereview.chromium.org/1914993002
Cr-Commit-Position: refs/heads/master@{#405978}

[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/AUTHORS
[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.h
[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/extensions/browser/api/app_window/app_window_api.cc
[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/extensions/browser/app_window/app_window_interactive_uitest.cc
[modify] https://crrev.com/3049b971f57ee97b1a602605e90ca18223a30653/extensions/common/api/app_window.idl
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ebbb79d24ceb6625788dc9b121b880700b6340d6

commit ebbb79d24ceb6625788dc9b121b880700b6340d6
Author: andra.paraschiv <andra.paraschiv@intel.com>
Date: Tue Aug 16 07:22:04 2016

Enhance chrome.app.window API with icon property

Enhance chrome.app.window API with the possibility of creating a window that
has its own icon in the shelf.

Added a new property, icon, to CreateWindowOptions.

Based on https://codereview.chromium.org/1914993002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299
TEST=interactive_ui_tests
Implement a simple extension that creates windows with icon property set to an
image url. Observe that the newly created windows have their own icons in the
shelf.

Review-Url: https://codereview.chromium.org/2209053004
Cr-Commit-Position: refs/heads/master@{#412185}

[modify] https://crrev.com/ebbb79d24ceb6625788dc9b121b880700b6340d6/extensions/browser/api/app_window/app_window_api.cc
[modify] https://crrev.com/ebbb79d24ceb6625788dc9b121b880700b6340d6/extensions/browser/app_window/app_window.cc
[modify] https://crrev.com/ebbb79d24ceb6625788dc9b121b880700b6340d6/extensions/browser/app_window/app_window.h
[modify] https://crrev.com/ebbb79d24ceb6625788dc9b121b880700b6340d6/extensions/common/api/app_window.idl
[modify] https://crrev.com/ebbb79d24ceb6625788dc9b121b880700b6340d6/ui/gfx/image/image_skia_operations.cc
[modify] https://crrev.com/ebbb79d24ceb6625788dc9b121b880700b6340d6/ui/gfx/image/image_skia_operations.h
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49ef88e5d3371340c6b04123b3659207995dbe09

commit 49ef88e5d3371340c6b04123b3659207995dbe09
Author: andra.paraschiv <andra.paraschiv@intel.com>
Date: Fri Sep 02 13:09:55 2016

Enhance chrome.app.window API for shelf integration with pinning support

Enhance the chrome.app.window API for shelf integration with the possibility of
pinning the showInShelf=true windows.

Based on https://codereview.chromium.org/1914993002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299
TEST=interactive_ui_tests
Implement a simple extension that creates windows with showInShelf property set
to true. Pin a newly created window that has its own icon in the shelf, then
close it and open it again by clicking the pinned icon.
TEST= https://codereview.chromium.org/2297633002

Review-Url: https://codereview.chromium.org/2290603002
Cr-Commit-Position: refs/heads/master@{#416252}

[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/ash/common/shelf/shelf_delegate.h
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/ash/mus/shelf_delegate_mus.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/ash/mus/shelf_delegate_mus.h
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/ash/shelf/shelf_view_unittest.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/ash/shelf/shelf_widget_unittest.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/ash/test/test_shelf_delegate.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/ash/test/test_shelf_delegate.h
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.h
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/app_window_launcher_item_controller.h
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/arc_app_deferred_launcher_item_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/arc_app_window_launcher_item_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/arc_playstore_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/browser_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/extension_app_window_launcher_controller.h
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/extension_app_window_launcher_item_controller.h
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/launcher_item_controller.cc
[modify] https://crrev.com/49ef88e5d3371340c6b04123b3659207995dbe09/chrome/browser/ui/ash/launcher/launcher_item_controller.h
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9a980f3718e5d262ee429032fb7083caa9ba343

commit f9a980f3718e5d262ee429032fb7083caa9ba343
Author: andra.paraschiv <andra.paraschiv@intel.com>
Date: Wed Oct 19 10:55:46 2016

Add AppLauncherId wrapper for items shown in shelf

Add AppLauncherId wrapper in the chrome launcher prefs codebase. It includes a
unique chrome launcher id for a shelf item.

The "AppLauncherId(const std::string& app_id, const std::string& launch_id)"
constructor is currently unused, but will be used in a follow-up CL.

Based on https://codereview.chromium.org/2290603002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299
TEST=LauncherPlatformAppBrowserTest

Review-Url: https://chromiumcodereview.appspot.com/2352353002
Cr-Commit-Position: refs/heads/master@{#426145}

[modify] https://crrev.com/f9a980f3718e5d262ee429032fb7083caa9ba343/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/f9a980f3718e5d262ee429032fb7083caa9ba343/chrome/browser/ui/ash/chrome_launcher_prefs.h
[modify] https://crrev.com/f9a980f3718e5d262ee429032fb7083caa9ba343/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/f9a980f3718e5d262ee429032fb7083caa9ba343/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
Project Member

Comment 7 by bugdroid1@chromium.org, Oct 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4b52d653d510dc49d944b824d0aa7d6ef41b8924

commit 4b52d653d510dc49d944b824d0aa7d6ef41b8924
Author: andra.paraschiv <andra.paraschiv@intel.com>
Date: Tue Oct 25 11:35:47 2016

Enhance chrome.app.window API for shelf integration with pinning support (cont.)

Enhance the chrome.app.window API for shelf integration with the possibility of
pinning the showInShelf=true windows.

Based on https://codereview.chromium.org/2290603002
Based on https://codereview.chromium.org/2352353002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299
TEST=interactive_ui_tests
Implement a simple extension that creates windows with showInShelf property set
to true. Pin a newly created window that has its own icon in the shelf, then
close it and open it again by clicking the pinned icon.
TEST= https://codereview.chromium.org/2297633002

Review-Url: https://codereview.chromium.org/2341643002
Cr-Commit-Position: refs/heads/master@{#427323}

[modify] https://crrev.com/4b52d653d510dc49d944b824d0aa7d6ef41b8924/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/4b52d653d510dc49d944b824d0aa7d6ef41b8924/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/4b52d653d510dc49d944b824d0aa7d6ef41b8924/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.cc
[modify] https://crrev.com/4b52d653d510dc49d944b824d0aa7d6ef41b8924/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl.h
[modify] https://crrev.com/4b52d653d510dc49d944b824d0aa7d6ef41b8924/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[modify] https://crrev.com/4b52d653d510dc49d944b824d0aa7d6ef41b8924/chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
[modify] https://crrev.com/4b52d653d510dc49d944b824d0aa7d6ef41b8924/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.cc
[modify] https://crrev.com/4b52d653d510dc49d944b824d0aa7d6ef41b8924/chrome/browser/ui/ash/launcher/chrome_launcher_controller_mus.h
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e540da313b52ec3960a635acce256c042335a7eb

commit e540da313b52ec3960a635acce256c042335a7eb
Author: andra.paraschiv <andra.paraschiv@intel.com>
Date: Thu Dec 08 09:06:35 2016

Fix icon with badge size for items shown in shelf

Fix icon size for items shown in shelf such that the badge appended to the image
appear correctly.

Based on https://codereview.chromium.org/2341643002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299
TEST = https://codereview.chromium.org/2297633002

Review-Url: https://codereview.chromium.org/2530903002
Cr-Commit-Position: refs/heads/master@{#437218}

[modify] https://crrev.com/e540da313b52ec3960a635acce256c042335a7eb/extensions/browser/app_window/app_window.cc
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 15 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4e4fb8bbebc3d8f3e38130021daec21b760c5840

commit 4e4fb8bbebc3d8f3e38130021daec21b760c5840
Author: andra.paraschiv <andra.paraschiv@intel.com>
Date: Thu Dec 15 11:13:54 2016

Enhance chrome.app.window API for shelf integration with restore support

Enhance the chrome.app.window API for shelf integration with the possibility of
restoring showInShelf=true pinned windows.

Based on https://codereview.chromium.org/2341643002

Co-Authored-By: Valentin Ilie <valentin.ilie@intel.com>;

BUG=610299

TEST = https://codereview.chromium.org/2297633002

Review-Url: https://codereview.chromium.org/2523053004
Cr-Commit-Position: refs/heads/master@{#438803}

[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/apps/launcher.cc
[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/apps/launcher.h
[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/chrome/browser/ui/ash/launcher/app_shortcut_launcher_item_controller.cc
[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/chrome/browser/ui/ash/launcher/launcher_controller_helper.cc
[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/chrome/browser/ui/ash/launcher/launcher_controller_helper.h
[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/chrome/browser/ui/extensions/app_launch_params.h
[modify] https://crrev.com/4e4fb8bbebc3d8f3e38130021daec21b760c5840/chrome/browser/ui/extensions/application_launch.cc

Comment 10 by dskaram@chromium.org, Aug 23

Owner: marcuskoehler@chromium.org

Comment 11 by zalcorn@chromium.org, Sep 28 

Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.

Comment 12 by weifangsun@chromium.org, Nov 8 

<UI triage> Bug owners, please add the appropriate component to your bug. Thanks!

Comment 13 by marcuskoehler@chromium.org, Nov 8

Components: Enterprise
►

Sign in to add a comment