New issue
Advanced search Search tips

Issue 610293 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Feature



Sign in to add a comment

Cronet should netlog on network change events

Project Member Reported by pauljensen@chromium.org, May 9 2016

Issue description

In Chrome this is done in chrome/ but we should consider doing it in Cronet.

Here's where I did some of this in Chrome 3.5 years ago:
  https://chromiumcodereview.appspot.com/11270039

The NetworkChangeNotifier cannot do this itself because it is a singleton and there may be many netlogs.  We could consider moving IOThread::LoggingNetworkChangeObserver into a net/ class.

Related internal bug b/28633768
 
Owner: pauljensen@chromium.org
Status: Started (was: Available)
https://codereview.chromium.org/1971853002
Project Member

Comment 3 by bugdroid1@chromium.org, May 21 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39a25a0c1fa4a6fd24ed3898e3231caa298a2e33

commit 39a25a0c1fa4a6fd24ed3898e3231caa298a2e33
Author: pauljensen <pauljensen@chromium.org>
Date: Sat May 21 02:04:42 2016

[Cronet] Add network change events to Cronet's NetLog

These NetLog events are quite useful for debugging.

BUG= 610293 
R=xunjieli

Review-Url: https://codereview.chromium.org/1977543002
Cr-Commit-Position: refs/heads/master@{#395231}

[modify] https://crrev.com/39a25a0c1fa4a6fd24ed3898e3231caa298a2e33/components/cronet/android/cronet_url_request_context_adapter.cc

Status: Fixed (was: Started)

Sign in to add a comment