A transform: rotateY, backface-visibility hidden element don't appear on time when rotated
Reported by
meytalm...@gmail.com,
May 9 2016
|
|||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.36 Safari/537.36 Example URL: https://crazylister.com/ Steps to reproduce the problem: 1. Open the link that's attached on Chrome 51.0.2704.36 beta-m. 2. Click on "Log in here" in the form that appear on the right side of the page. 3. Click on "Forgot password?" What is the expected behavior? When the form rotates it should look like a 3D element that is rotating as it does on Firefox (for example version 46.0.1) What went wrong? The backface-visibility hidden element don't appear on time causing the 3D illusion to be absent. Does it occur on multiple sites: N/A Is it a problem with a plugin? No Did this work before? Yes On Chrome 50.0.2661.91 Does this work in other browsers? Yes Chrome version: 51.0.2704.36 Channel: beta OS Version: 10.0 Flash Version: Shockwave Flash 21.0 r0
,
May 11 2016
https://jsfiddle.net/zLog8vax/ reproduces the way this seems to be exerciesed here compared to similar, other, working pages. The animation of a property on an invisible element that causes it to become visible is not handled properly.
,
May 16 2016
Just to update the bug, Issue is still able to reproduce on Windows using chrome latest canary M52-52.0.2737.0.
,
May 16 2016
petermayo@: Could you please help in finding an appropriate owner for this Stable blocker. Please adjust the label if this is not blocking for M-51. Appreciate your help!
,
May 16 2016
M51 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on May 20 to make into the desktop Stable final build cut. Thank you!
,
May 17 2016
My repros for me on 50.0.2661.102 with my version, but not the original case. Looking through the bisect, this may have been changed by cl/1811423002 sunxd@: can you take a look and provide further insight?
,
May 18 2016
sunxd@: Please review this Stable blocker and update the labels if the fix won't be inline for the next stable rollout as per C#6.
,
May 18 2016
Sure, looking at it. Probably it has something to do with the CL that change layer subtree skipping logic.
,
May 18 2016
It turns out that we failed to update effect tree when updating transform tree, so the hidden_by_backface_visibility in effect tree is not up-to-date when performing animations. The fix will be pretty simple and fast.
,
May 19 2016
Reply to comment #10, can you please try to land change to trunk as soon as possible and request a merge to M51 once it is baked in canary (M51 merge needs to be in before 5:00 PM PST Friday or latest by 5:00 PM PST on Monday to make it to Desktop Stable candidate cut). Thank you.
,
May 19 2016
govind@: sure, CQ is trying the patch and hopefully the change can land soon.
,
May 19 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4 commit 59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4 Author: sunxd <sunxd@chromium.org> Date: Thu May 19 20:07:47 2016 cc: Update effect_tree backface visibility when transform is updated. We should update effect_tree as well in UpdatePropertyTrees when an animation cause a change in transform tree. Failing to update it may cause draw_property_utils incorrectly skip layers. This CL forces the update and added a related unit test. BUG= 610280 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1994213002 Cr-Commit-Position: refs/heads/master@{#394846} [modify] https://crrev.com/59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4/cc/trees/draw_property_utils.cc [modify] https://crrev.com/59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4/cc/trees/layer_tree_host_common_unittest.cc
,
May 19 2016
Thank you sunxd@. Please request a merge to M51 once cl is landed baked/verified in canary and safe to merge.
,
May 19 2016
@govind: sure, no problem, will keep an eye on it.
,
May 20 2016
Unable to repro this issue on Windows 7, MAC (10.11.4) & Ubuntu Trusty (14.04) for Google Chrome Canary Version - 52.0.2743.0 Screen-recording is attached. Looks like this issue is fixed.
,
May 20 2016
I believe the cl is baked in canary and the bug is gone. Request to merge to M51.
,
May 20 2016
Your change meets the bar and is auto-approved for M51 (branch: 2704)
,
May 20 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e784d1b8f8de4627f6075050ad52e7ca735512c commit 7e784d1b8f8de4627f6075050ad52e7ca735512c Author: Ali Juma <ajuma@chromium.org> Date: Fri May 20 20:04:12 2016 cc: Update effect_tree backface visibility when transform is updated. We should update effect_tree as well in UpdatePropertyTrees when an animation cause a change in transform tree. Failing to update it may cause draw_property_utils incorrectly skip layers. This CL forces the update and added a related unit test. BUG= 610280 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Review-Url: https://codereview.chromium.org/1994213002 Cr-Commit-Position: refs/heads/master@{#394846} (cherry picked from commit 59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4) Review URL: https://codereview.chromium.org/1995403002 . Cr-Commit-Position: refs/branch-heads/2704@{#623} Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251} [modify] https://crrev.com/7e784d1b8f8de4627f6075050ad52e7ca735512c/cc/trees/draw_property_utils.cc [modify] https://crrev.com/7e784d1b8f8de4627f6075050ad52e7ca735512c/cc/trees/layer_tree_host_common_unittest.cc
,
May 20 2016
,
May 25 2016
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 51.0.2704.63 as per steps in comment #0.Observed that when the form rotated it looked like a 3D element that is rotating as it does on Firefox. Please find attached screencast. Marking it as TE-Verified.
,
Mar 24 2017
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by ajha@chromium.org
, May 11 2016Components: Blink>CSS>3D
Labels: -Pri-2 -Type-Compat M-51 ReleaseBlock-Stable OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Status: Available (was: Unconfirmed)