New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610280 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

A transform: rotateY, backface-visibility hidden element don't appear on time when rotated

Reported by meytalm...@gmail.com, May 9 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.36 Safari/537.36

Example URL:
https://crazylister.com/

Steps to reproduce the problem:
1. Open the link that's attached on Chrome 51.0.2704.36 beta-m.
2. Click on "Log in here" in the form that appear on the right side of the page.
3. Click on "Forgot password?"

What is the expected behavior?
When the form rotates it should look like a 3D element that is rotating as it does on Firefox (for example version 46.0.1)

What went wrong?
The backface-visibility hidden element don't appear on time causing the 3D illusion to be absent.

Does it occur on multiple sites: N/A

Is it a problem with a plugin? No 

Did this work before? Yes On Chrome 50.0.2661.91

Does this work in other browsers? Yes 

Chrome version: 51.0.2704.36  Channel: beta
OS Version: 10.0
Flash Version: Shockwave Flash 21.0 r0
 

Comment 1 by ajha@chromium.org, May 11 2016

Cc: ajha@chromium.org
Components: Blink>CSS>3D
Labels: -Pri-2 -Type-Compat M-51 ReleaseBlock-Stable OS-Linux OS-Mac Pri-1 Type-Bug-Regression
Status: Available (was: Unconfirmed)
Able to reproduce this on the latest canary(52.0.2730.0) on Windows-7, Mac OS 10.11.4 and Linux Ubuntu 14.04.

This is a regression issue broken in M-51.

Last good build: 51.0.2696.0 
First bad build: 51.0.2697.0

Changelog:
==========
https://chromium.googlesource.com/chromium/src/+log/9a90e8abe1d64cd35f7fb53370b28007f27c6c59..607c325177ceca3f0c3834f26078912ec94ca007

Unable to find the exact suspect. Adding proper bug label for someone from the respective team to have a look at this Blocker issue.
https://jsfiddle.net/zLog8vax/ reproduces the way this seems to be exerciesed here compared to similar, other, working pages.

The animation of a property on an invisible element that causes it to become visible is not handled properly.
Just to update the bug, Issue is still able to reproduce on Windows using chrome latest canary M52-52.0.2737.0. 

Comment 4 by ajha@chromium.org, May 16 2016

Owner: petermayo@chromium.org
Status: Assigned (was: Available)
petermayo@: Could you please help in finding an appropriate owner for this Stable blocker. Please adjust the label if this is not blocking for M-51.

Appreciate your help!

Comment 5 Deleted

Comment 6 by gov...@chromium.org, May 16 2016

M51 Stable is launching very soon! Your bug is labelled as Stable ReleaseBlock, pls make sure to land the fix and get it merged ASAP. All changes MUST be merged into the release branch by 5pm on May 20 to make into the desktop Stable final build cut. Thank you!
Owner: sunxd@chromium.org
My repros for me on 50.0.2661.102 with my version, but not the original case.

Looking through the bisect, this may have been changed by cl/1811423002

sunxd@: can you take a look and provide further insight?

Comment 8 by ajha@chromium.org, May 18 2016

sunxd@: Please review this Stable blocker and update the labels if the fix won't be inline for the next stable rollout as per C#6.

Comment 9 by sunxd@chromium.org, May 18 2016

Cc: jaydasika@chromium.org ajuma@chromium.org
Sure, looking at it. Probably it has something to do with the CL that change layer subtree skipping logic.

Comment 10 by sunxd@chromium.org, May 18 2016

It turns out that we failed to update effect tree when updating transform tree, so the hidden_by_backface_visibility in effect tree is not up-to-date when performing animations. The fix will be pretty simple and fast.
Reply to comment #10, can you please try to land change to trunk as soon as possible and request a merge to M51 once it is baked in canary (M51 merge needs to be in before 5:00 PM PST Friday or latest by 5:00 PM PST on Monday to make it to Desktop Stable candidate cut). Thank you.

Comment 12 by sunxd@chromium.org, May 19 2016

govind@: sure, CQ is trying the patch and hopefully the change can land soon.
Project Member

Comment 13 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4

commit 59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4
Author: sunxd <sunxd@chromium.org>
Date: Thu May 19 20:07:47 2016

cc: Update effect_tree backface visibility when transform is updated.

We should update effect_tree as well in UpdatePropertyTrees when an
animation cause a change in transform tree. Failing to update it may
cause draw_property_utils incorrectly skip layers.

This CL forces the update and added a related unit test.

BUG= 610280 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1994213002
Cr-Commit-Position: refs/heads/master@{#394846}

[modify] https://crrev.com/59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4/cc/trees/layer_tree_host_common_unittest.cc

Thank you sunxd@. Please request a merge to M51 once cl is landed baked/verified in canary and safe to merge.

Comment 15 by sunxd@chromium.org, May 19 2016

@govind: sure, no problem, will keep an eye on it.
Cc: rnimmagadda@chromium.org
Unable to repro this issue on Windows 7, MAC (10.11.4) & Ubuntu Trusty (14.04) for Google Chrome Canary Version - 52.0.2743.0

Screen-recording is attached.

Looks like this issue is fixed.
610280.mov
5.6 MB Download

Comment 17 by sunxd@chromium.org, May 20 2016

Labels: Merge-Request-51
I believe the cl is baked in canary and the bug is gone. Request to merge to M51.

Comment 18 by tin...@google.com, May 20 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 19 by bugdroid1@chromium.org, May 20 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e784d1b8f8de4627f6075050ad52e7ca735512c

commit 7e784d1b8f8de4627f6075050ad52e7ca735512c
Author: Ali Juma <ajuma@chromium.org>
Date: Fri May 20 20:04:12 2016

cc: Update effect_tree backface visibility when transform is updated.

We should update effect_tree as well in UpdatePropertyTrees when an
animation cause a change in transform tree. Failing to update it may
cause draw_property_utils incorrectly skip layers.

This CL forces the update and added a related unit test.

BUG= 610280 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1994213002
Cr-Commit-Position: refs/heads/master@{#394846}
(cherry picked from commit 59dd7daef0b5f11d6f8dd6dd5141967ab0deb0b4)

Review URL: https://codereview.chromium.org/1995403002 .

Cr-Commit-Position: refs/branch-heads/2704@{#623}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/7e784d1b8f8de4627f6075050ad52e7ca735512c/cc/trees/draw_property_utils.cc
[modify] https://crrev.com/7e784d1b8f8de4627f6075050ad52e7ca735512c/cc/trees/layer_tree_host_common_unittest.cc

Comment 20 by sunxd@chromium.org, May 20 2016

Status: Fixed (was: Assigned)
Labels: TE-Verified-M51 TE-Verified-51.0.2704.63
Tested the issue on Windows 7, Mac 10.11.5, Ubuntu 14.04 using 51.0.2704.63 as per steps in comment #0.Observed that when the form rotated it looked like a 3D element that is rotating as it does on Firefox.
Please find attached screencast.

Marking it as TE-Verified.
610280.mp4
711 KB Download

Comment 22 by suzyh@chromium.org, Mar 24 2017

Components: -Blink>CSS>CSS3D Blink>Compositing>Transform3D

Sign in to add a comment