Account chooser should be maximum 3.5 rows tall |
||
Issue descriptionThe account chooser dialog displays maximum 3 credentials. In case of more credentials the height should be 3.5 rows so the user sees that he can scroll.
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa5adc3ce6729f5740936d6b2a2d8fc119c680ac commit aa5adc3ce6729f5740936d6b2a2d8fc119c680ac Author: vasilii <vasilii@chromium.org> Date: Thu May 12 11:33:37 2016 Change the maximum account chooser height to 3.5 rows on Mac. BUG= 610277 Review-Url: https://codereview.chromium.org/1969383002 Cr-Commit-Position: refs/heads/master@{#393227} [modify] https://crrev.com/aa5adc3ce6729f5740936d6b2a2d8fc119c680ac/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/51e9a92e2df9a15e1788fb55c0b85b4012026095 commit 51e9a92e2df9a15e1788fb55c0b85b4012026095 Author: vasilii <vasilii@chromium.org> Date: Thu May 12 13:45:31 2016 Change the maximum account chooser height to 3.5 rows on Views. BUG= 610277 Review-Url: https://codereview.chromium.org/1972163002 Cr-Commit-Position: refs/heads/master@{#393239} [modify] https://crrev.com/51e9a92e2df9a15e1788fb55c0b85b4012026095/chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc
,
May 12 2016
,
May 13 2016
Thanks for the fix! If the CL is not too complex, I'd actually try and request a merge. I completely agree that it's not the highest priority, but shipping an as polished as possible product is good as well. :) How complex/long is the CL?
,
May 13 2016
There are two simple CLs. I didn't request a merge for two reasons: - it's an optional request and not a bug fix. - The deadline for beta is Monday and it's a holiday. Today I'm a sheriff. |
||
►
Sign in to add a comment |
||
Comment 1 by vasi...@chromium.org
, May 12 201623.8 KB
23.8 KB View Download