Additional space on bottom of NTP in landscape |
||||||||||||
Issue descriptionSteps to reproduce: 1) Ensure NTP snippets are turned off 2) Open NTP 3) Turn phone (Nexus 5) to landscape 4) Scroll down Expected: All above-the-fold tiles should fit on the NTP together with the bottom toolbar (see first attached screenshot). Actual: There is additional space below the tiles, so they can be scrolled further down (see following two screenshots). This regressed with https://codereview.chromium.org/1947263003.
,
May 11 2016
<Snatch>
,
May 11 2016
,
May 11 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/436aed1d712016d6653e913f634ced168eddd8d5 commit 436aed1d712016d6653e913f634ced168eddd8d5 Author: mcwilliams <mcwilliams@chromium.org> Date: Wed May 11 16:41:46 2016 Set the parent viewport on the NewTabPageScroll Introduced a bug on new tab page scroll where on measure is slightly different when recycler view is enabled. Reverting this change and cleaning it up slightly BUG= 610262 Review-Url: https://codereview.chromium.org/1965363002 Cr-Commit-Position: refs/heads/master@{#392953} [modify] https://crrev.com/436aed1d712016d6653e913f634ced168eddd8d5/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageScrollView.java
,
Jul 1 2016
,
Jul 1 2016
,
Jul 1 2016
|
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by nepper@chromium.org
, May 10 2016Labels: -Pri-2 -zine-mr-untriaged zine-mr-mile-MVP M-52 Pri-1
Owner: mcwilliams@chromium.org
Status: Assigned (was: Available)