New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 610236 link

Starred by 2 users
Status: Fixed
Owner:
och...@chromium.org
Closed: May 2016
Cc:
mbarbe...@chromium.org
dsinclair@chromium.org
█ aizatsky@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Libfuzzer builds are broken due to redefined macro 'MEMORY_TOOL_REPLACES_ALLOCATOR'

Project Member Reported by mmoroz@chromium.org, May 9 2016 
Looks like builds are broken for ~5 days already.

https://build.chromium.org/p/chromium.fyi/buildslaves/slave43-c1

ASan build log: https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux%20ASan/builds/1339/steps/compile/logs/stdio

MSan build log:
https://build.chromium.org/p/chromium.fyi/builders/Libfuzzer%20Upload%20Linux%20MSan/builds/1255/steps/steps/logs/stdio


../../third_party/pdfium/xfa/fgas/crt/fgas_memory.cpp:9:9: error: 'MEMORY_TOOL_REPLACES_ALLOCATOR' macro redefined [-Werror,-Wmacro-redefined]
#define MEMORY_TOOL_REPLACES_ALLOCATOR  // Temporary, for CF testing.
        ^
<command line>:22:9: note: previous definition is here
#define MEMORY_TOOL_REPLACES_ALLOCATOR 1
        ^
1 error generated.

Comment 1 by mmoroz@chromium.org, May 9 2016

Cc: dsinclair@chromium.org
Looks like it has been fixed already, but need to roll out new version of pdfium:
https://pdfium.googlesource.com/pdfium/+/1f00dbf0203bdd6b4100457301fef1216546e2f7

I don't mind to do it, but IIUC firstly need to create a new branch like 'chromium/2730'. Is it just 'git push origin chromium/2730' or anything else?

Since dsinclair@ is OOO, any help would be appreciated :)

Comment 2 by och...@chromium.org, May 9 2016

Cc: -och...@chromium.org
Owner: och...@chromium.org
Status: Assigned (was: Untriaged)
I can do the roll. You shouldn't need to create a new branch, since it's just for chromium master.

Comment 3 by mmoroz@chromium.org, May 9 2016 

Thanks Oliver!
Got it. Next time I will be brave enough to do it myself :)

Probably new range is: https://pdfium.googlesource.com/pdfium.git/+log/696fc8b..e00f75c
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b9ff5b70be2313da55f5d5cc450732b74d68dba

commit 0b9ff5b70be2313da55f5d5cc450732b74d68dba
Author: ochang <ochang@chromium.org>
Date: Mon May 09 17:23:13 2016

Roll PDFium 696fc8b..e00f75c

https://pdfium.googlesource.com/pdfium.git/+log/696fc8b..e00f75c

BUG= 596947 , 610236 

TBR=dsinclair@chromium.org
TEST=bots

Review-Url: https://codereview.chromium.org/1962743002
Cr-Commit-Position: refs/heads/master@{#392349}

[modify] https://crrev.com/0b9ff5b70be2313da55f5d5cc450732b74d68dba/DEPS

Comment 5 by och...@chromium.org, May 9 2016

Status: Fixed (was: Assigned)
builds are green again.
►

Sign in to add a comment