Issue metadata
Sign in to add a comment
|
Regression: Cursor is seen missing in app launcher after clicking on All Apps |
||||||||||||||||||||||
Issue descriptionVersion: 52.0.2727.0/8296.0.0 (Official Build) dev-channel peach_pit daisy,quawks,blaze OS: chrome os What steps will reproduce the problem? (1) Sign in to user/Browse as guest >> Click on launcher button on uber tray or hit search icon from keyboard so that app launcher is seen (2) Now click on "All Apps" and observe for cursor in search field Expected: Default focus should be seen in search field after clicking "All Apps" Actual: Instead default cursor in search field is missing and unable to type unless u focus search field. This is a regression issue as it is working fine in 52.0.2724.0/8286.0.0 . @karandeepb: Please confirm the issue and help in re-assigning if it is not related to your change.
,
May 10 2016
Have confirmed my CL is the cause. Will issue a fix soon.
,
May 11 2016
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b commit 8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b Author: karandeepb <karandeepb@chromium.org> Date: Mon May 16 01:14:44 2016 Views: Change View::RequestFocus to respect keyboard accessibility. This CL fixes some regressions introduced in http://crrev.com/1894383002/. These regression are caused due to the change in View::RequestFocus() from IsFocusable() to IsAccessibilityFocusable(). On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus on the button, if it has request_focus_on_press_ set to true. It turns out that most button subclasses, do not explicitly set request_focus_on_press_ to false, which has a default value of true. These custom buttons which are accessibility focusable, can now gain focus on a mouse press, hence the bug. This CL changes View::RequestFocus to use IsFocusable when keyboard accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701 , 610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since View::RequestFocus now respects keyboard accessibility, bug 611280 is also fixed. BUG= 609701 , 610186 , 610235 , 610740 , 610802 , 610664 , 564912 , 611280 Review-Url: https://codereview.chromium.org/1973073003 Cr-Commit-Position: refs/heads/master@{#393781} [modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/chrome/browser/ui/views/tabs/tab_unittest.cc [modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/focus/focus_manager.cc [modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/focus/focus_manager_unittest.cc [modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/view.cc
,
May 16 2016
,
May 20 2016
ChromeOS 52.0.2739.0/8350.0.0 samus |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by kavvaru@chromium.org
, May 9 2016