New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610224 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

Crash in v8::Context::Enter

Project Member Reported by ClusterFuzz, May 9 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5975727870050304

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  v8::Context::Enter
  extensions::AppBindings::OnAppInstallStateResponse
  bool IPC::MessageT<ExtensionMsg_GetAppInstallStateResponse_Meta, std::__1::tuple
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=172434:172624

Minimized Testcase (19.79 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96Rr5fKZGJUqn3XjnYt5LHia6_W9nJ83XRvAP8UKlM9ZFdy484acUSqNxrcvh8quZ9pz9N369koHGPVZiZIE5QWtFlBBmO7x5MYIT2Gn4vVz7ueuUZ9fJISsCCg4ayXhz_H94EFRNOMDhQ0fueTuUbWFmYQfOnH0k-xvE4iXg2fhCMcEQc

Filer: rnimmagadda

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: mdempsky@chromium.org
Components: Blink>JavaScript Tools>Test>FindIt>CorrectResult
Labels: findit-for-crash Te-Logged M-51
Owner: marja@chromium.org
Status: Assigned (was: Available)
Author: marja@chromium.org
Project: chromium
Changelist: https://chromium.googlesource.com/chromium/src//+/9a5984409f05752318c259fc1c69f0dba0107c07
Time: Tue Jun 04 16:39:12 2013
The CL last changed line 172 of file app_bindings.cc, which is stack frame 5.

@marja: Could you please look into this issue.

@mdempsky: This issue was earlier closed, hence cc'ing you - 602222

Thank you.

Comment 2 by marja@chromium.org, May 9 2016

Owner: jochen@chromium.org
I'm ooo, reassigning.
Cc: jochen@chromium.org
Components: -Tools>Test>FindIt>CorrectResult Tools>Test>FindIt>WrongResult
Owner: rdevlin....@chromium.org
I don't see anything that would guard against the native handler being invalidated
Project Member

Comment 4 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c1872b891a46dda7bd25463374cbd305d343ecfc

commit c1872b891a46dda7bd25463374cbd305d343ecfc
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Mon May 09 18:22:45 2016

[Extensions] Check is_valid() in app bindings

The AppBindings object can potentially receive an IPC message after it's
been invalided. Check before entering the v8 context.

BUG= 610224 

Review-Url: https://codereview.chromium.org/1960173002
Cr-Commit-Position: refs/heads/master@{#392367}

[modify] https://crrev.com/c1872b891a46dda7bd25463374cbd305d343ecfc/chrome/renderer/extensions/app_bindings.cc

Project Member

Comment 5 by ClusterFuzz, May 10 2016

ClusterFuzz has detected this issue as fixed in range 392310:392347.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5975727870050304

Fuzzer: lcamtuf_cross_fuzz
Job Type: linux_asan_chrome_mp
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x000000000000
Crash State:
  v8::Context::Enter
  extensions::AppBindings::OnAppInstallStateResponse
  bool IPC::MessageT<ExtensionMsg_GetAppInstallStateResponse_Meta, std::__1::tuple
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=172434:172624
Fixed: https://cluster-fuzz.appspot.com/revisions?job=linux_asan_chrome_mp&range=392310:392347

Minimized Testcase (19.79 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96Rr5fKZGJUqn3XjnYt5LHia6_W9nJ83XRvAP8UKlM9ZFdy484acUSqNxrcvh8quZ9pz9N369koHGPVZiZIE5QWtFlBBmO7x5MYIT2Gn4vVz7ueuUZ9fJISsCCg4ayXhz_H94EFRNOMDhQ0fueTuUbWFmYQfOnH0k-xvE4iXg2fhCMcEQc

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Labels: Merge-Request-51
Status: Fixed (was: Assigned)

Comment 7 by tin...@google.com, May 10 2016

Labels: -Merge-Request-51 Merge-Approved-51 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M51 (branch: 2704)
Project Member

Comment 8 by bugdroid1@chromium.org, May 10 2016

Labels: -merge-approved-51 merge-merged-2704
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2264cb9287ce50bfea812e80325debcb1474e4d2

commit 2264cb9287ce50bfea812e80325debcb1474e4d2
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Tue May 10 23:43:57 2016

[Extensions] Check is_valid() in app bindings

The AppBindings object can potentially receive an IPC message after it's
been invalided. Check before entering the v8 context.

BUG= 610224 

Review-Url: https://codereview.chromium.org/1960173002
Cr-Commit-Position: refs/heads/master@{#392367}
(cherry picked from commit c1872b891a46dda7bd25463374cbd305d343ecfc)

Review URL: https://codereview.chromium.org/1970593002 .

Cr-Commit-Position: refs/branch-heads/2704@{#487}
Cr-Branched-From: 6e53600def8f60d8c632fadc70d7c1939ccea347-refs/heads/master@{#386251}

[modify] https://crrev.com/2264cb9287ce50bfea812e80325debcb1474e4d2/chrome/renderer/extensions/app_bindings.cc

Components: -Tools>Test>FindIt>WrongResult
Labels: Test-Predator-Wrong
Project Member

Comment 10 by sheriffbot@chromium.org, Nov 22 2016

Labels: -Restrict-View-EditIssue
Removing EditIssue view restrictions from ClusterFuzz filed bugs. If you believe that this issue should still be restricted, please reapply the label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment