New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 610203 link

Starred by 2 users
Status: Verified
Owner:
pmonette@chromium.org
Closed: May 2016
Cc:
nyerramilli@chromium.org
█ ashej...@chromium.org
mac-bugs-priority@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to make google chrome browser as default since pop up doesn’t appears.

Reported by dmascare...@etouch.net, May 9 2016 
Chrome Version:52.0.2728.0 (Official Build)Revision 91351e6f2237ce96a9f1ea9b67e01651311029a7-refs/heads/master@{#392266} (64-bit)
OS: Mac Pro(10.10.5) (10.11.4), Mac Retina (10.11.4)

Pre-condition: Firefox should be default browser.

What steps will reproduce the problem?
1. Launch chrome and navigate to chrome://settings/
2. Click on ‘Make Google Chrome the default browser’ button within Default browser and observe.

Actual: Unable to make google chrome browser as default since pop up doesn’t appears.
Expected: Pop up should appears and able to make Google browser as default.

This is regression issue,broken in ‘M 52’ and will soon update the bisect info.

Good build:52.0.2705.0
Bad build:52.0.2707.0

Note: Issue is not reproducible on Windows and Linux OS.
Actual_default.mov
1.9 MB Download
Exp_default.mov
560 KB Download

Comment 1 by dmascare...@etouch.net, May 9 2016

Cc: grt@chromium.org
Labels: hasbisect
Owner: pmonette@chromium.org
Status: Assigned (was: Unconfirmed)
Providing ChangLog:
(Unable to narrow down the range since can’t make chromium build as default browser via tool)

https://chromium.googlesource.com/chromium/src/+log/52.0.2705.0..52.0.2707.0?pretty=fuller&n=10000

Suspecting: r386487 ?

Kindly help to re-assign if your change is not the cause for this issue.

Comment 2 by ashej...@chromium.org, May 9 2016

Labels: ReleaseBlock-Stable
Marking the above issue as RB-Stable as this is a recent regression.

Thank you!

Comment 3 by grt@chromium.org, May 12 2016

Cc: -grt@chromium.org
Owner: pinkerton@chromium.org
Removing Windows folks and adding a Mac person.

Comment 4 by pmonette@chromium.org, May 12 2016

Owner: pmonette@chromium.org
This is my fault. The fix is on the way.
Project Member

Comment 5 by bugdroid1@chromium.org, May 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee80b2e21a1d7b3dea8d85584a40123f64ed76f7

commit ee80b2e21a1d7b3dea8d85584a40123f64ed76f7
Author: pmonette <pmonette@chromium.org>
Date: Thu May 12 22:55:16 2016

Now able to set Chrome as the default browser on Mac.

Fixed a bug introduced by the refactoring done in crrev.com/386487

BUG= 610203 

Review-Url: https://codereview.chromium.org/1978643002
Cr-Commit-Position: refs/heads/master@{#393384}

[modify] https://crrev.com/ee80b2e21a1d7b3dea8d85584a40123f64ed76f7/chrome/browser/shell_integration_mac.mm

Comment 6 by pmonette@chromium.org, May 12 2016 

The fix was committed.

To test: 
1.On Mac set the default browser to something else (like Firefox).
2.Open Chrome and go to chrome://settings.
3.Click "Make Google Chrome the default browser".
4.A popup window should appear that allows you to use Chrome as the default web browser. If nothing happens, the fix is not working.

Comment 7 by ashej...@chromium.org, May 16 2016

Labels: TE-Verified-52.0.2738.0 TE-Verified-M52
Retested the above issue on Mac 10.11.4 with chrome version '52.0.2738.0' and Pop-up appear when click on "Make Google Chrome the default browser".
Hence marking the same as TE-Verified-52.0.2738.0.

Comment 8 by durga.behera@chromium.org, May 19 2016 

pmonette@ : Could you please update the Issue status to Fixed/Verified if there is no work to be done on this further.

Comment 9 by pmonette@chromium.org, May 19 2016

Status: Verified (was: Assigned)
►

Sign in to add a comment