Issue metadata
Sign in to add a comment
|
Regression: Weird behaviour is seen on using enter for zoom options in wrench menu. |
||||||||||||||||||||||
Issue descriptionVersion: 52.0.2729.0 dev OS: Ubuntu 12.04,14.04,windows What steps will reproduce the problem? (1) Launch chrome and open wrench menu >> Using arrow keys navigate till you reach Zoom "-" or "+" sign (2) Now hit Enter continuously and observe Expected: On reaching Zoom "25%" or "500%" nothing should happen even on pressing enter Actual: Instead now on hitting enter after "25%" or "500%" focus shifts to wrench menu button and again hitting enters new tab opens This is a regression issue broken in M52. Will provide bisect info soon.
,
May 9 2016
Good Build: 52.0.2725.0 dev Bad Build: 52.0.2726.0 dev
,
May 9 2016
Able to reproduce the issue on windows 7 using chrome version 52.0.2729.0.
,
May 9 2016
Yeah this is related to my CL. Will issue a fix soon.
,
May 9 2016
Adding the stable blocker as this is recent regression,Please feel free to remove if not required.
,
May 11 2016
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b commit 8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b Author: karandeepb <karandeepb@chromium.org> Date: Mon May 16 01:14:44 2016 Views: Change View::RequestFocus to respect keyboard accessibility. This CL fixes some regressions introduced in http://crrev.com/1894383002/. These regression are caused due to the change in View::RequestFocus() from IsFocusable() to IsAccessibilityFocusable(). On a mouse click on a CustomButton, CustomButton::MousePressed() requests focus on the button, if it has request_focus_on_press_ set to true. It turns out that most button subclasses, do not explicitly set request_focus_on_press_ to false, which has a default value of true. These custom buttons which are accessibility focusable, can now gain focus on a mouse press, hence the bug. This CL changes View::RequestFocus to use IsFocusable when keyboard accessibility is off (i.e on Non-Mac platforms), hence fixing bugs 609701 , 610186, 610235, 610740, 610802, 610664. This is how View::RequestFocus behaved before crrev.com/1894383002 on Non-Mac platforms. Also, on Mac, since View::RequestFocus now respects keyboard accessibility, bug 611280 is also fixed. BUG= 609701 , 610186 , 610235 , 610740 , 610802 , 610664 , 564912 , 611280 Review-Url: https://codereview.chromium.org/1973073003 Cr-Commit-Position: refs/heads/master@{#393781} [modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/chrome/browser/ui/views/tabs/tab_unittest.cc [modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/focus/focus_manager.cc [modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/focus/focus_manager_unittest.cc [modify] https://crrev.com/8c6b2ee186d786623f0e4cb6d05c08c934c0ff9b/ui/views/view.cc
,
May 16 2016
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sc00335...@techmahindra.com
, May 9 2016Owner: karandeepb@chromium.org
Status: Assigned (was: Unconfirmed)