Area above the tabs in the tabstrip is 2pt too tall |
|||
Issue descriptionVersion: 52.0.2726.0 canary The area is 9pt tall when according to spec it should be 7pt.
,
May 16 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/23202f9294a90af7fd7889856a2b546f23a845bc commit 23202f9294a90af7fd7889856a2b546f23a845bc Author: spqchan <spqchan@chromium.org> Date: Mon May 16 21:37:40 2016 [Material][Mac] Reduced the area above tabs by 2 pts BUG= 610185 Review-Url: https://codereview.chromium.org/1971343004 Cr-Commit-Position: refs/heads/master@{#393940} [modify] https://crrev.com/23202f9294a90af7fd7889856a2b546f23a845bc/chrome/browser/ui/cocoa/browser_window_layout.h [modify] https://crrev.com/23202f9294a90af7fd7889856a2b546f23a845bc/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/23202f9294a90af7fd7889856a2b546f23a845bc/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/23202f9294a90af7fd7889856a2b546f23a845bc/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
May 16 2016
,
May 17 2016
Shaving the 2pts from the tabstrip now brings it in line with the MD spec, but I think we need to revert this change. If your tabstrip is filled with tabs, there no longer any space above the tabs to drag the window. When I try I get the window resize cursor. I have to grab the window near the stoplight or account login buttons in order to move it.
,
May 17 2016
That's a good point. I'm able to move the window, but I have to carefully select the space above the tabs in order to do it.
,
May 17 2016
spqchan@ - please go ahead and revert this change (so that we can get it into tomorrow's Canary). Thank you.
,
May 18 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73cb7cdf4ea2a374c5a2f22fd628353391e24438 commit 73cb7cdf4ea2a374c5a2f22fd628353391e24438 Author: spqchan <spqchan@chromium.org> Date: Wed May 18 17:22:46 2016 Revert "[Material][Mac] Reduced the area above tabs by 2 pts" This reverts commit 23202f9294a90af7fd7889856a2b546f23a845bc. BUG= 610185 Review-Url: https://codereview.chromium.org/1989633002 Cr-Commit-Position: refs/heads/master@{#394455} [modify] https://crrev.com/73cb7cdf4ea2a374c5a2f22fd628353391e24438/chrome/browser/ui/cocoa/browser_window_layout.h [modify] https://crrev.com/73cb7cdf4ea2a374c5a2f22fd628353391e24438/chrome/browser/ui/cocoa/browser_window_layout.mm [modify] https://crrev.com/73cb7cdf4ea2a374c5a2f22fd628353391e24438/chrome/browser/ui/cocoa/browser_window_layout_unittest.mm [modify] https://crrev.com/73cb7cdf4ea2a374c5a2f22fd628353391e24438/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm |
|||
►
Sign in to add a comment |
|||
Comment 1 by shrike@chromium.org
, May 13 2016Owner: spqc...@chromium.org