Excessive powerd logging of hover start/stop events |
|||||
Issue descriptionThe power manager logs from samus devices are super-noisy due to reports of hovering starting and stopping, e.g. [0508/163215:INFO:daemon.cc(577)] Hovering off [0508/163216:INFO:daemon.cc(577)] Hovering on [0508/163216:INFO:daemon.cc(577)] Hovering off [0508/163216:INFO:daemon.cc(577)] Hovering on [0508/163217:INFO:daemon.cc(577)] Hovering off [0508/163217:INFO:daemon.cc(577)] Hovering on [0508/163219:INFO:daemon.cc(1402)] Saw user activity [0508/163220:INFO:daemon.cc(577)] Hovering off [0508/163220:INFO:daemon.cc(577)] Hovering on [0508/163220:INFO:daemon.cc(577)] Hovering off [0508/163220:INFO:daemon.cc(577)] Hovering on [0508/163221:INFO:daemon.cc(577)] Hovering off [0508/163221:INFO:daemon.cc(577)] Hovering on [0508/163222:INFO:daemon.cc(577)] Hovering off [0508/163222:INFO:daemon.cc(577)] Hovering on I should move this behind VLOG and add less-noisy LOG(INFO)s for investigating user reports. For example, we could log when hovering first starts, but start a timer after it stops and only log after it's remained off for e.g. ten seconds.
,
Jun 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/7d3d1caa382e8e170657f4e165648723413696b2 commit 7d3d1caa382e8e170657f4e165648723413696b2 Author: Daniel Erat <derat@chromium.org> Date: Mon May 09 20:32:06 2016 power: Log hover state changes less frequently. Make KeyboardBacklightController wait 20 seconds after hovering stops before logging the event. This prevents frequent starts and stops from being logged and making the log files difficult to read. BUG= chromium:610182 TEST=manual Change-Id: Ia9c1b1a63b41bb5d363f7080b1708a14e011ded3 Reviewed-on: https://chromium-review.googlesource.com/351560 Commit-Ready: Dan Erat <derat@chromium.org> Tested-by: Dan Erat <derat@chromium.org> Reviewed-by: Eric Caruso <ejcaruso@chromium.org> [modify] https://crrev.com/7d3d1caa382e8e170657f4e165648723413696b2/power_manager/powerd/daemon.cc [modify] https://crrev.com/7d3d1caa382e8e170657f4e165648723413696b2/power_manager/powerd/policy/keyboard_backlight_controller.cc [modify] https://crrev.com/7d3d1caa382e8e170657f4e165648723413696b2/power_manager/powerd/policy/keyboard_backlight_controller.h
,
Jun 17 2016
,
Jul 1 2016
,
Aug 29 2016
,
Sep 2 2016
verified in 8530.77.0. 53.0.2785.87 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by derat@chromium.org
, May 17 2016