New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610181 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
not on Chrome anymore
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Page appears blank after clicking on rotate option of pdf file.

Reported by vku...@etouch.net, May 9 2016

Issue description

Chrome Version:52.0.2728.0 (Official Build)Revision 91351e6f2237ce96a9f1ea9b67e01651311029a7-refs/heads/master@{#392266} (64-bit)
OS:Mac (10.10.5)(10.11.4)

What steps will reproduce the problem?
1.Launch chrome and navigate to embedded pdf for e.g https://msu.edu/~urban/sme865/resources/embedded_pdf.html
2.After loading the page click on 'rotate' pdf icon and observe the page.

Actual: Page appears blank after clicking on rotate option.

Expected: Page should not appear blank after clicking on rotate option.

This is a regression issue broken in 'M52' and will soon update other info.
 

Comment 1 by vku...@etouch.net, May 9 2016

Labels: hasbisect
Owner: jbau...@chromium.org
Status: Assigned (was: Unconfirmed)
Correction:
In step 1: Freshly launch chrome browser to reproduce the issue.

Manual regression range:
Good Build: 52.0.2725.0
Bad Build:  52.0.2726.0

Narrow Bisect:
https://chromium.googlesource.com/chromium/src/+log/931c0e91a7501df49fb488d978e64e1632cef37a..575a9b96a2b2776a6a4ae81f2e20c2bf3e975250?pretty=fuller&n=10

Suspecting: r391733 

Note: Issue not seen on Win & Linux OS.
ActualPdf.png
279 KB View Download
Actual_Pdf.mov
1.1 MB Download
Expected_Pdf.mov
1.0 MB Download

Comment 2 by vku...@etouch.net, May 9 2016

Note:
Similarly issue is seen on gmail.com and traces of previously open page appears on dev tools window.

Please refer attached screencast.
Actual_gmail.mov
3.4 MB Download
Actual_Traces.mov
2.6 MB Download
Labels: ReleaseBlock-Beta
Marking the above issue as RB-BETA as this is a recent regression and this affect dev tool.

Feel free to lower if someone feels otherwise.

Thank you!
Components: Blink>Paint
Labels: -ReleaseBlock-Beta ReleaseBlock-Dev
Update: Marking the above issue as Dev blocker as this is seen on variety of sites where there are embedded videos on facebook and other sites, blank screen is observed or huge flickering is observed on the same.  This is affecting Google services like Gmail, when clicked on name icon in gmail page gets displayed with white screen.

I have attach the video for the same.  Feel free to lower if someone feels otherwise.

Thank you!
Rendering not proper for embedded video.mp4
8.0 MB Download
Cc: ligim...@chromium.org
John, could you please get the CL reverted if its the real culprit.
Labels: -ReleaseBlock-Dev ReleaseBlock-Beta
Marking as 'ReleaseBlock-Beta' as this is impacting Mac OS X only.
Project Member

Comment 7 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fef422a0e8492b766d0713d9a6f5e3298c563081

commit fef422a0e8492b766d0713d9a6f5e3298c563081
Author: jbauman <jbauman@chromium.org>
Date: Mon May 09 22:17:45 2016

Revert of Correctly handle damage involving filters in SurfaceAggregator (patchset #6 id:100001 of https://codereview.chromium.org/1927413002/ )

Reason for revert:
Seems to cause rendering issues on mac.

BUG= 610181 

Original issue's description:
> Correctly handle damage involving filters in SurfaceAggregator
>
> There are two main issues with the handling of damage of contents
> affected by RenderPassDrawQuad filters:
> 1) Damage of a small part of a source Surface can affect a large part
> of the destination and
> 2) To draw damage on the destination, an unexpectedly large portion
> of the source must be used.
>
> To deal with these, the SurfaceAggregator must keep track of all output
> render passes affected by filters. Any Surface in an affected RenderPass
> will cause its parent Surface to be completely damaged (handling #1
> above).
>
> To handle #2, affected RenderPasses will have their damage rects set to
> contain the entire output_rect. Then DirectRenderer can use that damage
> rect to determine what to draw.
>
> CopyRequests can also cause areas outside the damage rect to be read, so
> any RenderPass inside a CopyRequest (directly or indirectly) will have
> its damage rect set to the output rect.
>
> This system is very pessimistic about what should be drawn, but in
> general it shouldn't affect that many cases and should always be
> correct.
>
> BUG= 602941 
> CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
>
> Committed: https://crrev.com/575a9b96a2b2776a6a4ae81f2e20c2bf3e975250
> Cr-Commit-Position: refs/heads/master@{#391733}

TBR=piman@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 602941 

Review-Url: https://codereview.chromium.org/1963693003
Cr-Commit-Position: refs/heads/master@{#392445}

[modify] https://crrev.com/fef422a0e8492b766d0713d9a6f5e3298c563081/cc/output/direct_renderer.cc
[modify] https://crrev.com/fef422a0e8492b766d0713d9a6f5e3298c563081/cc/surfaces/surface_aggregator.cc
[modify] https://crrev.com/fef422a0e8492b766d0713d9a6f5e3298c563081/cc/surfaces/surface_aggregator.h
[modify] https://crrev.com/fef422a0e8492b766d0713d9a6f5e3298c563081/cc/surfaces/surface_aggregator_unittest.cc
[modify] https://crrev.com/fef422a0e8492b766d0713d9a6f5e3298c563081/cc/trees/layer_tree_host_impl.cc

Thanks for the revert, could you please revert the patch in 2729 branch.
Status: Fixed (was: Assigned)

Sign in to add a comment