New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610180 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
NOT IN USE
Closed: May 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Layout Test fast/css/empty-pseudo-class.html is failing

Project Member Reported by bugsnash@chromium.org, May 9 2016

Issue description

The following layout test is failing on Linux

fast/css/empty-pseudo-class.html

 
Not failing on flakiness dashboard and not in test expectations?

Comment 2 Deleted

Failing on ToT
Also this: fast/css/only-of-type-pseudo-class.html

Comment 5 by ajha@chromium.org, May 11 2016

Cc: ajha@chromium.org
Labels: Needs-Feedback
We(TE's) are unable to access these html test URLs.

bugsnash@: Could you please attach the test file so that we can provide the bisect result manually.
empty-pseudo-class.html
3.1 KB View Download
only-of-type-pseudo-class.html
3.3 KB View Download

Comment 7 by ajha@chromium.org, May 13 2016

The above tests doesn't fail on Linux Ubuntu 14.04 on chrome version: 52.0.2735.0. Attached is the screen-shot of the same.

bugsnash@: Could you please re-check this on the latest and confirm if this still fails.
610180.png
236 KB View Download
Have checked again at ToT and both tests are flaky on my machine. That doesn't seem to be the case on other machines though...

Comment 9 by ajha@chromium.org, May 16 2016

Labels: -Needs-Feedback Te-NeedsFurtherTriage
This looks to system specific and would be difficult to bisect this from TE's end.

Could someone from the respective team have a look and help in investigating this further.
Labels: Test-Layout
Components: -Blink>LayoutTests
Deprecating component:Blink>LayoutTests, to use label Test=Layout instead.

Comment 12 by r...@opera.com, May 23 2016

Labels: -Needs-Bisect -Te-NeedsFurtherTriage
Owner: r...@opera.com
Status: Assigned (was: Untriaged)
I can reproduce the flakiness with a Debug build in Linux. It's caused by  issue 613957 . We can rewrite this as a js test instead of dumping the layout tree.

Cc: hua...@chromium.org jdonnelly@chromium.org engedy@chromium.org
 Issue 607206  has been merged into this issue.
Project Member

Comment 15 by bugdroid1@chromium.org, May 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/00bc83a8ed9ee64cd4b478cf760fa58809b95984

commit 00bc83a8ed9ee64cd4b478cf760fa58809b95984
Author: rune <rune@opera.com>
Date: Tue May 24 13:02:51 2016

Rewrote :empty tests to avoid list-item bug.

Run :empty tests as js-tests instead of layout tree dumps. The issue
causing the original test to be flaky is reported as  crbug.com/613957 .

R=bugsnash@chromium.org
BUG= 610180 

Review-Url: https://codereview.chromium.org/2006633002
Cr-Commit-Position: refs/heads/master@{#395582}

[add] https://crrev.com/00bc83a8ed9ee64cd4b478cf760fa58809b95984/third_party/WebKit/LayoutTests/fast/css/empty-pseudo-class-expected.txt
[modify] https://crrev.com/00bc83a8ed9ee64cd4b478cf760fa58809b95984/third_party/WebKit/LayoutTests/fast/css/empty-pseudo-class.html
[delete] https://crrev.com/2580b94791dcc2c527f4541fe7174df7dd0af224/third_party/WebKit/LayoutTests/platform/linux/fast/css/empty-pseudo-class-expected.png
[delete] https://crrev.com/2580b94791dcc2c527f4541fe7174df7dd0af224/third_party/WebKit/LayoutTests/platform/linux/fast/css/empty-pseudo-class-expected.txt
[delete] https://crrev.com/2580b94791dcc2c527f4541fe7174df7dd0af224/third_party/WebKit/LayoutTests/platform/mac-mac10.10/fast/css/empty-pseudo-class-expected.png
[delete] https://crrev.com/2580b94791dcc2c527f4541fe7174df7dd0af224/third_party/WebKit/LayoutTests/platform/mac-mac10.9/fast/css/empty-pseudo-class-expected.png
[delete] https://crrev.com/2580b94791dcc2c527f4541fe7174df7dd0af224/third_party/WebKit/LayoutTests/platform/mac/fast/css/empty-pseudo-class-expected.png
[delete] https://crrev.com/2580b94791dcc2c527f4541fe7174df7dd0af224/third_party/WebKit/LayoutTests/platform/mac/fast/css/empty-pseudo-class-expected.txt
[delete] https://crrev.com/2580b94791dcc2c527f4541fe7174df7dd0af224/third_party/WebKit/LayoutTests/platform/win/fast/css/empty-pseudo-class-expected.png
[delete] https://crrev.com/2580b94791dcc2c527f4541fe7174df7dd0af224/third_party/WebKit/LayoutTests/platform/win/fast/css/empty-pseudo-class-expected.txt

Comment 16 by r...@opera.com, May 24 2016

Status: Fixed (was: Assigned)

Sign in to add a comment