New issue
Advanced search Search tips

Issue 610176 link

Starred by 6 users
Status: Assigned
Owner:
haraken@chromium.org
Cc:
dcheng@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Clean up lifecycle observers

Project Member Reported by haraken@chromium.org, May 9 2016 
Blink has a number of lifecycle observers. Some of the observers do similar things. Some of the observers do unexpected things (than things you expect from the method names). The behaviors are not documented. Consequently, the observers are wrongly used in many places in the code base. We should clean up the observers and add good documentation.

Design doc: https://docs.google.com/document/d/1ji_010aI_OCQon08VATF_0dthK_GCHfPZ8CHblkaohs/edit#
Showing comments 30 - 129 of 129 Older ›
Project Member

Comment 30 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4034fc1d8c67c3c6069c20047f55aee7b219e8cf

commit 4034fc1d8c67c3c6069c20047f55aee7b219e8cf
Author: haraken <haraken@chromium.org>
Date: Thu Sep 29 00:09:53 2016

Call ContextLifecycleObserver::contextDestroyed() when a window object is reset

Currently, when a window object is reset, DOMWindowProperty::frameDestroyed() is called but
ContextLifecycleObserver::contextDestroyed() is not called.
This CL makes the latter get called as well.

This is a preparation for replacing DOMWindowProperty with ContextLifecycleObsever.

BUG=610176

Review-Url: https://codereview.chromium.org/2373933002
Cr-Commit-Position: refs/heads/master@{#421690}

[modify] https://crrev.com/4034fc1d8c67c3c6069c20047f55aee7b219e8cf/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a

commit 5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a
Author: haraken <haraken@chromium.org>
Date: Thu Sep 29 03:57:17 2016

Make DOMWindowProperty::m_frame private

BUG=610176

Review-Url: https://codereview.chromium.org/2375873003
Cr-Commit-Position: refs/heads/master@{#421741}

[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/css/StyleMedia.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/frame/BarProp.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/frame/DOMWindowProperty.h
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/frame/Navigator.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/frame/Screen.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/timing/PerformanceNavigation.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/core/timing/PerformanceTiming.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/modules/storage/Storage.cpp
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/modules/storage/Storage.h
[modify] https://crrev.com/5d64de0d2538f4e675a57b1631ebc05a3a2fbd8a/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
Project Member

Comment 32 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40c818f6f15d6db05f87fcb0ee69b58aaea226b4

commit 40c818f6f15d6db05f87fcb0ee69b58aaea226b4
Author: haraken <haraken@chromium.org>
Date: Wed Oct 05 02:47:08 2016

Remove ActiveDOMObject::stop()

Now that ActiveDOMObject::stop() is called almost at the same timing as ContextLifecycleObserver::contextDestroyed().
This CL replaces stop() with contextDestroyed() and removes stop().

BUG=610176

Review-Url: https://codereview.chromium.org/2366253002
Cr-Commit-Position: refs/heads/master@{#423056}

[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/animation/Animation.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/css/FontFaceSet.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/css/MediaQueryList.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/css/MediaQueryList.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/css/MediaQueryListTest.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/ActiveDOMObject.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/ActiveDOMObjectTest.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/MessagePort.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/fileapi/FileReader.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/frame/DOMTimer.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/frame/DOMTimerCoordinator.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/frame/SuspendableTimer.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/frame/SuspendableTimer.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/html/PublicURLManager.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/html/PublicURLManager.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/page/EventSource.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/page/EventSource.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/streams/Stream.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/streams/Stream.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/workers/WorkerThread.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/workers/WorkletGlobalScope.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/battery/BatteryManager.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/filesystem/FileWriter.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/indexeddb/IDBRequestTest.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/indexeddb/IDBTransactionTest.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediasource/MediaSource.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediastream/MediaDevices.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/webmidi/MIDIPort.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/websockets/DOMWebSocket.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.h
[modify] https://crrev.com/40c818f6f15d6db05f87fcb0ee69b58aaea226b4/third_party/WebKit/Source/platform/Timer.h
Project Member

Comment 33 by bugdroid1@chromium.org, Oct 5 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52548aab6ce67bf935040946021baba7f57e2a53

commit 52548aab6ce67bf935040946021baba7f57e2a53
Author: haraken <haraken@chromium.org>
Date: Wed Oct 05 10:40:32 2016

Delay installing supplement objects

Currently supplement objects are installed before window->document() is set.
This is problematic (accurately, this will become a problem when I remove DOMWindowProperty
in a follow-up patch) because the supplement objects cannot be associated with
ContextLifecycleObserver when they are instantiated.
We should install supplement objects after window->document() is set.

BUG=610176

Review-Url: https://codereview.chromium.org/2393523002
Cr-Commit-Position: refs/heads/master@{#423126}

[modify] https://crrev.com/52548aab6ce67bf935040946021baba7f57e2a53/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/52548aab6ce67bf935040946021baba7f57e2a53/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
Project Member

Comment 34 by bugdroid1@chromium.org, Oct 27 2016

Labels: merge-merged-2840
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52548aab6ce67bf935040946021baba7f57e2a53

commit 52548aab6ce67bf935040946021baba7f57e2a53
Author: haraken <haraken@chromium.org>
Date: Wed Oct 05 10:40:32 2016

Delay installing supplement objects

Currently supplement objects are installed before window->document() is set.
This is problematic (accurately, this will become a problem when I remove DOMWindowProperty
in a follow-up patch) because the supplement objects cannot be associated with
ContextLifecycleObserver when they are instantiated.
We should install supplement objects after window->document() is set.

BUG=610176

Review-Url: https://codereview.chromium.org/2393523002
Cr-Commit-Position: refs/heads/master@{#423126}

[modify] https://crrev.com/52548aab6ce67bf935040946021baba7f57e2a53/third_party/WebKit/Source/core/frame/LocalFrame.cpp
[modify] https://crrev.com/52548aab6ce67bf935040946021baba7f57e2a53/third_party/WebKit/Source/core/loader/DocumentLoader.cpp

Comment 35 by dimu@google.com, Nov 4 2016

Labels: -merge-merged-2840
[Automated comment] removing mislabelled merge-merged-2840
Project Member

Comment 36 by bugdroid1@chromium.org, Dec 6 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7f666eca2da478b1a96ab214264acc7b06f3888

commit c7f666eca2da478b1a96ab214264acc7b06f3888
Author: haraken <haraken@chromium.org>
Date: Tue Dec 06 10:59:54 2016

Rename activeDOMObjectsAreStopped to isContextDestroyed

ExecutionContext::activeDOMObjectsAreStopped returns if ExecutionContext::contextDestroyed
has been called or not. It should be renamed to ExecutionContext::isContextDestroyed.

BUG=610176

Review-Url: https://codereview.chromium.org/2552993002
Cr-Commit-Position: refs/heads/master@{#436568}

[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/CallbackPromiseAdapter.h
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyTest.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/core/dom/ActiveDOMObject.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/audio_output_devices/SetSinkIdCallbacks.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/bluetooth/Bluetooth.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTServer.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/cachestorage/Cache.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/fetch/Body.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/fetch/Response.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/permissions/Permissions.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/push_messaging/PushPermissionStatusCallbacks.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/quota/StorageManager.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/serviceworkers/NavigationPreloadCallbacks.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClients.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerWindowClientCallback.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/c7f666eca2da478b1a96ab214264acc7b06f3888/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp
Project Member

Comment 38 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dc9259ff40eeb462367161ead5ab28ab9aa9d23

commit 7dc9259ff40eeb462367161ead5ab28ab9aa9d23
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 09:37:26 2016

Remove ContextLifecycleObserver from ScopedWindowFocusAllowedIndicator

- This CL removes ScopedWindowFocusAllowedIndicator::Observer
since the observer indirection is unnecessary.

- This CL makes ScopedWindowFocusAllowedIndicator hold a strong member
to ExecutionContext and removes ContextLifecycleObserver.

BUG=610176

Review-Url: https://codereview.chromium.org/2555113002
Cr-Commit-Position: refs/heads/master@{#436898}

[modify] https://crrev.com/7dc9259ff40eeb462367161ead5ab28ab9aa9d23/third_party/WebKit/Source/core/dom/ScopedWindowFocusAllowedIndicator.h
Project Member

Comment 39 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ee53c427022b948b552f9c4492d8ff8667e277a9

commit ee53c427022b948b552f9c4492d8ff8667e277a9
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 09:41:24 2016

Remove ContextLifecycleObserver from RemotePlayback

We have made RemotePlayback a ContextLifecycleObserver to make
RemotePlayback::hasPendingActivity return false after the context gets destroyed.
We can do the same thing by checking executionContext->isContextDestroyed
in RemotePlayback::hasPendingActivity. This CL does that and removes
ContextLifecycleObserver from RemotePlayback.

BUG=610176

Review-Url: https://codereview.chromium.org/2559673002
Cr-Commit-Position: refs/heads/master@{#436900}

[modify] https://crrev.com/ee53c427022b948b552f9c4492d8ff8667e277a9/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.cpp
[modify] https://crrev.com/ee53c427022b948b552f9c4492d8ff8667e277a9/third_party/WebKit/Source/modules/remoteplayback/RemotePlayback.h
Project Member

Comment 40 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a0ebdbbfbde6acd2782c30671d42292740762f7

commit 3a0ebdbbfbde6acd2782c30671d42292740762f7
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 09:49:18 2016

Remove ContextLifecycleObserver from PresentationConnectionList

Currently PresentationConnectionList is inheriting from ContextLifecycleObserver
just to implement EventTarget::getExecutionContext(). Instead, PresentationConnectionList
should just hold a strong member to ExecutionContext.

BUG=610176

Review-Url: https://codereview.chromium.org/2558643004
Cr-Commit-Position: refs/heads/master@{#436901}

[modify] https://crrev.com/3a0ebdbbfbde6acd2782c30671d42292740762f7/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.cpp
[modify] https://crrev.com/3a0ebdbbfbde6acd2782c30671d42292740762f7/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h
Project Member

Comment 41 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d4833220d8d9320deb606a0068a332a046486c95

commit d4833220d8d9320deb606a0068a332a046486c95
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 09:56:16 2016

Remove ContextLifecycleObserver from MediaStream

MediaStream doesn't need to inherit from ContextLifecycleObserver.
It just needs to hold a strong member to ExecutionContext.

BUG=610176

Review-Url: https://codereview.chromium.org/2549353005
Cr-Commit-Position: refs/heads/master@{#436903}

[modify] https://crrev.com/d4833220d8d9320deb606a0068a332a046486c95/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp
[modify] https://crrev.com/d4833220d8d9320deb606a0068a332a046486c95/third_party/WebKit/Source/modules/mediastream/MediaStream.h
Project Member

Comment 42 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9a2f35081ced906786154065184f84d36df818c7

commit 9a2f35081ced906786154065184f84d36df818c7
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 13:47:49 2016

Remove ContextLifecycleObserer from XHRReplayData

XHRReplayData inherits from ContextLifecycleObserer just to track
ExecutionContext. It should just hold a strong member to ExecutionContext.

BUG=610176

Review-Url: https://codereview.chromium.org/2555043004
Cr-Commit-Position: refs/heads/master@{#436933}

[modify] https://crrev.com/9a2f35081ced906786154065184f84d36df818c7/third_party/WebKit/Source/core/inspector/InspectorNetworkAgent.cpp
[modify] https://crrev.com/9a2f35081ced906786154065184f84d36df818c7/third_party/WebKit/Source/core/inspector/NetworkResourcesData.cpp
[modify] https://crrev.com/9a2f35081ced906786154065184f84d36df818c7/third_party/WebKit/Source/core/inspector/NetworkResourcesData.h
Project Member

Comment 43 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/816cfec11745623dbf9bb690c9aae85776712095

commit 816cfec11745623dbf9bb690c9aae85776712095
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 13:52:36 2016

Remove ContextLifecycleObserver from SpeechSynthesis

SpeechSynthesis is inherting from ContextLifecycleObserver just to track
ExecutionContext. It should just hold a strong member to ExecutionContext.

BUG=610176

Review-Url: https://codereview.chromium.org/2554303002
Cr-Commit-Position: refs/heads/master@{#436936}

[modify] https://crrev.com/816cfec11745623dbf9bb690c9aae85776712095/third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp
[modify] https://crrev.com/816cfec11745623dbf9bb690c9aae85776712095/third_party/WebKit/Source/modules/speech/SpeechSynthesis.h
Project Member

Comment 44 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ed589328bdfb4cdfe160bbf6e42dc6b9dd33d16

commit 3ed589328bdfb4cdfe160bbf6e42dc6b9dd33d16
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 14:14:58 2016

Remove ContextLifecycleObserver from WorkerPerformance

WorkerPerformance is inheriting from ContextLifecycleObserver
only to implement EventTarget::getExecutionContext().
WorkerPerformance should just hold a strong member to ExecutionContext.

BUG=610176

Review-Url: https://codereview.chromium.org/2553033004
Cr-Commit-Position: refs/heads/master@{#436940}

[modify] https://crrev.com/3ed589328bdfb4cdfe160bbf6e42dc6b9dd33d16/third_party/WebKit/Source/core/timing/WorkerPerformance.cpp
[modify] https://crrev.com/3ed589328bdfb4cdfe160bbf6e42dc6b9dd33d16/third_party/WebKit/Source/core/timing/WorkerPerformance.h
Project Member

Comment 45 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b8e71f5097eccbf0e60e2b7d6c5ca9461c77de3

commit 5b8e71f5097eccbf0e60e2b7d6c5ca9461c77de3
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 14:37:58 2016

Remove ContextLifecycleObserver from SpeechSynthesisUtterance

SpeechSynthesisUtterance inherits from ContextLifecycleObserver just to
implement EventTarget::getExecutionContext(). Instead, SpeechSynthesisUtterance
should just hold a strong member to ExecutionContext.

BUG=610176

Review-Url: https://codereview.chromium.org/2549393005
Cr-Commit-Position: refs/heads/master@{#436947}

[modify] https://crrev.com/5b8e71f5097eccbf0e60e2b7d6c5ca9461c77de3/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.cpp
[modify] https://crrev.com/5b8e71f5097eccbf0e60e2b7d6c5ca9461c77de3/third_party/WebKit/Source/modules/speech/SpeechSynthesisUtterance.h
Project Member

Comment 46 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da5aebc18deaf9e1f7154df19426abf91e877913

commit da5aebc18deaf9e1f7154df19426abf91e877913
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 14:55:13 2016

Remove ContextLifecycleObserver from ScriptPromisePropertyBase

ScriptPromisePropertyBase doesn't need to inherit from ContextLifecycleObserver.
It can just hold a strong member to ExecutionContext.

BUG=610176

Review-Url: https://codereview.chromium.org/2555873004
Cr-Commit-Position: refs/heads/master@{#436950}

[modify] https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
[modify] https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
[modify] https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h
Project Member

Comment 47 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12d08d987d13508e34d9abbd01f062927f2eee90

commit 12d08d987d13508e34d9abbd01f062927f2eee90
Author: haraken <haraken@chromium.org>
Date: Wed Dec 07 15:20:51 2016

Remove ContextLifecycleObserver from V8V0CustomElementLifecycleCallbacks

It's not needed because V8V0CustomElementLifecycleCallbacks already holds
ScriptState.

BUG=610176

Review-Url: https://codereview.chromium.org/2561573002
Cr-Commit-Position: refs/heads/master@{#436960}

[modify] https://crrev.com/12d08d987d13508e34d9abbd01f062927f2eee90/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.cpp
[modify] https://crrev.com/12d08d987d13508e34d9abbd01f062927f2eee90/third_party/WebKit/Source/bindings/core/v8/V8V0CustomElementLifecycleCallbacks.h
Project Member

Comment 49 by bugdroid1@chromium.org, Dec 7 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4383bedae77f70cdb2b22ad5dd684385f835d501

commit 4383bedae77f70cdb2b22ad5dd684385f835d501
Author: flackr <flackr@chromium.org>
Date: Wed Dec 07 22:06:10 2016

Revert of Remove ContextLifecycleObserver from ScriptPromisePropertyBase (patchset #1 id:1 of https://codereview.chromium.org/2555873004/ )

Reason for revert:
This caused us to start failing the following tests on WebKit Linux Trusty Leak (verified by local bisect):
virtual/service-worker-navigation-preload/http/tests/serviceworker/ready.html
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html
virtual/mojo-loading/http/tests/serviceworker/ready.html
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html
virtual/disable-mojo-service-worker/http/tests/serviceworker/ready.html
imported/wpt/service-workers/service-worker/ready.https.html
http/tests/serviceworker/ready.html

First failure:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/559

Original issue's description:
> Remove ContextLifecycleObserver from ScriptPromisePropertyBase
>
> ScriptPromisePropertyBase doesn't need to inherit from ContextLifecycleObserver.
> It can just hold a strong member to ExecutionContext.
>
> BUG=610176
>
> Committed: https://crrev.com/da5aebc18deaf9e1f7154df19426abf91e877913
> Cr-Commit-Position: refs/heads/master@{#436950}

TBR=sigbjornf@opera.com,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176

Review-Url: https://codereview.chromium.org/2557793004
Cr-Commit-Position: refs/heads/master@{#437076}

[modify] https://crrev.com/4383bedae77f70cdb2b22ad5dd684385f835d501/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseProperty.h
[modify] https://crrev.com/4383bedae77f70cdb2b22ad5dd684385f835d501/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
[modify] https://crrev.com/4383bedae77f70cdb2b22ad5dd684385f835d501/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h
Project Member

Comment 50 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aff908ab80d22abb30c09624bf13fec0cbc38490

commit aff908ab80d22abb30c09624bf13fec0cbc38490
Author: haraken <haraken@chromium.org>
Date: Thu Dec 08 04:00:39 2016

Remove ContextLifecycleObserver from WaitUntilObserver

WaitUntilObserver inherits from ContextLifecycleObserver just to keep
track of its associated ExecutionContext. It should just hold a strong
member to ExecutionContext.

BUG=610176

Review-Url: https://codereview.chromium.org/2558773002
Cr-Commit-Position: refs/heads/master@{#437171}

[modify] https://crrev.com/aff908ab80d22abb30c09624bf13fec0cbc38490/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.cpp
[modify] https://crrev.com/aff908ab80d22abb30c09624bf13fec0cbc38490/third_party/WebKit/Source/modules/serviceworkers/WaitUntilObserver.h
Project Member

Comment 51 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d61819fbeda1b74a725e77185766aba0a0cf82f

commit 1d61819fbeda1b74a725e77185766aba0a0cf82f
Author: haraken <haraken@chromium.org>
Date: Thu Dec 08 04:06:40 2016

Remove FetchManager::m_isStopped

It's redundant. GlobalFetch is using FetchManager::m_isStopped to check if
the context has already been destroyed. However, the check is not needed
because scriptState->contextIsValid() is already checking the fact.

BUG=610176

Review-Url: https://codereview.chromium.org/2557023002
Cr-Commit-Position: refs/heads/master@{#437173}

[modify] https://crrev.com/1d61819fbeda1b74a725e77185766aba0a0cf82f/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/1d61819fbeda1b74a725e77185766aba0a0cf82f/third_party/WebKit/Source/modules/fetch/FetchManager.h
[modify] https://crrev.com/1d61819fbeda1b74a725e77185766aba0a0cf82f/third_party/WebKit/Source/modules/fetch/GlobalFetch.cpp
Project Member

Comment 52 by bugdroid1@chromium.org, Dec 8 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66af5a98e7073a40f05ab8828ea135e6e61dd5b5

commit 66af5a98e7073a40f05ab8828ea135e6e61dd5b5
Author: haraken <haraken@chromium.org>
Date: Thu Dec 08 05:36:55 2016

Remove ContextLifecycleObserver from PaymenAppManager

PaymenAppManager is inheriting from ContextLifecycleObserver just to
clear a service pointer (i.e., m_manager) when the context is destroyed.
This looks unnecessary, so this CL removes it and thus removes
ContextLifecycleObserver from PaymenAppManager.

BUG=610176

Review-Url: https://codereview.chromium.org/2553163003
Cr-Commit-Position: refs/heads/master@{#437189}

[modify] https://crrev.com/66af5a98e7073a40f05ab8828ea135e6e61dd5b5/third_party/WebKit/Source/modules/payments/PaymentAppManager.cpp
[modify] https://crrev.com/66af5a98e7073a40f05ab8828ea135e6e61dd5b5/third_party/WebKit/Source/modules/payments/PaymentAppManager.h
[modify] https://crrev.com/66af5a98e7073a40f05ab8828ea135e6e61dd5b5/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.cpp
Project Member

Comment 53 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56

commit 7b372233ed3d9859e1204aa3a9af7f5f9bb32a56
Author: haraken <haraken@chromium.org>
Date: Mon Dec 12 04:30:37 2016

Rename ActiveDOMObject to SuspendableObject

This is a rename requested by https://codereview.chromium.org/2554813002/.

Previously ActiveDOMObject was used to implement hasPendingActivity() of DOM wrappers,
where the name "ActiveDOMObject" made sense. Then we moved hasPendingActivity() to
ActiveScriptWrappable. Now ActiveDOMObject is a class that just provides resume/suspend.
It would make more sense to rename it to SuspendableObject.

BUG=610176
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2567913002
Cr-Commit-Position: refs/heads/master@{#437820}

[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/content/public/test/render_view_test.cc
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/content/shell/renderer/layout_test/leak_detector.cc
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/bindings/core/v8/RetainedDOMInfo.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolverTest.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/animation/Animation.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/css/FontFaceSet.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/css/MediaQueryList.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/css/MediaQueryList.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/BUILD.gn
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/IntersectionObserverController.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/MessagePort.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h
[rename] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/SuspendableObject.cpp
[rename] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/SuspendableObject.h
[rename] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/dom/SuspendableObjectTest.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/events/EventTarget.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/fileapi/FileReader.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/frame/DOMTimer.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/frame/SuspendableTimer.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/frame/SuspendableTimer.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/html/PublicURLManager.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/html/PublicURLManager.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/streams/Stream.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/streams/Stream.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/workers/AbstractWorker.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/workers/AbstractWorker.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/workers/WorkerGlobalScope.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/battery/BatteryManager.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/eventsource/EventSource.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/eventsource/EventSource.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/filesystem/FileWriter.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediasource/MediaSource.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediastream/MediaDevices.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/sensor/Sensor.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/speech/SpeechRecognition.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/webmidi/MIDIPort.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/modules/websockets/DOMWebSocket.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/platform/AsyncMethodRunner.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/platform/InstanceCounters.h
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/web/WebHelperPluginImpl.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/Source/web/WebLeakDetector.cpp
[modify] https://crrev.com/7b372233ed3d9859e1204aa3a9af7f5f9bb32a56/third_party/WebKit/public/web/WebLeakDetector.h
Project Member

Comment 54 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c2137797952d207c4b38f3abc3962442f8b9b4a

commit 9c2137797952d207c4b38f3abc3962442f8b9b4a
Author: haraken <haraken@chromium.org>
Date: Mon Dec 12 05:08:38 2016

Remove clearContext() from VRController::contextDestroyed

Now that ContextLifecycleObserver clears its observing context after calling
contextDestroyed. So there is no need to explicitly call clearContext().

BUG=610176

Review-Url: https://codereview.chromium.org/2552703006
Cr-Commit-Position: refs/heads/master@{#437821}

[modify] https://crrev.com/9c2137797952d207c4b38f3abc3962442f8b9b4a/third_party/WebKit/Source/modules/vr/VRController.cpp
Project Member

Comment 55 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/164ea1ce58813039385db255a4fcd47f3a4b5205

commit 164ea1ce58813039385db255a4fcd47f3a4b5205
Author: haraken <haraken@chromium.org>
Date: Mon Dec 12 12:38:55 2016

Add ContextLifecycleObserver::frame()

I'm replacing DOMWindowProperty with ContextLifecycleObserver.
(ContextLifecycleObserver::contextDestroyed() is called already almost at the same
timing as DOMWindowProperty::frameDestroyed().)

To make the replacement easier, this CL introduces ContextLifecycleObserver::frame().
Also this CL moves ApplicationCache to ContextLifecycleObserver.

BUG=610176

Review-Url: https://codereview.chromium.org/2562303002
Cr-Commit-Position: refs/heads/master@{#437852}

[modify] https://crrev.com/164ea1ce58813039385db255a4fcd47f3a4b5205/third_party/WebKit/Source/core/dom/BUILD.gn
[add] https://crrev.com/164ea1ce58813039385db255a4fcd47f3a4b5205/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.cpp
[modify] https://crrev.com/164ea1ce58813039385db255a4fcd47f3a4b5205/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
[modify] https://crrev.com/164ea1ce58813039385db255a4fcd47f3a4b5205/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp
[modify] https://crrev.com/164ea1ce58813039385db255a4fcd47f3a4b5205/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.h
Project Member

Comment 56 by bugdroid1@chromium.org, Dec 12 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89aaa753cac97aa76612a34dcff6bd5d1a78d698

commit 89aaa753cac97aa76612a34dcff6bd5d1a78d698
Author: haraken <haraken@chromium.org>
Date: Mon Dec 12 17:18:00 2016

Remove DOMWindowProperty from PingLoaderImpl

PingLoaderImpl just needs a WeakMember<LocalFrame>.
It doesn't need to inherit from DOMWindowProperty.

BUG=610176

Review-Url: https://codereview.chromium.org/2567933003
Cr-Commit-Position: refs/heads/master@{#437894}

[modify] https://crrev.com/89aaa753cac97aa76612a34dcff6bd5d1a78d698/third_party/WebKit/Source/core/loader/PingLoader.cpp
[modify] https://crrev.com/89aaa753cac97aa76612a34dcff6bd5d1a78d698/third_party/WebKit/Source/core/loader/PingLoader.h
Project Member

Comment 57 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3006a20fcf89e17a112edcc3e7b33c7cacf9accf

commit 3006a20fcf89e17a112edcc3e7b33c7cacf9accf
Author: haraken <haraken@chromium.org>
Date: Tue Dec 13 10:16:25 2016

Remove DOMWindowProperty from PresentationController

We're deprecating DOMWindowProperty, which is now equivalent to ContextLifecycleObserver.
This CL replaces DOMWindowProperty with ContextLifecycleObserver in PresentationController.

BUG=610176

Review-Url: https://codereview.chromium.org/2569963003
Cr-Commit-Position: refs/heads/master@{#438114}

[modify] https://crrev.com/3006a20fcf89e17a112edcc3e7b33c7cacf9accf/third_party/WebKit/Source/modules/presentation/PresentationController.cpp
[modify] https://crrev.com/3006a20fcf89e17a112edcc3e7b33c7cacf9accf/third_party/WebKit/Source/modules/presentation/PresentationController.h
Project Member

Comment 58 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4256ecc52fd229daa6e9c7aff0ccbe275cb71a49

commit 4256ecc52fd229daa6e9c7aff0ccbe275cb71a49
Author: haraken <haraken@chromium.org>
Date: Tue Dec 13 11:20:13 2016

InstalledAppController should use ContextLifecycleObserver instead of DOMWindowProperty

DOMWindowProperty::frameDestroyed is now equivalent to ContextLifecycleObserver::contextDestroyed.
This CL does the replacement for InstalledAppController.

BUG=610176

Review-Url: https://codereview.chromium.org/2571513003
Cr-Commit-Position: refs/heads/master@{#438123}

[modify] https://crrev.com/4256ecc52fd229daa6e9c7aff0ccbe275cb71a49/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
[modify] https://crrev.com/4256ecc52fd229daa6e9c7aff0ccbe275cb71a49/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h
Project Member

Comment 59 by bugdroid1@chromium.org, Dec 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0aa1063996215029b25ec69a78a5027854b20b29

commit 0aa1063996215029b25ec69a78a5027854b20b29
Author: haraken <haraken@chromium.org>
Date: Tue Dec 13 13:48:58 2016

Remove DOMWindowProperty from Performance

We're deprecating DOMWindowProperty, which is equivalent to ContextLifecycleObserver.
This CL does the replacement for Performance.

BUG=610176

Review-Url: https://codereview.chromium.org/2569153002
Cr-Commit-Position: refs/heads/master@{#438155}

[modify] https://crrev.com/0aa1063996215029b25ec69a78a5027854b20b29/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/0aa1063996215029b25ec69a78a5027854b20b29/third_party/WebKit/Source/core/timing/Performance.h
Project Member

Comment 61 by bugdroid1@chromium.org, Dec 14 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/45369974f8ad223059462980229a9735e6ee6865

commit 45369974f8ad223059462980229a9735e6ee6865
Author: haraken <haraken@chromium.org>
Date: Wed Dec 14 18:36:41 2016

WindowAnimationWorklet should use ContextLifecycleObserver instead of DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with ContextLifecycleObserver.

Also this CL adds a comment why WindowAnimationWorklet needs to clear
m_animationWorklet in contextDestroyed().

BUG=610176

Review-Url: https://codereview.chromium.org/2571753002
Cr-Commit-Position: refs/heads/master@{#438544}

[modify] https://crrev.com/45369974f8ad223059462980229a9735e6ee6865/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp
[modify] https://crrev.com/45369974f8ad223059462980229a9735e6ee6865/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
Project Member

Comment 62 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c07e945885e83b4ec9157c62891d8e62d8d7eb38

commit c07e945885e83b4ec9157c62891d8e62d8d7eb38
Author: haraken <haraken@chromium.org>
Date: Fri Dec 16 08:25:55 2016

WindowAudioWorklet should use ContextLifecycleObserver instead of DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with ContextLifecycleObserver.

Also this CL adds a comment why WindowAudioWorklet needs to clear
m_audioWorklet in contextDestroyed().

BUG=610176

Review-Url: https://codereview.chromium.org/2567243005
Cr-Commit-Position: refs/heads/master@{#439068}

[modify] https://crrev.com/c07e945885e83b4ec9157c62891d8e62d8d7eb38/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp
[modify] https://crrev.com/c07e945885e83b4ec9157c62891d8e62d8d7eb38/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.h
Project Member

Comment 63 by bugdroid1@chromium.org, Dec 16 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c07e945885e83b4ec9157c62891d8e62d8d7eb38

commit c07e945885e83b4ec9157c62891d8e62d8d7eb38
Author: haraken <haraken@chromium.org>
Date: Fri Dec 16 08:25:55 2016

WindowAudioWorklet should use ContextLifecycleObserver instead of DOMWindowProperty

We're deprecating DOMWindowProperty. So this CL replaces it with ContextLifecycleObserver.

Also this CL adds a comment why WindowAudioWorklet needs to clear
m_audioWorklet in contextDestroyed().

BUG=610176

Review-Url: https://codereview.chromium.org/2567243005
Cr-Commit-Position: refs/heads/master@{#439068}

[modify] https://crrev.com/c07e945885e83b4ec9157c62891d8e62d8d7eb38/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp
[modify] https://crrev.com/c07e945885e83b4ec9157c62891d8e62d8d7eb38/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.h
Project Member

Comment 64 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd2e0942b294948ee891b1e54ca17a195fc1f3a1

commit dd2e0942b294948ee891b1e54ca17a195fc1f3a1
Author: haraken <haraken@chromium.org>
Date: Mon Dec 19 05:14:20 2016

Install supplements at every navigation

Currently supplement objects are reused when an initial empty document navigates to
a same-origin document. This is problematic because ContextLifecycleObservers are
detached when the initial empty document is destroyed. They cannot be used after
the navigation.

To fix the problem, we need to install supplements at every navigation.

BUG=610176

Review-Url: https://codereview.chromium.org/2580753004
Cr-Commit-Position: refs/heads/master@{#439413}

[modify] https://crrev.com/dd2e0942b294948ee891b1e54ca17a195fc1f3a1/third_party/WebKit/Source/core/loader/DocumentLoader.cpp
Project Member

Comment 65 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/596d1c908dbd53334f9f77162becc6b1b5c8dba8

commit 596d1c908dbd53334f9f77162becc6b1b5c8dba8
Author: haraken <haraken@chromium.org>
Date: Mon Dec 19 07:02:10 2016

Remove DOMWindowProperty from ScreenOrientationCoontroller

We're replacing DOMWindowProperty with ContextLifecycleObserver.
This CL does the replacement for ScreenOrientationCoontroller.

BUG=610176

Review-Url: https://codereview.chromium.org/2568913003
Cr-Commit-Position: refs/heads/master@{#439421}

[modify] https://crrev.com/596d1c908dbd53334f9f77162becc6b1b5c8dba8/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp
[modify] https://crrev.com/596d1c908dbd53334f9f77162becc6b1b5c8dba8/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
Project Member

Comment 67 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/476bd13c7171fffc2c991495970dcaecfa8ddf69

commit 476bd13c7171fffc2c991495970dcaecfa8ddf69
Author: haraken <haraken@chromium.org>
Date: Mon Dec 19 08:09:54 2016

Remove unnecessary LifecycleObserver::clearContext

LifecycleObserver::clearContext is automatically called immediately after
contextDestroyed() gets called. The caller side doesn't need to call clearContext
explicitly.

BUG=610176

Review-Url: https://codereview.chromium.org/2588663002
Cr-Commit-Position: refs/heads/master@{#439431}

[modify] https://crrev.com/476bd13c7171fffc2c991495970dcaecfa8ddf69/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/476bd13c7171fffc2c991495970dcaecfa8ddf69/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
Project Member

Comment 69 by bugdroid1@chromium.org, Dec 19 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/216a94bf46972065bc416c85ad0956b7b6eafb9c

commit 216a94bf46972065bc416c85ad0956b7b6eafb9c
Author: haraken <haraken@chromium.org>
Date: Mon Dec 19 10:37:47 2016

Remove LifecycleNotifier::removePending

It's unused

BUG=610176

Review-Url: https://codereview.chromium.org/2589653002
Cr-Commit-Position: refs/heads/master@{#439450}

[modify] https://crrev.com/216a94bf46972065bc416c85ad0956b7b6eafb9c/third_party/WebKit/Source/platform/LifecycleNotifier.h
Project Member

Comment 70 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e873a8e81ec1427467406cbb47293afc35dc1e16

commit e873a8e81ec1427467406cbb47293afc35dc1e16
Author: haraken <haraken@chromium.org>
Date: Wed Dec 21 03:03:47 2016

Introduce ContextObserver

There are many ContextLifecycleObservers that want to use getExecutionContext()
and frame() but don't need contextDestroyed() notifications. Since ContextLifecycleObserver
is heavy, it seems better to introduce a lightweight version of ContextLifecycleObserver
that only provides getExecutionContext() and frame().

This CL introduces ContextObserver and uses it in BarProp.

ContextObserver can also be used in classes that are currently storing Member<ExecutionContext>
or Member<LocalFrame> and using isContextDestroyed() to check if the observing context is alive.

BUG=610176

Review-Url: https://codereview.chromium.org/2585143002
Cr-Commit-Position: refs/heads/master@{#439990}

[modify] https://crrev.com/e873a8e81ec1427467406cbb47293afc35dc1e16/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.cpp
[modify] https://crrev.com/e873a8e81ec1427467406cbb47293afc35dc1e16/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
[modify] https://crrev.com/e873a8e81ec1427467406cbb47293afc35dc1e16/third_party/WebKit/Source/core/frame/BarProp.cpp
[modify] https://crrev.com/e873a8e81ec1427467406cbb47293afc35dc1e16/third_party/WebKit/Source/core/frame/BarProp.h
Project Member

Comment 71 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb7b0b4e2d9af73d8bec28b9f39fecfb4906a350

commit fb7b0b4e2d9af73d8bec28b9f39fecfb4906a350
Author: haraken <haraken@chromium.org>
Date: Wed Dec 21 10:48:56 2016

Make DOMWindowProperty::frameDestroyed non-virtual

Now no one is overriding DOMWindowProperty::frameDestroyed.

BUG=610176

Review-Url: https://codereview.chromium.org/2589403002
Cr-Commit-Position: refs/heads/master@{#440070}

[modify] https://crrev.com/fb7b0b4e2d9af73d8bec28b9f39fecfb4906a350/third_party/WebKit/Source/core/frame/DOMWindowProperty.h
Project Member

Comment 73 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/650b4c601daf29284da75c53557e270c552185e4

commit 650b4c601daf29284da75c53557e270c552185e4
Author: haraken <haraken@chromium.org>
Date: Wed Dec 21 13:33:50 2016

Replace DOMWindowProperty in modules/plugins/ with ContextClient

We're deprecating DOMWindowProperty.

BUG=610176

Review-Url: https://codereview.chromium.org/2591043004
Cr-Commit-Position: refs/heads/master@{#440082}

[modify] https://crrev.com/650b4c601daf29284da75c53557e270c552185e4/third_party/WebKit/Source/modules/plugins/DOMMimeType.cpp
[modify] https://crrev.com/650b4c601daf29284da75c53557e270c552185e4/third_party/WebKit/Source/modules/plugins/DOMMimeType.h
[modify] https://crrev.com/650b4c601daf29284da75c53557e270c552185e4/third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.cpp
[modify] https://crrev.com/650b4c601daf29284da75c53557e270c552185e4/third_party/WebKit/Source/modules/plugins/DOMMimeTypeArray.h
[modify] https://crrev.com/650b4c601daf29284da75c53557e270c552185e4/third_party/WebKit/Source/modules/plugins/DOMPlugin.cpp
[modify] https://crrev.com/650b4c601daf29284da75c53557e270c552185e4/third_party/WebKit/Source/modules/plugins/DOMPlugin.h
[modify] https://crrev.com/650b4c601daf29284da75c53557e270c552185e4/third_party/WebKit/Source/modules/plugins/DOMPluginArray.cpp
[modify] https://crrev.com/650b4c601daf29284da75c53557e270c552185e4/third_party/WebKit/Source/modules/plugins/DOMPluginArray.h
Project Member

Comment 74 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01c3564cde9cbaa8705f128337f3bed44c2d6ae3

commit 01c3564cde9cbaa8705f128337f3bed44c2d6ae3
Author: haraken <haraken@chromium.org>
Date: Wed Dec 21 13:54:38 2016

PingLoaderImpl should use ContextClient instead of using WeakMember

PingLoaderImpl is expecting frame() to be cleared when the frame is detached.
This means that it needs to be ContextClient.
Using WeakMember<LocalFrame> is wrong because frame() is not cleared until
the frame is gc-ed.

BUG=610176

Review-Url: https://codereview.chromium.org/2592993002
Cr-Commit-Position: refs/heads/master@{#440085}

[modify] https://crrev.com/01c3564cde9cbaa8705f128337f3bed44c2d6ae3/third_party/WebKit/Source/core/loader/PingLoader.cpp
Project Member

Comment 75 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1d2841edc991253b3ee04a6cd66b38547d83175

commit e1d2841edc991253b3ee04a6cd66b38547d83175
Author: haraken <haraken@chromium.org>
Date: Wed Dec 21 13:56:04 2016

Replace DOMWindowProperty in DOMWindow's supplements with ContextClient

This is a preparation for deprecating DOMWindowProperty.

BUG=610176

Review-Url: https://codereview.chromium.org/2598463004
Cr-Commit-Position: refs/heads/master@{#440086}

[modify] https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175/third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.cpp
[modify] https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175/third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.h
[modify] https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175/third_party/WebKit/Source/modules/quota/DOMWindowQuota.cpp
[modify] https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175/third_party/WebKit/Source/modules/quota/DOMWindowQuota.h
[modify] https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175/third_party/WebKit/Source/modules/speech/DOMWindowSpeechSynthesis.cpp
[modify] https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175/third_party/WebKit/Source/modules/speech/DOMWindowSpeechSynthesis.h
[modify] https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175/third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp
[modify] https://crrev.com/e1d2841edc991253b3ee04a6cd66b38547d83175/third_party/WebKit/Source/modules/storage/DOMWindowStorage.h
Project Member

Comment 76 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28a790f8946476da715d9ba72406f1dce462906b

commit 28a790f8946476da715d9ba72406f1dce462906b
Author: haraken <haraken@chromium.org>
Date: Wed Dec 21 14:03:27 2016

ScriptPromisePropertyBase should use ContextClient instead of ContextLifecycleObserver

ScriptPromisePropertyBase doesn't need to observe contextDestroyed.
So ContextClient is enough and more efficient.

BUG=610176

Review-Url: https://codereview.chromium.org/2587323004
Cr-Commit-Position: refs/heads/master@{#440087}

[modify] https://crrev.com/28a790f8946476da715d9ba72406f1dce462906b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
[modify] https://crrev.com/28a790f8946476da715d9ba72406f1dce462906b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.h
Project Member

Comment 77 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/328b9c7e9c7ee0f18cda00b6944b9d493410ff02

commit 328b9c7e9c7ee0f18cda00b6944b9d493410ff02
Author: haraken <haraken@chromium.org>
Date: Wed Dec 21 14:18:11 2016

Rename activeDOMObjectsAreSuspended to isContextSuspended

Since ActiveDOMObject was renamed to SuspendableObject.
We should rename the method accordingly.

BUG=610176

Review-Url: https://codereview.chromium.org/2587913002
Cr-Commit-Position: refs/heads/master@{#440088}

[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/LayoutTests/http/tests/activedomobject/media-expected.txt
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/LayoutTests/http/tests/activedomobject/media.html
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release-noreference.html
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release.html
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-multiple-mediakeys.html
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/templates/callback_function.cpp.tmpl
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/tests/results/core/AnyCallbackFunctionOptionalAnyArg.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/tests/results/core/LongCallbackFunction.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/tests/results/core/StringSequenceCallbackFunctionLongSequenceArg.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunction.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionInterfaceArg.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/tests/results/core/VoidCallbackFunctionTypedef.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/bindings/tests/results/modules/VoidCallbackFunctionModules.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/ContextLifecycleNotifier.h
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/Document.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/ExecutionContext.h
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/MutationObserver.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/SuspendableObject.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/dom/SuspendableObjectTest.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/frame/DeviceSingleWindowEventController.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/layout/LayoutObject.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/core/timing/PerformanceObserver.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/modules/filesystem/FileSystemCallbacks.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/328b9c7e9c7ee0f18cda00b6944b9d493410ff02/third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp
Project Member

Comment 79 by bugdroid1@chromium.org, Dec 21 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2a82dec413030fd74cf7e8d3c60b03df5582be6

commit e2a82dec413030fd74cf7e8d3c60b03df5582be6
Author: haraken <haraken@chromium.org>
Date: Wed Dec 21 14:26:11 2016

Replace DOMWindowProperty in Navigator supplements with ContextClient

This is a preparation for deprecating DOMWindowProperty.

BUG=610176

Review-Url: https://codereview.chromium.org/2596443005
Cr-Commit-Position: refs/heads/master@{#440093}

[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/credentialmanager/NavigatorCredentials.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/plugins/NavigatorPlugins.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/plugins/NavigatorPlugins.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp
[modify] https://crrev.com/e2a82dec413030fd74cf7e8d3c60b03df5582be6/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.h
Project Member

Comment 82 by bugdroid1@chromium.org, Dec 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2eaec7e72e92484106db0546183c7921a370530

commit e2eaec7e72e92484106db0546183c7921a370530
Author: haraken <haraken@chromium.org>
Date: Mon Dec 26 05:42:25 2016

Replace DOMWindowProperty in core/ with ContextClient

This is a preparation for deprecating DOMWindowProperty.

BUG=610176

Review-Url: https://codereview.chromium.org/2593983002
Cr-Commit-Position: refs/heads/master@{#440692}

[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/css/StyleMedia.cpp
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/css/StyleMedia.h
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/editing/DOMSelection.cpp
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/editing/DOMSelection.h
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/frame/History.cpp
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/frame/History.h
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/frame/Screen.cpp
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/frame/Screen.h
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.cpp
[modify] https://crrev.com/e2eaec7e72e92484106db0546183c7921a370530/third_party/WebKit/Source/core/workers/MainThreadWorkletGlobalScope.h
Project Member

Comment 83 by bugdroid1@chromium.org, Dec 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/852b53148e04122ccb0c444dff6e8e0cc3939f26

commit 852b53148e04122ccb0c444dff6e8e0cc3939f26
Author: haraken <haraken@chromium.org>
Date: Mon Dec 26 08:29:54 2016

Body should use ContextClient instead of ContextLifecycleObserver

ContextClient is more lightweight than ContextLifecycleObserver.
We prefer ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2605603002
Cr-Commit-Position: refs/heads/master@{#440697}

[modify] https://crrev.com/852b53148e04122ccb0c444dff6e8e0cc3939f26/third_party/WebKit/Source/modules/fetch/Body.cpp
[modify] https://crrev.com/852b53148e04122ccb0c444dff6e8e0cc3939f26/third_party/WebKit/Source/modules/fetch/Body.h
Project Member

Comment 84 by bugdroid1@chromium.org, Dec 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f33f82d2993c9aebb11b66c0389d7646c2817c

commit 71f33f82d2993c9aebb11b66c0389d7646c2817c
Author: haraken <haraken@chromium.org>
Date: Mon Dec 26 10:05:57 2016

MediaSession should use ContextClient instead of ContextLifecycleObserver

ContextClient is more lightweight than ContextLifecycleObserver.
We prefer ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2602663002
Cr-Commit-Position: refs/heads/master@{#440708}

[modify] https://crrev.com/71f33f82d2993c9aebb11b66c0389d7646c2817c/third_party/WebKit/Source/modules/mediasession/MediaSession.cpp
[modify] https://crrev.com/71f33f82d2993c9aebb11b66c0389d7646c2817c/third_party/WebKit/Source/modules/mediasession/MediaSession.h
Project Member

Comment 85 by bugdroid1@chromium.org, Dec 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f6899612b14fdb5555e122092771675b98e0633

commit 7f6899612b14fdb5555e122092771675b98e0633
Author: haraken <haraken@chromium.org>
Date: Mon Dec 26 11:07:05 2016

encrypted-media tests should not count # of SuspendableObjects

It is too fragile to count # of SuspendableObjects because
the result changes when people add/remove SuspendableObjects from the code base.
Alternately, the tests should directly count # of MediaKeys and MediaKeysSessions.

BUG=610176

Review-Url: https://codereview.chromium.org/2606633002
Cr-Commit-Position: refs/heads/master@{#440709}

[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeys-with-session.html
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-reference.html
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release-noreference.html
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-mediakeysession-release.html
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-lifetime-multiple-mediakeys.html
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/Source/core/testing/Internals.cpp
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/Source/core/testing/Internals.h
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/Source/core/testing/Internals.idl
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/7f6899612b14fdb5555e122092771675b98e0633/third_party/WebKit/Source/platform/InstanceCounters.h
Project Member

Comment 86 by bugdroid1@chromium.org, Dec 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/61862d1ea4b844b5b5051ea34945284b4a5dac71

commit 61862d1ea4b844b5b5051ea34945284b4a5dac71
Author: haraken <haraken@chromium.org>
Date: Mon Dec 26 14:33:32 2016

IntersectionObserverCallbackImpl should use Member<ExecutionContext>

Currently IntersectionObserverCallbackImpl uses WeakMember<ExecutionContext>
but I don't see any reason it has to be a weak member.
Also some call site assumes that IntersectionObserverCallbackImpl::getExecutionContext()
doesn't return null.

So it looks better to let IntersectionObserverCallbackImpl own Member<ExecutionContext>.

BUG=610176

Review-Url: https://codereview.chromium.org/2601733002
Cr-Commit-Position: refs/heads/master@{#440714}

[modify] https://crrev.com/61862d1ea4b844b5b5051ea34945284b4a5dac71/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
Project Member

Comment 87 by bugdroid1@chromium.org, Dec 26 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90fda9f137b984c32b16bccdb664bc9742865331

commit 90fda9f137b984c32b16bccdb664bc9742865331
Author: avi <avi@chromium.org>
Date: Mon Dec 26 20:17:51 2016

Revert of IntersectionObserverCallbackImpl should use Member<ExecutionContext> (patchset #1 id:1 of https://codereview.chromium.org/2601733002/ )

Reason for revert:
Crashes telemetry bots.

https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/11254
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%281%29/builds/61679

  	005be100 67b85543 00000012 212a2238 00000000 chrome_child!blink::IntersectionObserver::computeIntersectionObservations+0x2e
  	005be140 67c44f75 212a2238 005be184 67c43f05 chrome_child!blink::IntersectionObserverController::computeTrackedIntersectionObservations+0xa2
  	005be14c 67c43f05 00000012 6939fcdc 2b941820 chrome_child!blink::FrameView::updateViewportIntersectionsForSubtree+0x3b
  	005be184 67c439fd 00000012 67e3e961 384b0000 chrome_child!blink::FrameView::updateLifecyclePhasesInternal+0x22f
  	005be18c 67e3e961 384b0000 00000000 005be1a8 chrome_child!blink::FrameView::updateAllLifecyclePhases+0x18
  	005be19c 679b9ce1 318e1a88 005be1e0 679a77e5 chrome_child!blink::PageAnimator::updateAllLifecyclePhases+0x1c
  	005be1a8 679a77e5 318e1820 318e1a88 0139c080 chrome_child!blink::PageWidgetDelegate::updateAllLifecyclePhases+0x11
  	005be1e0 684c45d9 049c90fc 04952dd0 00000000 chrome_child!blink::WebViewImpl::updateAllLifecyclePhases+0xa2
  	005be354 684cd388 04952dd0 00000000 0165ca70 chrome_child!cc::ProxyMain::BeginMainFrame+0x409
  	005be4d0 684ceba6 049c90f8 684c41d0 049c90e8 chrome_child!base::internal::Invoker<base::internal::BindState<void (__thiscall cc::ProxyMain::*)(std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> >),base::WeakPtr<cc::ProxyMain>,base::internal::PassedWrapper<std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> > > >,void __cdecl(void)>::RunImpl<void (__thiscall cc::ProxyMain::*const &)(std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> >),std::tuple<base::WeakPtr<cc::ProxyMain>,base::internal::PassedWrapper<std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> > > > const &,0,1>+0x98
  	005be4e4 671ff214 049c90e8 0165dcd0 00000000 chrome_child!base::internal::Invoker<base::internal::BindState<void (__thiscall cc::ProxyMain::*)(std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> >),base::WeakPtr<cc::ProxyMain>,base::internal::PassedWrapper<std::unique_ptr<cc::BeginMainFrameAndCommitState,std::default_delete<cc::BeginMainFrameAndCommitState> > > >,void __cdecl(void)>::Run+0x16
  	005be5a4 67962b56 68e02cb4 005be8e0 005be9dc chrome_child!base::debug::TaskAnnotator::RunTask+0x164
  	005be9cc 679622cc 0165be08 005bea0c 0165c958 chrome_child!blink::scheduler::TaskQueueManager::ProcessTaskFromWorkQueue+0x3dc
  	005bea38 6796176f 00000000 00000000 00000003 chrome_child!blink::scheduler::TaskQueueManager::DoWork+0x119
  	005bea4c 679617b5 679621b3 00000000 0165bc38 chrome_child!base::internal::FunctorTraits<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),void>::Invoke<base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &>+0x22
  	005bea68 679617d1 0165bc20 0165bc38 0165bc30 chrome_child!base::internal::InvokeHelper<1,void>::MakeItSo<void (__thiscall blink::scheduler::TaskQueueManager::*const &)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager> const &,base::TimeTicks const &,bool const &>+0x25
  	005bea80 67962e9d 0165bc20 0165bc28 0165bc10 chrome_child!base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::RunImpl<void (__thiscall blink::scheduler::TaskQueueManager::*const &)(base::TimeTicks,bool),std::tuple<base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool> const &,0,1,2>+0x17
  	005bea94 671ff214 0165bc10 00000000 00000000 chrome_child!base::internal::Invoker<base::internal::BindState<void (__thiscall blink::scheduler::TaskQueueManager::*)(base::TimeTicks,bool),base::WeakPtr<blink::scheduler::TaskQueueManager>,base::TimeTicks,bool>,void __cdecl(void)>::Run+0x16
  	005beb54 671cb5ad 68bfd37c 005bf830 0165c958 chrome_child!base::debug::TaskAnnotator::RunTask+0x164
  	005bf7b8 671caa75 005bf830 0164adb8 0165c958 chrome_child!base::MessageLoop::RunTask+0x4cd
  	005bf874 67200714 00000000 0165c958 00000000 chrome_child!base::MessageLoop::DoWork+0x255
  	005bf88c 671cb0ce 0165c958 005bf9dc 68b17d6c chrome_child!base::MessagePumpDefault::Run+0x74
  	005bf954 671d95af 68f11b10 00000000 687c6210 chrome_child!base::MessageLoop::RunHandler+0x5e
  	005bf9c8 6816baa8 01631980 00000003 01632a28 chrome_child!base::RunLoop::Run+0x6f
  	005bfaa4 67186ea4 005bfadc 0163d818 00000000 chrome_child!content::RendererMain+0x1e6
  	005bfab8 67186e12 005bfaf4 005bfadc 005bfbe4 chrome_child!content::RunNamedProcessTypeMain+0x61
  	005bfb10 671864d9 0100b768 6d004270 005bfc18 chrome_child!content::ContentMainRunnerImpl::Run+0x97
  	005bfb20 668fd5a7 005bfc00 668fd4f0 0100b770 chrome_child!content::ContentMain+0x23

Original issue's description:
> IntersectionObserverCallbackImpl should use Member<ExecutionContext>
>
> Currently IntersectionObserverCallbackImpl uses WeakMember<ExecutionContext>
> but I don't see any reason it has to be a weak member.
> Also some call site assumes that IntersectionObserverCallbackImpl::getExecutionContext()
> doesn't return null.
>
> So it looks better to let IntersectionObserverCallbackImpl own Member<ExecutionContext>.
>
> BUG=610176
>
> Committed: https://crrev.com/61862d1ea4b844b5b5051ea34945284b4a5dac71
> Cr-Commit-Position: refs/heads/master@{#440714}

TBR=sigbjornf@opera.com,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176

Review-Url: https://codereview.chromium.org/2600143002
Cr-Commit-Position: refs/heads/master@{#440721}

[modify] https://crrev.com/90fda9f137b984c32b16bccdb664bc9742865331/third_party/WebKit/Source/core/dom/IntersectionObserver.cpp
Project Member

Comment 88 by bugdroid1@chromium.org, Dec 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64078ba4340c37a7d43de4db545a05279f2121f5

commit 64078ba4340c37a7d43de4db545a05279f2121f5
Author: haraken <haraken@chromium.org>
Date: Tue Dec 27 03:27:45 2016

Reduce SuspendableObjects

Objects that don't inherit from suspend/resume don't need to be SuspendableObjects.
They should just inherit from ContextLifecycleObserver instead.

BUG=610176

Review-Url: https://codereview.chromium.org/2583093002
Cr-Commit-Position: refs/heads/master@{#440727}

[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/animation/Animation.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/css/MediaQueryList.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/css/MediaQueryList.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/dom/ExecutionContext.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/dom/MessagePort.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/dom/MessagePort.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/fileapi/FileReader.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/html/PublicURLManager.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/html/PublicURLManager.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/workers/AbstractWorker.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/workers/AbstractWorker.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/workers/SharedWorker.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/compositorworker/AnimationWorklet.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/csspaint/PaintWorklet.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/eventsource/EventSource.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/eventsource/EventSource.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/filesystem/FileWriter.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/mediasource/MediaSource.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/speech/SpeechRecognition.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webaudio/AudioWorklet.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp
[modify] https://crrev.com/64078ba4340c37a7d43de4db545a05279f2121f5/third_party/WebKit/Source/modules/webmidi/MIDIPort.h
Project Member

Comment 89 by bugdroid1@chromium.org, Dec 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c0c11f1d846c6c4207aba6a997dc323f5bb77f5

commit 2c0c11f1d846c6c4207aba6a997dc323f5bb77f5
Author: haraken <haraken@chromium.org>
Date: Tue Dec 27 04:34:38 2016

LocalDOMWindow::reset doesn't need to notify contextDestroyed()

contextDestroyed() should have already been called at Document::shutdown().
This CL adds a DCHECK to verify that contextDestroyed() has been already called
and remove notifyContextDestroyed.

BUG=610176

Review-Url: https://codereview.chromium.org/2605613002
Cr-Commit-Position: refs/heads/master@{#440731}

[modify] https://crrev.com/2c0c11f1d846c6c4207aba6a997dc323f5bb77f5/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
Project Member

Comment 90 by bugdroid1@chromium.org, Dec 27 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/84f686de38202c5f5b9bb7863a1caea1f659ed59

commit 84f686de38202c5f5b9bb7863a1caea1f659ed59
Author: haraken <haraken@chromium.org>
Date: Tue Dec 27 05:29:08 2016

Supplement should have a Member to the corresponding Supplementable object

Currently a lot of Supplement objects are observing ContextLifecycleObservers
because they cannot access the corresponding Supplementable object, which is silly.
This CL adds a strong reference from a Supplement object to the corresponding
Supplementable object. That way we can remove a bunch of ContextLifecycleObservers
from Supplement objects in follow-up CLs.

MSVC requires to include X.h when inheriting from Supplement<X>.
This CL adds the necessary include statements.

BUG=610176

Review-Url: https://codereview.chromium.org/2606643002
Cr-Commit-Position: refs/heads/master@{#440733}

[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/frame/Navigator.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/frame/NavigatorCPU.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/frame/NavigatorID.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/frame/NavigatorLanguage.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/frame/NavigatorOnLine.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/frame/Screen.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/timing/DOMWindowPerformance.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/timing/SharedWorkerPerformance.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/timing/WorkerGlobalScopePerformance.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/workers/WorkerClients.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/core/workers/WorkerNavigator.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/budget/NavigatorBudget.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/crypto/DOMWindowCrypto.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/mediastream/NavigatorUserMedia.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/nfc/NavigatorNFC.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/payments/HTMLIFrameElementPayments.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/permissions/NavigatorPermissions.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/plugins/NavigatorPlugins.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/remoteplayback/HTMLMediaElementRemotePlayback.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/screen_orientation/ScreenScreenOrientation.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/speech/DOMWindowSpeechSynthesis.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/storage/DOMWindowStorage.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/vibration/NavigatorVibration.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/vr/NavigatorVR.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/webshare/NavigatorShare.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/modules/webusb/NavigatorUSB.h
[modify] https://crrev.com/84f686de38202c5f5b9bb7863a1caea1f659ed59/third_party/WebKit/Source/platform/Supplementable.h
Project Member

Comment 91 by bugdroid1@chromium.org, Dec 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d

commit 46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d
Author: haraken <haraken@chromium.org>
Date: Wed Dec 28 02:25:31 2016

Prefer using ContextClient over ContextLifecycleObserver

ContextClient is more lightweight than ContextLifecycleObserver.
Classes that don't override contextDestroyed should use ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2607533002
Cr-Commit-Position: refs/heads/master@{#440822}

[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h
[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
Project Member

Comment 92 by bugdroid1@chromium.org, Dec 28 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ae3c143f1dfabd596e7db720ff85a0108f1c722

commit 6ae3c143f1dfabd596e7db720ff85a0108f1c722
Author: haraken <haraken@chromium.org>
Date: Wed Dec 28 05:36:15 2016

Remove ActiveDOMCallback

ActiveDOMCallback is just checking if the associated ExecutionContext
is suspended or detached. We can do the check using m_scriptState->getExecutionContext().
Then we can remove ActiveDOMCallback.

BUG=610176

Review-Url: https://codereview.chromium.org/2605683002
Cr-Commit-Position: refs/heads/master@{#440832}

[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/bindings.gni
[delete] https://crrev.com/906d30e05792314261846dfeeae38ff89888acf1/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.cpp
[delete] https://crrev.com/906d30e05792314261846dfeeae38ff89888acf1/third_party/WebKit/Source/bindings/core/v8/ActiveDOMCallback.h
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.cpp
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/core/v8/V8IntersectionObserverCallback.h
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.cpp
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/core/v8/V8MutationCallback.h
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/core/v8/V8ResizeObserverCallbackCustom.cpp
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/templates/callback_interface.cpp.tmpl
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/templates/callback_interface.h.tmpl
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.cpp
[modify] https://crrev.com/6ae3c143f1dfabd596e7db720ff85a0108f1c722/third_party/WebKit/Source/bindings/tests/results/core/V8TestCallbackInterface.h
Project Member

Comment 94 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fbd585f9e92926f179785e1a9394057fe254f10

commit 5fbd585f9e92926f179785e1a9394057fe254f10
Author: haraken <haraken@chromium.org>
Date: Thu Jan 05 17:40:42 2017

Remove ContextClient from NavigatorInstalledApp

Now that Navigator supplement can get the Navigator object via host(),
it doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2610783004
Cr-Commit-Position: refs/heads/master@{#441693}

[modify] https://crrev.com/5fbd585f9e92926f179785e1a9394057fe254f10/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp
[modify] https://crrev.com/5fbd585f9e92926f179785e1a9394057fe254f10/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.h
Project Member

Comment 95 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d5d32b6a54f1f483fb0342a4be35ab974684d63

commit 9d5d32b6a54f1f483fb0342a4be35ab974684d63
Author: haraken <haraken@chromium.org>
Date: Thu Jan 05 17:49:39 2017

Revert of Prefer using ContextClient over ContextLifecycleObserver (patchset #1 id:1 of https://codereview.chromium.org/2607533002/ )

Reason for revert:
This CL caused a flaky failure:

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_11__dbg_/6744/layout-test-results/storage/indexeddb/observer-workers-crash-log.txt

Original issue's description:
> Prefer using ContextClient over ContextLifecycleObserver
>
> ContextClient is more lightweight than ContextLifecycleObserver.
> Classes that don't override contextDestroyed should use ContextClient.
>
> BUG=610176
>
> Committed: https://crrev.com/46dcc19eebc7a63cee5b9aeb4e1284fd5f9adf6d
> Cr-Commit-Position: refs/heads/master@{#440822}

TBR=dcheng@chromium.org,sigbjornf@opera.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=610176

Review-Url: https://codereview.chromium.org/2618753002
Cr-Commit-Position: refs/heads/master@{#441696}

[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h
[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/9d5d32b6a54f1f483fb0342a4be35ab974684d63/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
Project Member

Comment 96 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ccc1dabf359da95ac44b4b012624dd6d2f53001

commit 8ccc1dabf359da95ac44b4b012624dd6d2f53001
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 02:21:10 2017

Remove ContextClient from NavigatorVR

Now that Navigator supplements can get the Navigator object via host(),
the supplements don't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2618713002
Cr-Commit-Position: refs/heads/master@{#441828}

[modify] https://crrev.com/8ccc1dabf359da95ac44b4b012624dd6d2f53001/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/8ccc1dabf359da95ac44b4b012624dd6d2f53001/third_party/WebKit/Source/modules/vr/NavigatorVR.h
Project Member

Comment 97 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e12c3a936186cf3d3f9e388ae2be6a484e40096e

commit e12c3a936186cf3d3f9e388ae2be6a484e40096e
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 06:29:50 2017

Remove ContextClient from NavigatorDoNotTrack

Now that Navigator's suppelemnt can access the Navigator object via host(),
it doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2615153002
Cr-Commit-Position: refs/heads/master@{#441890}

[modify] https://crrev.com/e12c3a936186cf3d3f9e388ae2be6a484e40096e/third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp
[modify] https://crrev.com/e12c3a936186cf3d3f9e388ae2be6a484e40096e/third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.h
Project Member

Comment 99 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b5d6d41bd50a323fd9e0cca5920548b34f6add6

commit 8b5d6d41bd50a323fd9e0cca5920548b34f6add6
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 06:33:41 2017

Remove ContextClient from NavigatorGeolocation

Now that Navigator's supplement can get a Navigator object via host().
Then Navigator's supplement doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2618773004
Cr-Commit-Position: refs/heads/master@{#441893}

[modify] https://crrev.com/8b5d6d41bd50a323fd9e0cca5920548b34f6add6/third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.cpp
[modify] https://crrev.com/8b5d6d41bd50a323fd9e0cca5920548b34f6add6/third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.h
Project Member

Comment 101 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/afe1dc47d88d3410018a27c812d8bbd6e3d1d859

commit afe1dc47d88d3410018a27c812d8bbd6e3d1d859
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 07:31:20 2017

Remove ContextClient from NavigatorStorageQuota

Now that Navigator's supplement can get a Navigator object via host().
Then Navigator's supplement doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2617583005
Cr-Commit-Position: refs/heads/master@{#441898}

[modify] https://crrev.com/afe1dc47d88d3410018a27c812d8bbd6e3d1d859/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.cpp
[modify] https://crrev.com/afe1dc47d88d3410018a27c812d8bbd6e3d1d859/third_party/WebKit/Source/modules/quota/NavigatorStorageQuota.h
Project Member

Comment 103 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c14e5b9c690bfdf0f1f5247a670960c94a5b36e

commit 1c14e5b9c690bfdf0f1f5247a670960c94a5b36e
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 08:00:05 2017

Remove ContextClient from DOMWindowStorage

Now that DOMWindowStorage can access DOMWindow with host(),
DOMWindowStorage doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2617703003
Cr-Commit-Position: refs/heads/master@{#441901}

[modify] https://crrev.com/1c14e5b9c690bfdf0f1f5247a670960c94a5b36e/third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp
[modify] https://crrev.com/1c14e5b9c690bfdf0f1f5247a670960c94a5b36e/third_party/WebKit/Source/modules/storage/DOMWindowStorage.h
Project Member

Comment 104 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21fd0270d8fcbf6f8941e1db8feeaa5cbcb97563

commit 21fd0270d8fcbf6f8941e1db8feeaa5cbcb97563
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 08:01:03 2017

Remove ContextClient from DOMWindowPerformance

Now that DOMWindowPerformance can access DOMWindow with host(),
DOMWindowPerformance doesn't need to observe ContextClient.

This CL removes DOMWindowPerformance::m_window.

BUG=610176

Review-Url: https://codereview.chromium.org/2615633011
Cr-Commit-Position: refs/heads/master@{#441902}

[modify] https://crrev.com/21fd0270d8fcbf6f8941e1db8feeaa5cbcb97563/third_party/WebKit/Source/core/timing/DOMWindowPerformance.cpp
[modify] https://crrev.com/21fd0270d8fcbf6f8941e1db8feeaa5cbcb97563/third_party/WebKit/Source/core/timing/DOMWindowPerformance.h
Project Member

Comment 105 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/110425bcd5ef3ea734625d084af49723990ae0c8

commit 110425bcd5ef3ea734625d084af49723990ae0c8
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 10:06:54 2017

Use a new Supplement constructor for Supplement<Document>

We're deprecating a default constructor of Supplement<>.
This CL moves Supplement<Document> to use a constructor that takes a Document parameter.

This enables to remove a couple of unnecessary m_document's.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2617103002
Cr-Commit-Position: refs/heads/master@{#441911}

[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/css/CSSTiming.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/css/CSSTiming.h
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/css/FontFaceSet.h
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/dom/CSSSelectorWatch.h
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/dom/DocumentParserTiming.h
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/paint/PaintTiming.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/paint/PaintTiming.h
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/xml/DocumentXPathEvaluator.h
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/xml/DocumentXSLT.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/core/xml/DocumentXSLT.h
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/modules/storage/DOMWindowStorageController.cpp
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/modules/storage/DOMWindowStorageController.h
[modify] https://crrev.com/110425bcd5ef3ea734625d084af49723990ae0c8/third_party/WebKit/Source/web/ContextFeaturesClientImpl.cpp
Project Member

Comment 106 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1

commit 7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 11:09:05 2017

Remove ContextClient from DOMWindowSpeechSynthesis

If we pass in ScriptState to DOMWindowSpeechSynthesis::speechSynthesis,
DOMWindowSpeechSynthesis doesn't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2618613006
Cr-Commit-Position: refs/heads/master@{#441918}

[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-boundary-events.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-cancel-twice.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-cancel.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-gc-utterance-crash.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-mock-no-crash.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-pause-resume.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-speak-invalid-argument-throws.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-speak-multiple.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-speak.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-basics.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-utterance-voice.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-voices-changed.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/LayoutTests/fast/speechsynthesis/speech-synthesis-voices.html
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/Source/modules/speech/DOMWindowSpeechSynthesis.cpp
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/Source/modules/speech/DOMWindowSpeechSynthesis.h
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/Source/modules/speech/WindowSpeechSynthesis.idl
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/Source/modules/speech/testing/InternalsSpeechSynthesis.cpp
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/Source/modules/speech/testing/InternalsSpeechSynthesis.h
[modify] https://crrev.com/7e483a01fa3b74f5dc5ecf16079bbf14f12e46a1/third_party/WebKit/Source/modules/speech/testing/InternalsSpeechSynthesis.idl
Project Member

Comment 109 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5d044bb4fef05b493693b2d548352bc025f08d46

commit 5d044bb4fef05b493693b2d548352bc025f08d46
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 12:18:20 2017

Remove ContextClient from NavigatorMIDI

It's not needed. ContextClient is used to detect if a frame is detached,
but we can check it with scriptState->contextIsValid().

BUG=610176

Review-Url: https://codereview.chromium.org/2614943003
Cr-Commit-Position: refs/heads/master@{#441924}

[modify] https://crrev.com/5d044bb4fef05b493693b2d548352bc025f08d46/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.cpp
[modify] https://crrev.com/5d044bb4fef05b493693b2d548352bc025f08d46/third_party/WebKit/Source/modules/webmidi/NavigatorWebMIDI.h
Project Member

Comment 110 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c5494ab0c4036e09b174ee9d425ba03465deb31

commit 4c5494ab0c4036e09b174ee9d425ba03465deb31
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 15:39:19 2017

Use a new Supplement constructor for LocalFrame's supplements

This is one of the steps to deprecate the default constructor of Supplement.

BUG=610176

Review-Url: https://codereview.chromium.org/2614143002
Cr-Commit-Position: refs/heads/master@{#441943}

[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/audio_output_devices/AudioOutputDeviceClient.h
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/filesystem/LocalFileSystem.h
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/indexeddb/IndexedDBClient.h
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/mediastream/UserMediaController.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/mediastream/UserMediaController.h
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/presentation/PresentationController.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/push_messaging/PushController.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/push_messaging/PushController.h
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/sensor/SensorProviderProxy.h
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.h
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/web/ChromeClientImpl.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/web/IndexedDBClientImpl.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/web/IndexedDBClientImpl.h
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp
[modify] https://crrev.com/4c5494ab0c4036e09b174ee9d425ba03465deb31/third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp
Project Member

Comment 111 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a7d691668d850776763dc437d808fadfb4b3154d

commit a7d691668d850776763dc437d808fadfb4b3154d
Author: haraken <haraken@chromium.org>
Date: Fri Jan 06 16:37:16 2017

Use a new Supplement construtor in PagePopupController

We're deprecating the default constructor of Supplement.

This CL also refactors PagePopupSupplement to make the implementation
closer to other supplement implementations.

BUG=610176

Review-Url: https://codereview.chromium.org/2617113003
Cr-Commit-Position: refs/heads/master@{#441949}

[modify] https://crrev.com/a7d691668d850776763dc437d808fadfb4b3154d/third_party/WebKit/Source/bindings/core/v8/V8PagePopupControllerBinding.cpp
[modify] https://crrev.com/a7d691668d850776763dc437d808fadfb4b3154d/third_party/WebKit/Source/core/page/PagePopupSupplement.cpp
[modify] https://crrev.com/a7d691668d850776763dc437d808fadfb4b3154d/third_party/WebKit/Source/core/page/PagePopupSupplement.h
Project Member

Comment 112 by bugdroid1@chromium.org, Jan 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6

commit eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6
Author: sigbjornf <sigbjornf@opera.com>
Date: Mon Jan 09 15:08:53 2017

Prefer ContextClient mixin over manual ExecutionContext handling.

The ContextClient mixin interface bundles up the safe handling of
references to ExecutionContexts. Prefer using it over keeping explicit
Member<ExecutionContext> references.

R=
BUG=610176

Review-Url: https://codereview.chromium.org/2622533002
Cr-Commit-Position: refs/heads/master@{#442250}

[modify] https://crrev.com/eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6/third_party/WebKit/Source/modules/mediasource/SourceBufferList.cpp
[modify] https://crrev.com/eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6/third_party/WebKit/Source/modules/mediasource/SourceBufferList.h
[modify] https://crrev.com/eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp
[modify] https://crrev.com/eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6/third_party/WebKit/Source/modules/mediastream/MediaStream.h
[modify] https://crrev.com/eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.cpp
[modify] https://crrev.com/eb00bf41cc3f3fb7cf68ab3ecce3bff4e52f5ff6/third_party/WebKit/Source/modules/presentation/PresentationConnectionList.h
Project Member

Comment 113 by bugdroid1@chromium.org, Jan 11 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cdf612491968c39e7d86847308e8a9225f19e7af

commit cdf612491968c39e7d86847308e8a9225f19e7af
Author: haraken <haraken@chromium.org>
Date: Wed Jan 11 11:54:20 2017

Remove ContextClient from NavigatorBeacon

Now that Navigator's Supplements can retrieve the Navigator object with host(),
those Supplements don't need to observe ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2611133002
Cr-Commit-Position: refs/heads/master@{#442873}

[modify] https://crrev.com/cdf612491968c39e7d86847308e8a9225f19e7af/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp
[modify] https://crrev.com/cdf612491968c39e7d86847308e8a9225f19e7af/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.h
[modify] https://crrev.com/cdf612491968c39e7d86847308e8a9225f19e7af/third_party/WebKit/Source/platform/Supplementable.h
Project Member

Comment 115 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a82bb82ae350134c763a8e995738fec5d4e2a061

commit a82bb82ae350134c763a8e995738fec5d4e2a061
Author: haraken <haraken@chromium.org>
Date: Thu Jan 12 12:54:48 2017

Introduce DOMWindowClient

The lifetime of ExecutionContext and DOMWindow is a bit different.
In common case, they get detached at the same timing but in a case where
a frame navigates from an initial empty document to another same-origin document,
the ExecutionContext gets detached but the DOMWindow is reused.
Due to the (subtle) difference, we need DOMWindowClient in addition to ContextClient.

ContextClient is a client for objects that want to observe ExecutionContext.
DOMWindowClient is a client for objects that want to observe DOMWindow.

This CL uses DOMWindowClient for Navigator.

BUG=610176

Review-Url: https://codereview.chromium.org/2629493004
Cr-Commit-Position: refs/heads/master@{#443216}

[modify] https://crrev.com/a82bb82ae350134c763a8e995738fec5d4e2a061/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.cpp
[modify] https://crrev.com/a82bb82ae350134c763a8e995738fec5d4e2a061/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
[modify] https://crrev.com/a82bb82ae350134c763a8e995738fec5d4e2a061/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/a82bb82ae350134c763a8e995738fec5d4e2a061/third_party/WebKit/Source/core/frame/Navigator.cpp
[modify] https://crrev.com/a82bb82ae350134c763a8e995738fec5d4e2a061/third_party/WebKit/Source/core/frame/Navigator.h
Project Member

Comment 117 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ee8b2c6aee296fd97c2064181aa77a240c98477

commit 2ee8b2c6aee296fd97c2064181aa77a240c98477
Author: haraken <haraken@chromium.org>
Date: Fri Jan 13 09:03:36 2017

Remove DOMWindowProperty from WindowPaintWorklet

WindowPaintWorklet doesn't need to inherit from DOMWindowProperty
since it can retrieve a window object via Supplement<>.

BUG=610176

Review-Url: https://codereview.chromium.org/2628323002
Cr-Commit-Position: refs/heads/master@{#443520}

[modify] https://crrev.com/2ee8b2c6aee296fd97c2064181aa77a240c98477/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp
[modify] https://crrev.com/2ee8b2c6aee296fd97c2064181aa77a240c98477/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.h
Project Member

Comment 118 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71d04138368832f6649c3ca85b4384dadde2c640

commit 71d04138368832f6649c3ca85b4384dadde2c640
Author: haraken <haraken@chromium.org>
Date: Fri Jan 13 10:36:45 2017

Rename Supplement::host() to Supplement::supplementable()

Supplement::host() is confusing with FrameHost since it's sometimes used
as host()->frame() etc. Hence this CL renames it to something clearer.

BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2630703002
Cr-Commit-Position: refs/heads/master@{#443528}

[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/core/paint/PaintTiming.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/core/timing/DOMWindowPerformance.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/modules/vr/NavigatorVR.cpp
[modify] https://crrev.com/71d04138368832f6649c3ca85b4384dadde2c640/third_party/WebKit/Source/platform/Supplementable.h
Project Member

Comment 120 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/989dace104cd4bc1aa304c9c30c54e6cff0d894d

commit 989dace104cd4bc1aa304c9c30c54e6cff0d894d
Author: haraken <haraken@chromium.org>
Date: Fri Jan 13 12:40:56 2017

Make ApplicationCache a DOMWindowClient

ApplicationCache is a per-DOMWindow thing instead of a per-ExecutionContext thing.
It should use DOMWindowClient instead of ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2631653002
Cr-Commit-Position: refs/heads/master@{#443541}

[modify] https://crrev.com/989dace104cd4bc1aa304c9c30c54e6cff0d894d/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.cpp
[modify] https://crrev.com/989dace104cd4bc1aa304c9c30c54e6cff0d894d/third_party/WebKit/Source/core/loader/appcache/ApplicationCache.h
[modify] https://crrev.com/989dace104cd4bc1aa304c9c30c54e6cff0d894d/third_party/WebKit/Source/core/loader/appcache/ApplicationCacheHost.cpp
Project Member

Comment 121 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a6201a8f53c7b297c93a8ea381263c5d52b2b687

commit a6201a8f53c7b297c93a8ea381263c5d52b2b687
Author: haraken <haraken@chromium.org>
Date: Fri Jan 13 18:06:22 2017

Disambiguate LifecycleObserver::contextDestroyed

Some objects inherit from multiple lifecycle observers
(e.g., ContextLifecycleObserver and PageLifecycleObserver).
Then the same method contextDestroyed() is called multiple times
when ExecutionContext gets detached *and* when Page gets detached.
This is really confusing.

To disambiguate the situation, this CL introduces a Context* parameter
to contextDestroyed(); e.g., contextDestroyed(ExecutionContext*),
contextDestroyed(Page*), contextDestroyed(WorkerThreadLifecycleContext*) etc.

(In this CL, the Context* parameter is used only to disambiguate contextDestroyed(),
but the parameter will be acutally used in a follow-up CL, where I'm planning to
clear out LifecycleObserver::m_lifecycleContext before calling contextDestroyed().)

BUG=610176

Review-Url: https://codereview.chromium.org/2629593004
Cr-Commit-Position: refs/heads/master@{#443607}

[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/bindings/core/v8/ScriptPromiseResolver.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/animation/Animation.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/animation/Animation.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/css/FontFaceSet.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/css/FontFaceSet.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/css/MediaQueryList.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/css/MediaQueryList.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/css/MediaQueryListTest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/DocumentTest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/Fullscreen.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/Fullscreen.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/MessagePort.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/SuspendableObject.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/SuspendableObject.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/dom/SuspendableObjectTest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/editing/InputMethodController.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/editing/InputMethodController.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/editing/SelectionController.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/editing/SelectionController.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/fileapi/FileReader.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/frame/DOMTimer.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/frame/DOMTimer.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/frame/SuspendableTimer.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/frame/SuspendableTimer.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/html/AutoplayUmaHelper.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/html/HTMLMediaElement.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/html/PublicURLManager.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/html/PublicURLManager.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/loader/PrerenderHandle.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/loader/PrerenderHandle.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/loader/WorkerThreadableLoader.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/streams/Stream.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/streams/Stream.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/streams/UnderlyingSourceBase.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/timing/Performance.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/timing/Performance.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/DedicatedWorkerTest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/InProcessWorkerBase.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/InProcessWorkerBase.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/ParentFrameTaskRunners.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/Worklet.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/workers/Worklet.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/battery/BatteryManager.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/broadcastchannel/BroadcastChannel.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/compositorworker/WindowAnimationWorklet.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/encryptedmedia/MediaKeySession.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/encryptedmedia/MediaKeys.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/eventsource/EventSource.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/eventsource/EventSource.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/fetch/BlobBytesConsumer.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/fetch/FetchManager.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/fetch/FetchManager.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/filesystem/FileWriter.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/filesystem/FileWriter.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/geolocation/Geolocation.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/imagecapture/ImageCapture.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/imagecapture/ImageCapture.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/indexeddb/IDBDatabase.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/indexeddb/IDBOpenDBRequest.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/indexeddb/IDBRequest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/indexeddb/IDBRequest.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/installedapp/InstalledAppController.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/installedapp/InstalledAppController.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediasource/MediaSource.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediasource/MediaSource.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediasource/SourceBuffer.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediasource/SourceBuffer.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediastream/MediaDevices.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediastream/MediaDevices.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/mediastream/UserMediaRequest.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/netinfo/NetworkInformation.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/nfc/NFC.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/notifications/Notification.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/notifications/Notification.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/payments/PaymentRequest.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/payments/PaymentRequest.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCDTMFSender.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCDataChannel.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCSessionDescriptionRequestImpl.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCStatsRequestImpl.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/permissions/PermissionStatus.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/permissions/PermissionStatus.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/presentation/PresentationController.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/presentation/PresentationController.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/sensor/Sensor.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/sensor/Sensor.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/serviceworkers/RespondWithObserver.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerRegistration.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/speech/SpeechRecognition.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/vibration/NavigatorVibration.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/vibration/VibrationController.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/vr/VRController.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/vr/VRController.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/vr/VRDisplay.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/vr/VRDisplay.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webaudio/BaseAudioContext.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webaudio/WindowAudioWorklet.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webdatabase/DatabaseContext.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webmidi/MIDIAccess.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webmidi/MIDIAccess.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webmidi/MIDIAccessInitializer.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webmidi/MIDIPort.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webmidi/MIDIPort.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/websockets/DOMWebSocket.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.cpp
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/websockets/WorkerWebSocketChannel.h
[modify] https://crrev.com/a6201a8f53c7b297c93a8ea381263c5d52b2b687/third_party/WebKit/Source/modules/webusb/USB.cpp
[modi
Project Member

Comment 122 by bugdroid1@chromium.org, Jan 15 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65dfcc360fbc88445210a0e99aae7af6a8a5ac67

commit 65dfcc360fbc88445210a0e99aae7af6a8a5ac67
Author: sigbjornf <sigbjornf@opera.com>
Date: Sun Jan 15 15:34:44 2017

Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty
PageVisibilityObserver::contextDestroyed() overrides.

R=haraken
BUG=610176

Review-Url: https://codereview.chromium.org/2634713002
Cr-Commit-Position: refs/heads/master@{#443816}

[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/core/dom/ContextLifecycleObserver.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/core/dom/SynchronousMutationObserver.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/core/html/HTMLCanvasElement.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/core/html/HTMLCanvasElement.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/core/workers/WorkerThreadLifecycleObserver.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/battery/BatteryManager.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/battery/BatteryManager.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/geolocation/Geolocation.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/geolocation/Geolocation.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/nfc/NFC.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/nfc/NFC.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/presentation/PresentationAvailability.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationControllerImpl.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/vibration/VibrationController.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/vibration/VibrationController.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/modules/wake_lock/ScreenWakeLock.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/platform/LifecycleContextTest.cpp
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/platform/LifecycleNotifier.h
[modify] https://crrev.com/65dfcc360fbc88445210a0e99aae7af6a8a5ac67/third_party/WebKit/Source/platform/LifecycleObserver.h
Project Member

Comment 124 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/92d389ae2826a4936b6dd6cf1ea69227c8068c6b

commit 92d389ae2826a4936b6dd6cf1ea69227c8068c6b
Author: haraken <haraken@chromium.org>
Date: Mon Jan 23 10:41:06 2017

Use a new Supplement constructor for (Worker)Navigator supplements

This CL is a step to deprecate the default constructor of Supplement<>.

BUG=610176

Review-Url: https://codereview.chromium.org/2646383002
Cr-Commit-Position: refs/heads/master@{#445350}

[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/battery/NavigatorBattery.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/battery/NavigatorBattery.h
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/bluetooth/NavigatorBluetooth.h
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/budget/NavigatorBudget.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/budget/NavigatorBudget.h
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/budget/WorkerNavigatorBudget.h
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/gamepad/NavigatorGamepad.h
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/mediasession/NavigatorMediaSession.h
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/mediastream/NavigatorUserMedia.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/mediastream/NavigatorUserMedia.h
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/netinfo/WorkerNavigatorNetworkInformation.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/nfc/NavigatorNFC.cpp
[modify] https://crrev.com/92d389ae2826a4936b6dd6cf1ea69227c8068c6b/third_party/WebKit/Source/modules/nfc/NavigatorNFC.h
Project Member

Comment 125 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27e8f95e0a38ac53e85175b84a158da06da32eb0

commit 27e8f95e0a38ac53e85175b84a158da06da32eb0
Author: haraken <haraken@chromium.org>
Date: Mon Jan 23 12:32:54 2017

Use a new Supplement constructor for supplements in core/

This is a step to deprecate the default Supplement constructor.

BUG=610176

Review-Url: https://codereview.chromium.org/2645303002
Cr-Commit-Position: refs/heads/master@{#445363}

[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/fileapi/FileReader.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/html/parser/HTMLDocumentParserTest.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/loader/PrerendererClient.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/loader/PrerendererClient.h
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/origin_trials/OriginTrialContextTest.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/testing/InternalSettings.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/testing/InternalSettings.h
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/timing/SharedWorkerPerformance.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/timing/SharedWorkerPerformance.h
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/timing/WorkerGlobalScopePerformance.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/timing/WorkerGlobalScopePerformance.h
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/core/workers/DedicatedWorkerMessagingProxyProvider.h
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/web/DedicatedWorkerMessagingProxyProviderImpl.h
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/web/PrerendererClientImpl.cpp
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/web/PrerendererClientImpl.h
[modify] https://crrev.com/27e8f95e0a38ac53e85175b84a158da06da32eb0/third_party/WebKit/Source/web/WebViewImpl.cpp
Project Member

Comment 126 by bugdroid1@chromium.org, Jan 23 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cf7b58737b355ece16d0511aa43c95d6d11d0445

commit cf7b58737b355ece16d0511aa43c95d6d11d0445
Author: waffles <waffles@chromium.org>
Date: Mon Jan 23 18:33:47 2017

Revert of Use a new Supplement constructor in Navigator supplements (part 2) (patchset #3 id:40001 of https://codereview.chromium.org/2649073002/ )

Reason for revert:
Manual bisection shows that the following regressions occur starting at 560d55d7d:

Regressions: Unexpected leaks (6)
  fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html [ Leak ]
  fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html [ Leak ]
  fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html [ Leak ]
  fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html [ Leak ]
  fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html [ Leak ]
  fast/dom/Window/property-access-on-cached-window-after-frame-removed.html [ Leak ]

The leaked object is {"numberOfLiveSuspendableObjects":[2,3]}

Original issue's description:
> Use a new Supplement constructor in Navigator supplements (part 2)
>
> This is a step to deprecate the default constructor of Supplement<>.
>
> BUG=610176
>
> Review-Url: https://codereview.chromium.org/2649073002
> Cr-Commit-Position: refs/heads/master@{#445357}
> Committed: https://chromium.googlesource.com/chromium/src/+/560d55d7d2122116b456e157f761eaa252246e4f

TBR=sigbjornf@opera.com,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176

Review-Url: https://codereview.chromium.org/2655463002
Cr-Commit-Position: refs/heads/master@{#445415}

[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/permissions/NavigatorPermissions.cpp
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/permissions/NavigatorPermissions.h
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.cpp
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/permissions/WorkerNavigatorPermissions.h
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/presentation/NavigatorPresentation.cpp
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/presentation/NavigatorPresentation.h
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.cpp
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/quota/WorkerNavigatorStorageQuota.h
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/webauth/NavigatorAuth.cpp
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/webshare/NavigatorShare.cpp
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/webshare/NavigatorShare.h
[modify] https://crrev.com/cf7b58737b355ece16d0511aa43c95d6d11d0445/third_party/WebKit/Source/modules/webusb/NavigatorUSB.cpp
Project Member

Comment 127 by bugdroid1@chromium.org, Feb 7 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73d601815cebdd38fc5248d62ed884477c9e0972

commit 73d601815cebdd38fc5248d62ed884477c9e0972
Author: haraken <haraken@chromium.org>
Date: Tue Feb 07 10:28:25 2017

Use a new Supplement constructor for ServiceWorkerRegistration supplements

This is a step to deprecate the default constructor of Supplement<>.
Also this CL removes Member<ServiceWorkerRegistration>.

BUG=610176

Review-Url: https://codereview.chromium.org/2651613002
Cr-Commit-Position: refs/heads/master@{#448582}

[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.cpp
[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.h
[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h
[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.cpp
[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.h
[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp
[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h
[modify] https://crrev.com/73d601815cebdd38fc5248d62ed884477c9e0972/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
Project Member

Comment 128 by bugdroid1@chromium.org, Feb 8 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/989cdc24a5db94cc5e58edee85293528a852726b

commit 989cdc24a5db94cc5e58edee85293528a852726b
Author: shimazu <shimazu@chromium.org>
Date: Wed Feb 08 05:09:21 2017

Revert of Use a new Supplement constructor for ServiceWorkerRegistration supplements (patchset #2 id:20001 of https://codereview.chromium.org/2651613002/ )

Reason for revert:
This seems causing test failures on Leak bot:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20Leak/builds/2077

6 tests failed:
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html ( Code Search )
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html ( Code Search )
fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html ( Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html ( Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced.html ( Code Search )
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html ( Code Search )

Original issue's description:
> Use a new Supplement constructor for ServiceWorkerRegistration supplements
>
> This is a step to deprecate the default constructor of Supplement<>.
> Also this CL removes Member<ServiceWorkerRegistration>.
>
> BUG=610176
>
> Review-Url: https://codereview.chromium.org/2651613002
> Cr-Commit-Position: refs/heads/master@{#448582}
> Committed: https://chromium.googlesource.com/chromium/src/+/73d601815cebdd38fc5248d62ed884477c9e0972

TBR=sigbjornf@opera.com,haraken@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=610176

Review-Url: https://codereview.chromium.org/2686613004
Cr-Commit-Position: refs/heads/master@{#448910}

[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.cpp
[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/background_sync/ServiceWorkerRegistrationSync.h
[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp
[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/notifications/ServiceWorkerRegistrationNotifications.h
[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.cpp
[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/payments/PaymentAppServiceWorkerRegistration.h
[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.cpp
[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/push_messaging/ServiceWorkerRegistrationPush.h
[modify] https://crrev.com/989cdc24a5db94cc5e58edee85293528a852726b/third_party/WebKit/Source/modules/serviceworkers/NavigatorServiceWorker.cpp
Project Member

Comment 129 by bugdroid1@chromium.org, Feb 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/78c60265e580b80470359beeede8e05dd908852d

commit 78c60265e580b80470359beeede8e05dd908852d
Author: sigbjornf <sigbjornf@opera.com>
Date: Tue Feb 28 12:19:56 2017

Convert unnecessary ContextLifecycleObservers into ContextClients.

Convert remaining types that do not make use of |contextDestroyed()|
overriding, making them be context clients instead.

R=dcheng,haraken
BUG=610176

Review-Url: https://codereview.chromium.org/2721603005
Cr-Commit-Position: refs/heads/master@{#453574}

[modify] https://crrev.com/78c60265e580b80470359beeede8e05dd908852d/third_party/WebKit/Source/core/css/FontFace.cpp
[modify] https://crrev.com/78c60265e580b80470359beeede8e05dd908852d/third_party/WebKit/Source/core/css/FontFace.h
[modify] https://crrev.com/78c60265e580b80470359beeede8e05dd908852d/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp
[modify] https://crrev.com/78c60265e580b80470359beeede8e05dd908852d/third_party/WebKit/Source/modules/filesystem/DOMFileSystem.h
[modify] https://crrev.com/78c60265e580b80470359beeede8e05dd908852d/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.cpp
[modify] https://crrev.com/78c60265e580b80470359beeede8e05dd908852d/third_party/WebKit/Source/modules/indexeddb/IDBTransaction.h
[modify] https://crrev.com/78c60265e580b80470359beeede8e05dd908852d/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/78c60265e580b80470359beeede8e05dd908852d/third_party/WebKit/Source/modules/presentation/PresentationRequest.h
Showing comments 30 - 129 of 129 Older ›
►

Sign in to add a comment