New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610173 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 610167



Sign in to add a comment

Typed CSSOM: rename Matrix to CSSMatrix

Project Member Reported by rjwright@chromium.org, May 9 2016

Issue description

Matrix => CSSMatrix
MatrixTransformComponent => CSSMatrixTransformComponent

 
Blocking: 610167
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d46e5ff03b228e16af40761b0f0e1cd530828bbd

commit d46e5ff03b228e16af40761b0f0e1cd530828bbd
Author: rjwright <rjwright@chromium.org>
Date: Tue Jun 07 00:14:47 2016

Typed CSSOM: Rename Matrix to CSSMatrix and MatrixTransformComponent to CSSMatrixTransformComponent.

I didn't rename MatrixTranformComponent to CSSMatrix because WebKitCSSMatrix is implemented as CSSMatrix.

Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#cssmatrix

Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159

BUG= 610173 

Review-Url: https://codereview.chromium.org/2038453002
Cr-Commit-Position: refs/heads/master@{#398165}

[rename] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/LayoutTests/typedcssom/cssMatrix.html
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/LayoutTests/typedcssom/cssRotation.html
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/LayoutTests/typedcssom/cssScale.html
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/LayoutTests/typedcssom/cssSkew.html
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/LayoutTests/typedcssom/transformValue.html
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/core.gypi
[rename] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/CSSMatrix.idl
[add] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/CSSMatrixTransformComponent.cpp
[rename] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/CSSMatrixTransformComponent.h
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/CSSPerspective.h
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/CSSRotation.h
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/CSSScale.h
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/CSSSkew.h
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
[delete] https://crrev.com/b1397393e86c33739d2e3e484acb7e4e4bc9a871/third_party/WebKit/Source/core/css/cssom/MatrixTransformComponent.cpp
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/TransformComponent.h
[modify] https://crrev.com/d46e5ff03b228e16af40761b0f0e1cd530828bbd/third_party/WebKit/Source/core/css/cssom/TransformComponent.idl

Status: Fixed (was: Assigned)

Sign in to add a comment