New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 610159



Sign in to add a comment

Typed CSSOM prefix LengthValue & subclasses with "CSS"

Project Member Reported by rjwright@chromium.org, May 9 2016

Issue description

LengthValue => CSSLengthValue
SimpleLength => CSSSimpleLength
CalcLength => CSSCalcLength
 
Blocking: 610159
Project Member

Comment 3 by bugdroid1@chromium.org, May 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b21886cc3dd317e34617de9faead0c330af7a89

commit 0b21886cc3dd317e34617de9faead0c330af7a89
Author: rjwright <rjwright@chromium.org>
Date: Thu May 19 07:16:33 2016

Typed CSSOM: Rename LengthValue to CSSLengthValue

This CL (along with 2 future ones) will replace https://codereview.chromium.org/1949343002/, which was very large and too hard to rebase after related file renames.

Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159

BUG= 610161 

Review-Url: https://codereview.chromium.org/1997503003
Cr-Commit-Position: refs/heads/master@{#394704}

[add] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/LayoutTests/typedcssom/cssLengthValue.html
[delete] https://crrev.com/a03a8222f007795f7a96b4e2c5fa4ea8f09fb7bb/third_party/WebKit/LayoutTests/typedcssom/lengthValue.html
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/LayoutTests/typedcssom/perspectiveTransformComponent.html
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/build/scripts/templates/CSSOMTypes.cpp.tmpl
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/core.gypi
[add] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp
[add] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.h
[add] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.idl
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSPositionValue.cpp
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSPositionValue.h
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSPositionValue.idl
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSTranslation.cpp
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSTranslation.h
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CSSTranslation.idl
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/CalcLength.idl
[delete] https://crrev.com/a03a8222f007795f7a96b4e2c5fa4ea8f09fb7bb/third_party/WebKit/Source/core/css/cssom/LengthValue.cpp
[delete] https://crrev.com/a03a8222f007795f7a96b4e2c5fa4ea8f09fb7bb/third_party/WebKit/Source/core/css/cssom/LengthValue.h
[delete] https://crrev.com/a03a8222f007795f7a96b4e2c5fa4ea8f09fb7bb/third_party/WebKit/Source/core/css/cssom/LengthValue.idl
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/Perspective.idl
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.cpp
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/PerspectiveTransformComponent.h
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/SimpleLength.cpp
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/SimpleLength.h
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/SimpleLength.idl
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/StyleCalcLength.cpp
[modify] https://crrev.com/0b21886cc3dd317e34617de9faead0c330af7a89/third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h

Project Member

Comment 4 by bugdroid1@chromium.org, May 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6fae15852d4e5bca5df304650030a3d95aa9f07a

commit 6fae15852d4e5bca5df304650030a3d95aa9f07a
Author: rjwright <rjwright@chromium.org>
Date: Wed May 25 03:28:48 2016

Typed CSSOM: Rename SimpleLength to CSSSimpleLength

This CL (along with https://codereview.chromium.org/1997503003/ and one future one) will replace https://codereview.chromium.org/1949343002/, which was very large and too hard to rebase after related file renames.

Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159

BUG= 610161 

Review-Url: https://codereview.chromium.org/2005683002
Cr-Commit-Position: refs/heads/master@{#395794}

[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/cssLengthValue.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/cssPositionValue.html
[add] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/cssSimpleLength.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_append.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_delete.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getAll.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_getProperties.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/inlineStylePropertyMap_setGet.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/perspectiveTransformComponent.html
[delete] https://crrev.com/12f6770567a7345e8f820c05e7005a512b1d6230/third_party/WebKit/LayoutTests/typedcssom/simpleLength.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/typedcssom/styleValue-parse-basic.html
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/core.gypi
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp
[rename] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.cpp
[rename] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.h
[rename] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.idl
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/InlineStylePropertyMap.cpp
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/StyleCalcLength.cpp
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/StyleCalcLength.h
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp
[modify] https://crrev.com/6fae15852d4e5bca5df304650030a3d95aa9f07a/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp

Project Member

Comment 5 by bugdroid1@chromium.org, May 27 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cfe256fcc559fe384e732b6887855501d5d2081

commit 8cfe256fcc559fe384e732b6887855501d5d2081
Author: rjwright <rjwright@chromium.org>
Date: Fri May 27 06:25:39 2016

Typed CSSOM: Rename CalcLength and StyleCalcLength to CSSCalcLength

This CL (along with https://codereview.chromium.org/1997503003/ and https://codereview.chromium.org/2005683002/) replace https://codereview.chromium.org/1949343002/.

Changes in line with changes to the spec: https://drafts.css-houdini.org/css-typed-om-1/#lengthvalue-objects

Tracking bug: https://bugs.chromium.org/p/chromium/issues/detail?id=610159

BUG= 610161 

Review-Url: https://codereview.chromium.org/2011833002
Cr-Commit-Position: refs/heads/master@{#396407}

[delete] https://crrev.com/01e900462dc9584943bca258bf2543005afc1fa2/third_party/WebKit/LayoutTests/typedcssom/calcLength.html
[add] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/LayoutTests/typedcssom/cssCalcLength.html
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/LayoutTests/typedcssom/cssLengthValue.html
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/LayoutTests/typedcssom/cssPositionValue.html
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/LayoutTests/typedcssom/cssSimpleLength.html
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/LayoutTests/typedcssom/cssTranslation.html
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/LayoutTests/typedcssom/perspectiveTransformComponent.html
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/Source/core/core.gypi
[rename] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.cpp
[rename] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.h
[rename] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/Source/core/css/cssom/CSSCalcLength.idl
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/Source/core/css/cssom/CSSLengthValue.cpp
[modify] https://crrev.com/8cfe256fcc559fe384e732b6887855501d5d2081/third_party/WebKit/Source/core/css/cssom/CSSSimpleLength.cpp

Status: Fixed (was: Started)

Sign in to add a comment