Figure out what tapping the "gear icon" in WebAPK notification should do |
|||||
Issue descriptionNotifications have two gear icons: one on the front and one on the back (notification flips when user long presses on the notification) Currently non-WebAPK notifications - Have the gear at the front. Tapping on the gear opens site settings - Have the gear at the back. Tapping on the gear opens site settings Currently WebAPK notifications - Have the gear in the front. Tapping on the gear opens Chrome site settings - Do not have the gear at the back I am not sure if this is the desired behavior
,
Jun 30 2016
,
Jul 18 2016
,
Jul 20 2016
This behavior SGTM. If we can add a gear to the back I think that would be better from a consistency perspective (and ensure that it's an option if we ever change the buttons shown on the front.)
,
Jul 20 2016
,
Jul 21 2016
So the system only shows the gear icon if you have an activity with the intent filter as in https://codereview.chromium.org/2169743002/ ?
,
Jul 21 2016
#6: The activity with the intent filter is necessary for the gear icon to show
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/349039d03080d2ebc81f5e136d64804e99b43d49 commit 349039d03080d2ebc81f5e136d64804e99b43d49 Author: pkotwicz <pkotwicz@chromium.org> Date: Mon Jul 25 23:33:09 2016 Makes WebAPK handle NOTIFICATION_PREFERENCES intents This CL makes WebAPK handle NOTIFICATION_PREFERENCES intents. The intent is forwarded to the host browser. A NOTIFICATION_PREFERENCES intent is sent when the user long presses on a notification on L+ and taps on the "gear icon". BUG= 610156 Review-Url: https://codereview.chromium.org/2169743002 Cr-Commit-Position: refs/heads/master@{#407631} [modify] https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49/chrome/android/webapk/shell_apk/AndroidManifest.xml [modify] https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49/chrome/android/webapk/shell_apk/BUILD.gn [add] https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/NotificationSettingsLauncherActivity.java
,
Jul 25 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/349039d03080d2ebc81f5e136d64804e99b43d49 commit 349039d03080d2ebc81f5e136d64804e99b43d49 Author: pkotwicz <pkotwicz@chromium.org> Date: Mon Jul 25 23:33:09 2016 Makes WebAPK handle NOTIFICATION_PREFERENCES intents This CL makes WebAPK handle NOTIFICATION_PREFERENCES intents. The intent is forwarded to the host browser. A NOTIFICATION_PREFERENCES intent is sent when the user long presses on a notification on L+ and taps on the "gear icon". BUG= 610156 Review-Url: https://codereview.chromium.org/2169743002 Cr-Commit-Position: refs/heads/master@{#407631} [modify] https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49/chrome/android/webapk/shell_apk/AndroidManifest.xml [modify] https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49/chrome/android/webapk/shell_apk/BUILD.gn [add] https://crrev.com/349039d03080d2ebc81f5e136d64804e99b43d49/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/NotificationSettingsLauncherActivity.java
,
Jul 26 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by pkotw...@chromium.org
, Jun 29 2016