New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 610153 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug

Blocking:
issue 429053



Sign in to add a comment

TEXTURE_MAX/BASE_LEVEL is incorrectly clamped to 16-bit integer on MacOSX

Project Member Reported by zmo@chromium.org, May 8 2016

Issue description

GetTexParameter returns negative values if these two params are set to values beyond 16-bit.

Need to verify how rendering is affected by this.
 
Cc: cwallez@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, May 31 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6c2262abe85a3b1f03bf849ca670be2e505d34ec

commit 6c2262abe85a3b1f03bf849ca670be2e505d34ec
Author: cwallez <cwallez@chromium.org>
Date: Tue May 31 18:12:30 2016

command_buffer: MAX/BASE_LEVEL fixes for GetTexParameter

This fixes two bugs for GetTexParameter:
 - It seems the OSX OpenGL driver stores the levels on int16_t causing
   the large values used by some tests to overflow and return as
   negative numbers. This is fixed by getting the values from the
   command buffer state tracking.
 - This exposed a bug in the state tracking where the base / max levels
   weren't rounded correctly when specified as floats.

BUG= 483282 
BUG= 610153 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2019453003
Cr-Commit-Position: refs/heads/master@{#396864}

[modify] https://crrev.com/6c2262abe85a3b1f03bf849ca670be2e505d34ec/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/6c2262abe85a3b1f03bf849ca670be2e505d34ec/gpu/command_buffer/service/gles2_cmd_decoder.cc
[modify] https://crrev.com/6c2262abe85a3b1f03bf849ca670be2e505d34ec/gpu/command_buffer/service/texture_manager.cc
[modify] https://crrev.com/6c2262abe85a3b1f03bf849ca670be2e505d34ec/gpu/config/gpu_driver_bug_list_json.cc
[modify] https://crrev.com/6c2262abe85a3b1f03bf849ca670be2e505d34ec/gpu/config/gpu_driver_bug_workaround_type.h

Comment 3 by zmo@chromium.org, Jun 15 2016

Cc: -cwallez@chromium.org
Owner: cwallez@chromium.org
Status: Fixed (was: Untriaged)

Comment 4 by kbr@chromium.org, Sep 10 2016

For clarification, the test that was failing because of this bug was:
https://www.khronos.org/registry/webgl/sdk/tests/deqp/functional/gles3/texturestatequery.html

and the driver bug workaround can be disabled, exposing the underlying bug, by passing the command line argument:
--use_shadowed_tex_level_params=0

Comment 5 by kbr@chromium.org, Sep 10 2016

Filed as Radar 28236705.

Comment 6 by zmo@chromium.org, Dec 20 2016

Owner: zmo@chromium.org
Status: Assigned (was: Fixed)
The Apple driver bug is fixed in 10.12.2 (16C67).

We can turn off the workaround there.

Comment 7 by zmo@chromium.org, Dec 20 2016

FYI: I resolved the radar.
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 22 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2347b6c10bbe0810aa8eb3ceb8bf583ff74a9dd8

commit 2347b6c10bbe0810aa8eb3ceb8bf583ff74a9dd8
Author: zmo <zmo@chromium.org>
Date: Thu Dec 22 02:47:07 2016

Lift texture's MAX_LEVEL/BASE_LEVEL workaround on OSX 10.12.2+ with AMD GPU.

The driver has been fixed in 10.12.2

BUG= 610153 
TEST=
TBR=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2594253002
Cr-Commit-Position: refs/heads/master@{#440319}

[modify] https://crrev.com/2347b6c10bbe0810aa8eb3ceb8bf583ff74a9dd8/gpu/config/gpu_driver_bug_list_json.cc

Comment 9 by zmo@chromium.org, Dec 22 2016

Status: Fixed (was: Assigned)
Components: -Internals>GPU>WebGL Blink>WebGL

Sign in to add a comment