New issue
Advanced search Search tips

Issue 610147 link

Starred by 1 user
Status: Fixed
Owner:
juncai@chromium.org
Closed: May 2016
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Add FormatUrlForSecurityDisplay which takes a const url::Origin& origin

Project Member Reported by juncai@chromium.org, May 8 2016 
The chooser bubble's title needs to show the origin. There is a FormatUrlForSecurityDisplay which takes a const GURL& origin. It is better to add a FormatUrlForSecurityDisplay which takes a const url::Origin& origin.
Project Member

Comment 1 by bugdroid1@chromium.org, May 13 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb63cac018227ec356e3d58e3c78e26761e76f26

commit cb63cac018227ec356e3d58e3c78e26761e76f26
Author: juncai <juncai@chromium.org>
Date: Fri May 13 00:41:59 2016

Add FormatUrlForSecurityDisplay which takes a const url::Origin& origin

There is a FormatUrlForSecurityDisplay which takes a const GURL&.
It is better to add a FormatUrlForSecurityDisplay which takes a
const url::Origin&.

BUG= 610147 

Review-Url: https://codereview.chromium.org/1959933002
Cr-Commit-Position: refs/heads/master@{#393410}

[modify] https://crrev.com/cb63cac018227ec356e3d58e3c78e26761e76f26/components/url_formatter/elide_url.cc
[modify] https://crrev.com/cb63cac018227ec356e3d58e3c78e26761e76f26/components/url_formatter/elide_url.h
[modify] https://crrev.com/cb63cac018227ec356e3d58e3c78e26761e76f26/components/url_formatter/elide_url_unittest.cc

Comment 2 by juncai@chromium.org, May 20 2016

Status: Fixed (was: Started)
►

Sign in to add a comment