Trying to send a Tune Request MIDI message yields "Message is incomplete" error
Reported by
cote...@gmail.com,
May 8 2016
|
||||
Issue description
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/50.0.2661.94 Safari/537.36
Steps to reproduce the problem:
if (navigator.requestMIDIAccess) {
navigator.requestMIDIAccess().then(onSuccess, onFailure);
} else {
console.log("Web MIDI API not supported!");
}
function onSuccess(midiAccess) {
var outputs = [];
var iter = midiAccess.outputs.values();
for (var i = iter.next(); i && !i.done; i = iter.next()) {
outputs.push(i.value);
}
outputs[0].send([0xF6]); // tuning request
}
function onFailure(error) {
console.log("Could not connect to the MIDI interface");
}
What is the expected behavior?
Should work.
What went wrong?
The tune request MIDI message (0xF6) does not need any data bytes. Output.send([0xF6]) should work instead of throwing "Message is incomplete" error.
Did this work before? N/A
Chrome version: 50.0.2661.94 Channel: stable
OS Version: OS X 10.11.4
Flash Version: Shockwave Flash 21.0 r0
,
May 9 2016
Confirmed. This is a bug that I overlooked for a long time. Thank you for reporting this.
,
May 10 2016
,
May 12 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/34b2ef7758db06aedf73e707d591292e61eee7c9 commit 34b2ef7758db06aedf73e707d591292e61eee7c9 Author: toyoshim <toyoshim@chromium.org> Date: Thu May 12 05:37:00 2016 Web MIDI: Tune Request [0xf6] wasn't handled correctly. Tune Request is one of System Common Messages, but is a special because only this message type has no data. This message wasn't handled correctly before this change. BUG= 610116 Review-Url: https://codereview.chromium.org/1963063002 Cr-Commit-Position: refs/heads/master@{#393192} [modify] https://crrev.com/34b2ef7758db06aedf73e707d591292e61eee7c9/third_party/WebKit/LayoutTests/webmidi/send-messages.html [add] https://crrev.com/34b2ef7758db06aedf73e707d591292e61eee7c9/third_party/WebKit/LayoutTests/webmidi/send-system-messages-expected.txt [add] https://crrev.com/34b2ef7758db06aedf73e707d591292e61eee7c9/third_party/WebKit/LayoutTests/webmidi/send-system-messages.html [modify] https://crrev.com/34b2ef7758db06aedf73e707d591292e61eee7c9/third_party/WebKit/Source/modules/webmidi/MIDIOutput.cpp
,
May 12 2016
Now the issue should be fixed in trunk. This will appear in Canary in a few days, and be fixed in Chrome 52.
,
May 18 2016
Cool, thanks! |
||||
►
Sign in to add a comment |
||||
Comment 1 by ajha@chromium.org
, May 9 2016Components: Blink>WebMIDI
Labels: Needs-Feedback