Implement diff markers in gutter of UISourceCode in Sources panel.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ecff28a9f64c5657409fc62bfda4ed5c328581e3 commit ecff28a9f64c5657409fc62bfda4ed5c328581e3 Author: lushnikov <lushnikov@chromium.org> Date: Tue May 10 01:32:33 2016 DevTools: simplify NetworkProject.addFileForURL method The first "url" parameter of NetworkProject.addFileForURL method is not needed - contentProvider already have associated URL. As the "url" parameter goes away, this patch also renames addFileForURL(url, contentProvider, frame) into addFile(contentProvider, frame). BUG= 610061 R=pfeldman Review-Url: https://codereview.chromium.org/1957053002 Cr-Commit-Position: refs/heads/master@{#392509} [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting.html [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/switch-file.html [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/LayoutTests/inspector/sources/sources-panel-extension-names.html [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/Source/devtools/front_end/bindings/SASSSourceMapping.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js [modify] https://crrev.com/ecff28a9f64c5657409fc62bfda4ed5c328581e3/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2 commit e8058b2de1e7f9e610ebe429a77a1bd16032f3a2 Author: lushnikov <lushnikov@chromium.org> Date: Wed May 11 00:33:49 2016 DevTools: introduce CSSStyleSheetHeader.originalContentProvider() method This patch adds CSSStyleSheetHeader.originalContentProvider() method, which returns a content provider of original CSSStyleSheetHeader content. This provider is used to: - populate Workspace - build initial mapping for LiveSASS BUG= 610061 R=pfeldman Review-Url: https://codereview.chromium.org/1954423002 Cr-Commit-Position: refs/heads/master@{#392787} [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/http/tests/inspector/search/search-in-static.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/http/tests/inspector/stylesheet-source-mapping.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/elements/styles-1/edit-inspector-stylesheet.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/elements/styles-4/keyframes-source-offsets.html [add] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/elements/styles/original-content-provider-expected.txt [add] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/elements/styles/original-content-provider.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/switch-file.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/LayoutTests/inspector/sources/sources-panel-extension-names.html [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/elements/StylesSidebarPane.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/sass/SASSSourceMapFactory.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js [modify] https://crrev.com/e8058b2de1e7f9e610ebe429a77a1bd16032f3a2/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a225533df5123e49ecc5d5552037d672b69fc9b6 commit a225533df5123e49ecc5d5552037d672b69fc9b6 Author: lushnikov <lushnikov@chromium.org> Date: Wed May 11 19:28:46 2016 DevTools: do not pro-actively query all StyleSheets for their content. Due to a programmatic error in crrev.com/1954423002, we currently query all the stylesheets for their content. This patch fixes this behavior and adds a test to ensure this will not happen. BUG= 610061 R=dgozman, pfeldman Review-Url: https://codereview.chromium.org/1974543002 Cr-Commit-Position: refs/heads/master@{#393025} [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/http/tests/inspector/search/search-in-static.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/http/tests/inspector/search/sources-search-scope-many-projects.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/elements/styles/original-content-provider-expected.txt [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/elements/styles/original-content-provider.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-sorting.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/switch-file.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code-display-name.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/sources/debugger/navigator-view.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/LayoutTests/inspector/sources/sources-panel-extension-names.html [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/Source/devtools/front_end/sass/ASTSourceMap.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/Source/devtools/front_end/sdk/SourceMap.js [modify] https://crrev.com/a225533df5123e49ecc5d5552037d672b69fc9b6/third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36bc4339122248e74d411a656a6dff4db2b2a790 commit 36bc4339122248e74d411a656a6dff4db2b2a790 Author: einbinder <einbinder@chromium.org> Date: Fri Sep 23 02:41:10 2016 DevTools: Preserve the text when doing a line-by-line diff This is in preperation of being able to revert changes in the sources panel. BUG= 610061 Review-Url: https://codereview.chromium.org/2349823002 Cr-Commit-Position: refs/heads/master@{#420554} [add] https://crrev.com/36bc4339122248e74d411a656a6dff4db2b2a790/third_party/WebKit/LayoutTests/inspector/diff-module-expected.txt [add] https://crrev.com/36bc4339122248e74d411a656a6dff4db2b2a790/third_party/WebKit/LayoutTests/inspector/diff-module.html [modify] https://crrev.com/36bc4339122248e74d411a656a6dff4db2b2a790/third_party/WebKit/Source/devtools/front_end/diff/Diff.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/303b2827e8aac3bc43fc93aec9c79d6cd1834806 commit 303b2827e8aac3bc43fc93aec9c79d6cd1834806 Author: einbinder <einbinder@chromium.org> Date: Thu Mar 02 02:06:22 2017 DevTools: Only provide static script content to UISourceCode This fixes live edited scripts losing their original content. BUG= 610061 Review-Url: https://codereview.chromium.org/2695123004 Cr-Commit-Position: refs/heads/master@{#454150} [add] https://crrev.com/303b2827e8aac3bc43fc93aec9c79d6cd1834806/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-original-content-expected.txt [add] https://crrev.com/303b2827e8aac3bc43fc93aec9c79d6cd1834806/third_party/WebKit/LayoutTests/inspector/sources/debugger/live-edit-original-content.html [modify] https://crrev.com/303b2827e8aac3bc43fc93aec9c79d6cd1834806/third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html [modify] https://crrev.com/303b2827e8aac3bc43fc93aec9c79d6cd1834806/third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js [modify] https://crrev.com/303b2827e8aac3bc43fc93aec9c79d6cd1834806/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js [modify] https://crrev.com/303b2827e8aac3bc43fc93aec9c79d6cd1834806/third_party/WebKit/Source/devtools/front_end/sdk/CSSStyleSheetHeader.js [modify] https://crrev.com/303b2827e8aac3bc43fc93aec9c79d6cd1834806/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/229324e62cfbaf5b941d738697ff84fd1396b382 commit 229324e62cfbaf5b941d738697ff84fd1396b382 Author: einbinder <einbinder@chromium.org> Date: Tue Mar 14 23:20:15 2017 DevTools: Clean up character diff diff_match_patch has the ability to clean up diffs, removing small changes that are likely coincidental. BUG= 610061 Review-Url: https://codereview.chromium.org/2751813002 Cr-Commit-Position: refs/heads/master@{#456884} [modify] https://crrev.com/229324e62cfbaf5b941d738697ff84fd1396b382/third_party/WebKit/Source/devtools/front_end/diff/Diff.js [modify] https://crrev.com/229324e62cfbaf5b941d738697ff84fd1396b382/third_party/WebKit/Source/devtools/front_end/externs.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3bddfe5d8dd5ca4f1431cbef44d3bbaf4dced3e3 commit 3bddfe5d8dd5ca4f1431cbef44d3bbaf4dced3e3 Author: einbinder <einbinder@chromium.org> Date: Wed Mar 15 01:22:39 2017 DevTools: CharacterIdMap should be able to return empty string CharacterIdMap is used for strings, but if the empty string was stored it would return null. BUG= 610061 Review-Url: https://codereview.chromium.org/2753543004 Cr-Commit-Position: refs/heads/master@{#456936} [modify] https://crrev.com/3bddfe5d8dd5ca4f1431cbef44d3bbaf4dced3e3/third_party/WebKit/Source/devtools/front_end/common/CharacterIdMap.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/569f345a2ee19b54dc008c3c2011cee9e7405d36 commit 569f345a2ee19b54dc008c3c2011cee9e7405d36 Author: einbinder <einbinder@chromium.org> Date: Wed Mar 15 04:25:20 2017 DevTools: Diff subsystem This moves the diff computation out of SourceCodeDiff into a new module. Now the diff can be shared by more than one consumer. BUG= 610061 Review-Url: https://codereview.chromium.org/2729783002 Cr-Commit-Position: refs/heads/master@{#456991} [modify] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/LayoutTests/inspector/initial-modules-load-expected.txt [modify] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/LayoutTests/inspector/sources/source-code-diff.html [modify] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/Source/devtools/BUILD.gn [modify] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/Source/devtools/front_end/diff/Diff.js [modify] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/Source/devtools/front_end/inspector.json [modify] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js [modify] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js [modify] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/Source/devtools/front_end/source_frame/module.json [add] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/Source/devtools/front_end/workspace_diff/WorkspaceDiff.js [add] https://crrev.com/569f345a2ee19b54dc008c3c2011cee9e7405d36/third_party/WebKit/Source/devtools/front_end/workspace_diff/module.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/273fceab889606fc42876772d24117ed9fbbe4b9 commit 273fceab889606fc42876772d24117ed9fbbe4b9 Author: einbinder <einbinder@chromium.org> Date: Mon Mar 20 19:42:11 2017 DevTools: Only show gutter diff for Network UISourceCodes We don't have a good baseline for unmapped sources from the filesystem BUG= 610061 Review-Url: https://codereview.chromium.org/2762443002 Cr-Commit-Position: refs/heads/master@{#458152} [modify] https://crrev.com/273fceab889606fc42876772d24117ed9fbbe4b9/third_party/WebKit/Source/devtools/front_end/source_frame/SourceCodeDiff.js [modify] https://crrev.com/273fceab889606fc42876772d24117ed9fbbe4b9/third_party/WebKit/Source/devtools/front_end/source_frame/UISourceCodeFrame.js
Bulk closing low-priority issues with no activity. Please re-file and refer to the closed issue if it's essential to fix.
Comment 1 by bugdroid1@chromium.org
, May 10 2016