Issue metadata
Sign in to add a comment
|
Fix and re-enable smoothness.gpu_rasterization.tough_pinch_zoom_cases on Android |
||||||||||||||||||||||
Issue description
,
May 9 2016
,
Jul 18 2016
,
Aug 17 2016
,
Dec 21 2016
,
Aug 4 2017
,
Aug 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64e25a27ab028610e6097f6458c749a26eea3050 commit 64e25a27ab028610e6097f6458c749a26eea3050 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Tue Aug 08 18:53:52 2017 Reenabling some smoothness benchmarks at the should disable level smoothness.tough_pinch_zoom_cases smoothness.gpu_rasterization.tough_pinch_zoom_cases Bug: 631015 , 610021 ,713222 Change-Id: I29326bef864f00edb2d1f1ed738a35bee4903951 Reviewed-on: https://chromium-review.googlesource.com/606449 Reviewed-by: rnephew <rnephew@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#492715} [modify] https://crrev.com/64e25a27ab028610e6097f6458c749a26eea3050/tools/perf/benchmarks/smoothness.py
,
Aug 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e91f6968e7768275d7e37608c1228effd181d11 commit 4e91f6968e7768275d7e37608c1228effd181d11 Author: Ashley Enstad <ashleymarie@chromium.org> Date: Wed Aug 09 16:42:53 2017 Reenabling some smoothness benchmarks smoothness.tough_pinch_zoom_cases smoothness.gpu_rasterization.tough_pinch_zoom_cases smoothness.gpu_rasterization.tough_scrolling_cases Bug: 631015 , 610021 , 667489 ,713222 Change-Id: I401beed0229fe2a6c990ecdbab9a01e5ac239c7d Reviewed-on: https://chromium-review.googlesource.com/606113 Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> Reviewed-by: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#493021} [modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/testing/buildbot/chromium.perf.fyi.json [modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/testing/buildbot/chromium.perf.json [modify] https://crrev.com/4e91f6968e7768275d7e37608c1228effd181d11/tools/perf/benchmarks/smoothness.py
,
Aug 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/413e72f9569c5b502335883143d9b96f6cd1474c commit 413e72f9569c5b502335883143d9b96f6cd1474c Author: Ashley Enstad <ashleymarie@chromium.org> Date: Fri Aug 11 21:14:15 2017 Disabling failing smoothness.*.tough_pinch_zoom_cases Every tough_pinch_zoom_cases story is still failing on the Android platforms and smoothness.tough_pinch_zoom_cases is still failing on Win as well so this change re-disables the tests using StoryExpectations BUG= 631015 , 713222, 610021 Change-Id: Ie2d53baeb5950c36ad08e247bb1874272521da63 Reviewed-on: https://chromium-review.googlesource.com/612367 Reviewed-by: rnephew <rnephew@chromium.org> Commit-Queue: Ashley Enstad <ashleymarie@chromium.org> Cr-Commit-Position: refs/heads/master@{#493858} [modify] https://crrev.com/413e72f9569c5b502335883143d9b96f6cd1474c/tools/perf/benchmarks/smoothness.py
,
Sep 15 2017
I've got a patch in-progress that should bring all these up
,
Oct 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/771bc4ee1d609083dd81daa0ee78229b49dfa270 commit 771bc4ee1d609083dd81daa0ee78229b49dfa270 Author: David Bokan <bokan@chromium.org> Date: Thu Oct 05 18:39:46 2017 Use viewport coords in gpuBenchmarking gestures This is a follow-up CL to: https://crrev.com/c/690314 Currently, gpuBenchmarking takes coordinates in the root-frame coordinate space. Since input events are in the (visual) viewport space, gpuBenchmarking was trying to convert them in the presence of pinch-zoom by applying the pageScaleFactor. This is incorrect, as the transformation must also include the visual viewport offset. However, it makes a lot more sense for gpuBenchmarking to take coordinates in the viewport space to begin with, leaving the conversion to the caller. The above CL converts telemetry to pass these coordinates in viewport space. It's gated on the presence of the `gesturesExpectedInViewportCoordinates` attribute so that we can make the transition without breaking the waterfall. Bug: 610021 Change-Id: Ic6a4229e230b77427e6f1aa7ef71933c21d93106 Reviewed-on: https://chromium-review.googlesource.com/668376 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Eric Karl <ericrk@chromium.org> Reviewed-by: Alexandre Elias <aelias@chromium.org> Cr-Commit-Position: refs/heads/master@{#506804} [modify] https://crrev.com/771bc4ee1d609083dd81daa0ee78229b49dfa270/content/renderer/gpu/gpu_benchmarking_extension.cc [modify] https://crrev.com/771bc4ee1d609083dd81daa0ee78229b49dfa270/content/renderer/gpu/gpu_benchmarking_extension.h [modify] https://crrev.com/771bc4ee1d609083dd81daa0ee78229b49dfa270/third_party/WebKit/LayoutTests/fast/dom/Window/resources/window-property-collector.js
,
Oct 11 2017
I got the bug number in a landed patch wrong so I'm pasting the commit bot message here: Fix coordinate calculations under pinch-zoom This CL fixes how telemetry calculates coordinates under pinch-zoom. This has been broken because pinch-zoom is more than just a multiplication by a scale, it also includes a translation to account for the visual viewport's offset within the root frame. Thus, to convert a coordinate in the root frame to a coordinate in the visual viewport (i.e. the user's screen), we use: (x, y) = ((x1, y1) - visualViewportOffset) * pageScaleFactor However, this change also requires that gpuBenchmarking's methods know that incoming coordinates are relative to the visual viewport. gpuBenchmarking today tries to apply page scale to most coordinates. There is a follow up patch that removes the pageScaleFactor application in gpuBenchmarking: https://crrev.com/c/668376 Hoewver, until gpuBenchmarking is changed, we don't want to change the coordinate system we use in Catapult but we can't change gpuBenchmarking until the Catapult repo changes are rolled into Chrome. This, I've gated the changes here on an attribute that the above patch will add to gpuBenchmarking. Once both changes land I can remove the attribute and the old code in this patch. In addition, the PinchAction supported pinching-in on a specific Element. This functionality is broken and unused so I've remoted it. The telemetry code always tries to zoom into the center of the viewport. I've also updated pageScaleFactor calculation to take account of the inert visualViewport changes which means that innerWidth / outerWidth no longer represents the scale factor. Bug: chromium:630998 Change-Id: I83f8f0f87a00493a211a6dcc82ad18f044c0ce02 Reviewed-on: https://chromium-review.googlesource.com/690314 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com>
,
Oct 27 2017
Issue 527352 has been merged into this issue.
,
Nov 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/509d78a660bc5fb4fb07bc76bc76aeabd59248f0 commit 509d78a660bc5fb4fb07bc76bc76aeabd59248f0 Author: David Bokan <bokan@chromium.org> Date: Wed Nov 22 23:25:29 2017 Fix MotionEventSynthesizer for multi-touch MotionEventSynthesizer currently doesn't set the index of the pointer being changed by ACTION_POINTER_DOWN or ACTION_POINTER_UP which means it's interpreted as being the 0th pointer. This is wrong since these actions happen for the 1st pointer. This was causing DCHECKs to fire when gpuBenchmarking.pinchBy is used. This patch correctly sets the pointer index in the action bitfield. Tests that would have caught this (and surfaced it in the first place) are included in these patches: crrev.com/c/783823 crrev.com/c/784213 Bug: 610021 Change-Id: I0bebffaf1db4076c66c5009f5bf6f2b6e06f6939 TBR: yfriedman@chromium.org Reviewed-on: https://chromium-review.googlesource.com/786331 Reviewed-by: David Bokan <bokan@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518799} [modify] https://crrev.com/509d78a660bc5fb4fb07bc76bc76aeabd59248f0/content/public/android/java/src/org/chromium/content/browser/MotionEventSynthesizer.java
,
Nov 23 2017
,
Nov 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a96df7c3a68dd9c0ac1cf1263a609bf4824f7f3 commit 2a96df7c3a68dd9c0ac1cf1263a609bf4824f7f3 Author: David Bokan <bokan@chromium.org> Date: Mon Nov 27 23:50:25 2017 Compensate for page scale in animated scrolls When the user zooms into the page, scrolling should be proportionally reduced so the page appears to move at the same rate. This is currently done for various kinds of scrolling. An animated scroll that updates an existing scroll animation simply adjusts the animation curve's target delta. However, this path forgot to adjust by the page scale factor like the "new animation" and "non- animated" paths. This CL simply adds that in. Bug: 610021 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ic1a6421131915ad739d39ad3ef36792dd3be53aa Reviewed-on: https://chromium-review.googlesource.com/788134 Reviewed-by: Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#519456} [modify] https://crrev.com/2a96df7c3a68dd9c0ac1cf1263a609bf4824f7f3/cc/trees/layer_tree_host_impl.cc [modify] https://crrev.com/2a96df7c3a68dd9c0ac1cf1263a609bf4824f7f3/cc/trees/layer_tree_host_impl_unittest.cc
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67a4a7791d1229cddc3f12da4203926e0b8d431c commit 67a4a7791d1229cddc3f12da4203926e0b8d431c Author: David Bokan <bokan@chromium.org> Date: Wed Dec 20 16:48:32 2017 Make synthetic pinch zooms accurate This patch makes synthetic pinch zoom gestures zoom to the correct scale. We do this by fixing two bugs in the scale gesture detector. The first is error due to touch slop. Slop is the amount that the touch points must move before the zoom gesture is activated. Unfortunately, the gesture recognizer drops the entire event that crosses the slop threshold. The second issue is similar but has to do with the minimum scaling span. The "span" is the distance between the two fingers in the pinch gesture. The minimum scaling span is the span at which point making the span smaller doesn't change the zoom level. Similarly to slop, the event that crosses this threshold is entirely dropped. At high speeds this resulted in losing a significant amount of delta. This CL fixes these issues by modifying the prev_span_ field on the first event that initiates a scale to be at the threshold, thus contributing the delta beyond it. I moved the reset and end that happens when a zoom out crosses the min span threshold to happen after we send an update, which allows us to send the final delta, clamped to the min span, before ending the gesture. I also start a pinch-zoom if the initial span is large enough but the first update causes us to cross this threshold. This means a single update can cuase a PinchBegin, PinchUpdate, PinchEnd. It also fixes existing tests that didn't expect that the first touch move that initiates a pinch zoom would also include a gesture pinch update. Bug: 610021 Change-Id: I22e2ff8d4b89f5da67ab102658175dbb5f2b2cec Reviewed-on: https://chromium-review.googlesource.com/784213 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#525348} [modify] https://crrev.com/67a4a7791d1229cddc3f12da4203926e0b8d431c/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchTouchEvent-expected.txt [modify] https://crrev.com/67a4a7791d1229cddc3f12da4203926e0b8d431c/third_party/WebKit/LayoutTests/inspector-protocol/input/dispatchTouchEvent.js [modify] https://crrev.com/67a4a7791d1229cddc3f12da4203926e0b8d431c/ui/aura/gestures/gesture_recognizer_unittest.cc [modify] https://crrev.com/67a4a7791d1229cddc3f12da4203926e0b8d431c/ui/events/gesture_detection/gesture_provider.cc [modify] https://crrev.com/67a4a7791d1229cddc3f12da4203926e0b8d431c/ui/events/gesture_detection/gesture_provider_unittest.cc [modify] https://crrev.com/67a4a7791d1229cddc3f12da4203926e0b8d431c/ui/events/gesture_detection/scale_gesture_detector.cc
,
Dec 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/b83a27983a06bea1f8a94ad8b3b56c2ef6279d1b commit b83a27983a06bea1f8a94ad8b3b56c2ef6279d1b Author: David Bokan <bokan@chromium.org> Date: Wed Dec 20 22:50:33 2017 Make pinch actions take speed in viewport coords I was a little over-zealous in https://crrev.com/dbab215523c8d77a7b54fcf3776357b079c36899. I made the speed parameter in PinchAction be in CSS pixels. This makes sense for scrolls and other gestures but for pinch it means that the speed of the zoom depends on how far the page is currently zoomed in. This is never what you want for pinch-zoom. I've updated pinch.js to keep the speed invariant across page scale factors. I've also added a test for this and other pinch zoom aspects since we currently have poor test coverage. Bug: chromium:610021 Change-Id: I7008cb6c90aa4b9a610abd2c322c88281aa97f87 Reviewed-on: https://chromium-review.googlesource.com/783823 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: David Bokan <bokan@chromium.org> [modify] https://crrev.com/b83a27983a06bea1f8a94ad8b3b56c2ef6279d1b/telemetry/telemetry/internal/actions/pinch_unittest.py [modify] https://crrev.com/b83a27983a06bea1f8a94ad8b3b56c2ef6279d1b/telemetry/telemetry/internal/actions/pinch.js [add] https://crrev.com/b83a27983a06bea1f8a94ad8b3b56c2ef6279d1b/telemetry/telemetry/internal/testing/zoom.html
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a0b20a4892e20dcd620ac6f821411fa62ee3994b commit a0b20a4892e20dcd620ac6f821411fa62ee3994b Author: Kenneth Russell <kbr@chromium.org> Date: Thu Dec 21 03:02:35 2017 Revert "Make pinch actions take speed in viewport coords" This reverts commit b83a27983a06bea1f8a94ad8b3b56c2ef6279d1b. Reason for revert: new test is failing (flakily?), blocking Catapult rolls. https://ci.chromium.org/buildbot/tryserver.chromium.chromiumos/linux-chromeos-rel/27958 Original change's description: > Make pinch actions take speed in viewport coords > > I was a little over-zealous in > https://crrev.com/dbab215523c8d77a7b54fcf3776357b079c36899. I made the > speed parameter in PinchAction be in CSS pixels. This makes sense for > scrolls and other gestures but for pinch it means that the speed of the > zoom depends on how far the page is currently zoomed in. This is never > what you want for pinch-zoom. > > I've updated pinch.js to keep the speed invariant across page scale > factors. I've also added a test for this and other pinch zoom aspects > since we currently have poor test coverage. > > Bug: chromium:610021 > Change-Id: I7008cb6c90aa4b9a610abd2c322c88281aa97f87 > Reviewed-on: https://chromium-review.googlesource.com/783823 > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: David Bokan <bokan@chromium.org> TBR=bokan@chromium.org,dtapuska@chromium.org,nednguyen@google.com Change-Id: Idcbc170af2c1105525f3d61c05556a39d1851936 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:610021 Reviewed-on: https://chromium-review.googlesource.com/838740 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> [modify] https://crrev.com/a0b20a4892e20dcd620ac6f821411fa62ee3994b/telemetry/telemetry/internal/actions/pinch_unittest.py [modify] https://crrev.com/a0b20a4892e20dcd620ac6f821411fa62ee3994b/telemetry/telemetry/internal/actions/pinch.js [delete] https://crrev.com/928fc9d37730186db0551c401314f41db4111806/telemetry/telemetry/internal/testing/zoom.html
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/0cf98f6780a35c00ec655fbc19f9002cb7f02577 commit 0cf98f6780a35c00ec655fbc19f9002cb7f02577 Author: David Bokan <bokan@chromium.org> Date: Thu Dec 21 19:38:58 2017 Make pinch actions take speed in viewport coords I was a little over-zealous in https://crrev.com/dbab215523c8d77a7b54fcf3776357b079c36899. I made the speed parameter in PinchAction be in CSS pixels. This makes sense for scrolls and other gestures but for pinch it means that the speed of the zoom depends on how far the page is currently zoomed in. This is never what you want for pinch-zoom. I've updated pinch.js to keep the speed invariant across page scale factors. I've also added a test for this and other pinch zoom aspects since we currently have poor test coverage. Note: This is re-landing b83a27983a06bea1f8a94ad8b3b56c2ef6279d1b Bug: chromium:610021 Change-Id: I9444be9929b9ce16d9b4d65eb2be405bb99d3a24 TBR=nednguyen@google.com Reviewed-on: https://chromium-review.googlesource.com/840220 Commit-Queue: David Bokan <bokan@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/0cf98f6780a35c00ec655fbc19f9002cb7f02577/telemetry/telemetry/internal/actions/pinch_unittest.py [modify] https://crrev.com/0cf98f6780a35c00ec655fbc19f9002cb7f02577/telemetry/telemetry/internal/actions/pinch.js [add] https://crrev.com/0cf98f6780a35c00ec655fbc19f9002cb7f02577/telemetry/telemetry/internal/testing/zoom.html
,
Dec 21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/29d3c0bdccfc60cdb9e74d81f38d4efaba507102 commit 29d3c0bdccfc60cdb9e74d81f38d4efaba507102 Author: David Bokan <bokan@chromium.org> Date: Thu Dec 21 20:02:41 2017 Add integration test for synthetic pinch gestures This CL adds a layout test that uses gpuBenchmarking.pinchBy and verifies its effects. This requires an addition of an explicit setSize on Android's WebContents. This is because the layout tests on Android start the browser process' main loop on the UI thread so the Android Views framework never gets to layout. Without this, the RenderWidget appears to have 0x0 size and calling pinchBy fails. This was split out from https://crrev.com/c/784213 Bug: 610021 Change-Id: Ibf9a262833a18f9d1f34769c12f14cdfdb9a4c80 Reviewed-on: https://chromium-review.googlesource.com/834398 Reviewed-by: Dirk Pranke <dpranke@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Timothy Dresser <tdresser@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#525780} [modify] https://crrev.com/29d3c0bdccfc60cdb9e74d81f38d4efaba507102/content/shell/android/java/src/org/chromium/content_shell/Shell.java [modify] https://crrev.com/29d3c0bdccfc60cdb9e74d81f38d4efaba507102/content/shell/browser/layout_test/blink_test_controller.cc [modify] https://crrev.com/29d3c0bdccfc60cdb9e74d81f38d4efaba507102/content/shell/browser/shell.h [modify] https://crrev.com/29d3c0bdccfc60cdb9e74d81f38d4efaba507102/content/shell/browser/shell_android.cc [modify] https://crrev.com/29d3c0bdccfc60cdb9e74d81f38d4efaba507102/third_party/WebKit/LayoutTests/SmokeTests [modify] https://crrev.com/29d3c0bdccfc60cdb9e74d81f38d4efaba507102/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/29d3c0bdccfc60cdb9e74d81f38d4efaba507102/third_party/WebKit/LayoutTests/synthetic_gestures/synthetic-pinch-zoom-gesture.html
,
Dec 22 2017
Issue 631015 has been merged into this issue.
,
Dec 22 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9c9101054ad74283f3ddf6f8f626f67af5de04e commit b9c9101054ad74283f3ddf6f8f626f67af5de04e Author: David Bokan <bokan@chromium.org> Date: Fri Dec 22 18:16:18 2017 Renable tough_pinch_zoom_cases perf tests I've fixed various issues in telemetry that were keeping pinch-zoom tests from being enabled (see commits in bug). There should be nothing blocking this anymore so lets turn them back on. Bug: 610021 Change-Id: I71c380322655af213c20b73bb8361cd199d2b64e Reviewed-on: https://chromium-review.googlesource.com/843122 Reviewed-by: Ned Nguyen <nednguyen@google.com> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526022} [modify] https://crrev.com/b9c9101054ad74283f3ddf6f8f626f67af5de04e/tools/perf/expectations.config
,
Dec 22 2017
These tests should now be reenabled. I'll leave the bug open to let the bots cycle through them and to track removing some temporary code in gpuBenchmarking to work across versions of Chrome and Catapult.
,
Jan 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/64db7e826362a35364fd9fe60a6d4f6c6218a742 commit 64db7e826362a35364fd9fe60a6d4f6c6218a742 Author: David Bokan <bokan@chromium.org> Date: Tue Jan 02 18:49:23 2018 Remove gesturesExpectedInViewportCoordinates branches This is all dead code removal since the ref-builds are now at M63. Bug: chromium:610021 Change-Id: I7d5ae2f1f9dcc096a29e98ff42cbb81e10598c7d Reviewed-on: https://chromium-review.googlesource.com/846436 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by: Ned Nguyen <nednguyen@google.com> [modify] https://crrev.com/64db7e826362a35364fd9fe60a6d4f6c6218a742/telemetry/telemetry/internal/actions/scroll.js [modify] https://crrev.com/64db7e826362a35364fd9fe60a6d4f6c6218a742/telemetry/telemetry/internal/actions/drag.js [modify] https://crrev.com/64db7e826362a35364fd9fe60a6d4f6c6218a742/telemetry/telemetry/internal/actions/pinch.js [modify] https://crrev.com/64db7e826362a35364fd9fe60a6d4f6c6218a742/telemetry/telemetry/internal/actions/swipe.js [modify] https://crrev.com/64db7e826362a35364fd9fe60a6d4f6c6218a742/telemetry/telemetry/internal/actions/gesture_common.js
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/adee00bb7ef5ee11f8261efcba5b9c6873bafcc3 commit adee00bb7ef5ee11f8261efcba5b9c6873bafcc3 Author: David Bokan <bokan@chromium.org> Date: Thu Jan 04 12:41:38 2018 Removed gesturesExpectedInViewportCoordinates Since telemetry ref-builds have now moved past M63 when this was added, and all dependencies have been updated, we can now remove this flag. Bug: 610021 Change-Id: Ic3c4bf9d7ddc5019e18d187f352f8f477b1f0814 Reviewed-on: https://chromium-review.googlesource.com/846529 Reviewed-by: Eric Karl <ericrk@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#526965} [modify] https://crrev.com/adee00bb7ef5ee11f8261efcba5b9c6873bafcc3/content/renderer/gpu/gpu_benchmarking_extension.cc
,
Jan 4 2018
Pinch-zoom tests are (finally) back on and running and all temporary shims are removed so marking this as fixed.
,
Jan 16
,
Jan 16
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, May 7 2016