New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 610016 link

Starred by 1 user
Status: Verified
Owner:
qiangchen@chromium.org
Closed: May 2016
Cc:
█ keta...@chromium.org
jen...@chromium.org
msw@chromium.org
steve...@chromium.org
achuith@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Tests failures on the "Linux ChromiumOS Tests (dbg)" builder

Project Member Reported by afakhry@chromium.org, May 6 2016 
We currently have two build failures on this builder. First one was:

https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/14099

Failing tests are: 
DesktopMediaPickerViewsDeprecatedTest.ListViewHasInitialFocus
DesktopMediaPickerViewsDeprecatedTest.AddAndRemoveMediaSource
DesktopMediaPickerViewsDeprecatedTest.FocusMediaSourceViewToSelect
DesktopMediaPickerViewsDeprecatedTest.CancelButtonAlwaysEnabled
DesktopMediaPickerViewsDeprecatedTest.DoneCallbackCalledWhenWindowClosed
DesktopMediaPickerViewsDeprecatedTest.SelectMediaSourceViewOnSingleClick
DesktopMediaPickerViewsDeprecatedTest.DoneCallbackCalledOnDoubleTap
DesktopMediaPickerViewsDeprecatedTest.DoneCallbackCalledOnDoubleClick
DesktopMediaPickerViewsDeprecatedTest.OkButtonDisabledWhenNoSelection
DesktopMediaPickerViewsDeprecatedTest.DoneCallbackCalledOnOkButtonPressed

Suspected CL: https://codereview.chromium.org/1932413002

qiangchen@ Could you please take a look?
Project Member

Comment 1 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec8a48393ac2f10940f3b6e63d1319222e660cff

commit ec8a48393ac2f10940f3b6e63d1319222e660cff
Author: qiangchen <qiangchen@chromium.org>
Date: Mon May 09 20:11:27 2016

Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG= 602478 , 610016 

TBR=isherman@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/1962073002
Cr-Commit-Position: refs/heads/master@{#392406}

[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/app/chromium_strings.grd
[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/app/generated_resources.grd
[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/browser/about_flags.cc
[copy] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[copy] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
[add] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc
[rename] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/browser/ui/views/desktop_media_picker_views_deprecated.cc
[rename] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/browser/ui/views/desktop_media_picker_views_deprecated.h
[rename] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/browser/ui/views/desktop_media_picker_views_deprecated_unittest.cc
[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/extensions/common/switches.cc
[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/extensions/common/switches.h
[modify] https://crrev.com/ec8a48393ac2f10940f3b6e63d1319222e660cff/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, May 9 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623

commit 31c2d5a8cbeced5cb648ed5fea9a9e92efb13623
Author: Stanislav Chiknavaryan <stanisc@chromium.org>
Date: Mon May 09 22:34:53 2016

Revert "Desktop Capture Picker New UI: Non Mac Structure Change"

This reverts commit ec8a48393ac2f10940f3b6e63d1319222e660cff.

Reason for the revert:
Breaks a number of DesktopMediaPickerControllerTest tests on
Builder: Mac10.9 Tests (dbg) (stats).
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29

TBR=isherman@chromium.org,rockot@chromium.org,qiangchenC@chromium.org

BUG= 602478 ,  610016 

Review URL: https://codereview.chromium.org/1958293002 .

Cr-Commit-Position: refs/heads/master@{#392451}

[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/app/chromium_strings.grd
[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/app/generated_resources.grd
[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/browser/about_flags.cc
[delete] https://crrev.com/58b07f5147cb47dc85302bd3a112efb627c972ff/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[delete] https://crrev.com/58b07f5147cb47dc85302bd3a112efb627c972ff/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
[delete] https://crrev.com/58b07f5147cb47dc85302bd3a112efb627c972ff/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc
[rename] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/browser/ui/views/desktop_media_picker_views.cc
[rename] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/browser/ui/views/desktop_media_picker_views.h
[rename] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/browser/ui/views/desktop_media_picker_views_unittest.cc
[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/extensions/common/switches.cc
[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/extensions/common/switches.h
[modify] https://crrev.com/31c2d5a8cbeced5cb648ed5fea9a9e92efb13623/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, May 10 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5ced272025f70119b5747514bdb112591f36557e

commit 5ced272025f70119b5747514bdb112591f36557e
Author: qiangchen <qiangchen@chromium.org>
Date: Tue May 10 23:31:20 2016

Desktop Capture Picker New UI: Non Mac Structure Change

A re-commit of 1932413002.
The reason of unittest crash is that we removed a placeholder
in the string resource for window title, but we still used
GetStringFUTF16 in the code of old UI.

In this CL, we add a deprecated string resource with placeholder
for old picker UI to use.

BUG= 602478 ,  610016 
TBR=isherman@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/1966653002
Cr-Commit-Position: refs/heads/master@{#392770}

[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/app/chromium_strings.grd
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/app/generated_resources.grd
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/app/google_chrome_strings.grd
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/browser/about_flags.cc
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/browser/ui/cocoa/media_picker/desktop_media_picker_controller.mm
[copy] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.cc
[copy] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views.h
[add] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/browser/ui/views/desktop_capture/desktop_media_picker_views_unittest.cc
[rename] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/browser/ui/views/desktop_media_picker_views_deprecated.cc
[rename] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/browser/ui/views/desktop_media_picker_views_deprecated.h
[rename] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/browser/ui/views/desktop_media_picker_views_deprecated_unittest.cc
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/chrome_browser_ui.gypi
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/chrome/chrome_tests_unit.gypi
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/extensions/common/switches.cc
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/extensions/common/switches.h
[modify] https://crrev.com/5ced272025f70119b5747514bdb112591f36557e/tools/metrics/histograms/histograms.xml

Comment 4 by qiangchen@chromium.org, May 11 2016

Status: Fixed (was: Assigned)

Comment 5 by patricia@chromium.org, May 23 2016 

Bulk verified

Comment 6 by patricia@chromium.org, May 23 2016

Status: Verified (was: Fixed)
bulk verified
►

Sign in to add a comment