New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609987 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Sep 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Feature

Blocked on:
issue 642086

Blocking:
issue 600391



Sign in to add a comment

Enable client based metrics/crash sampling.

Project Member Reported by jwd@chromium.org, May 6 2016

Issue description

Enable client based metrics/crash sampling.

Have a variation/feature that controls if an metrics/crash reporting client actually report metrics and crash.
 

Comment 1 by jwd@chromium.org, May 6 2016

Blocking: 600391
Project Member

Comment 2 by bugdroid1@chromium.org, May 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5d188392c54189a2a044b8c436209995db1ed9d

commit a5d188392c54189a2a044b8c436209995db1ed9d
Author: jwd <jwd@chromium.org>
Date: Thu May 12 19:43:31 2016

Splitting the concept of UMA consent, and should UMA report.

The motivation here is to support sampling clients. When a client isn't in the sample, reporting will be disabled, even if they've consented.

Knowing consent is still important to make sure the client_id is created, and the high entropy source is used for variations selection. Otherwise, clients would be shuffled into different variations whenever they come in or out of the sample.

BUG= 609987 

Review-Url: https://codereview.chromium.org/1958003003
Cr-Commit-Position: refs/heads/master@{#393333}

[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/android_webview/browser/aw_metrics_service_client.h
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/blimp/engine/app/blimp_metrics_service_client.cc
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/blimp/engine/app/blimp_metrics_service_client.h
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/chrome/browser/metrics/chrome_metrics_services_manager_client.h
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/chrome/browser/metrics/extensions_metrics_provider_unittest.cc
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/chromecast/browser/metrics/cast_metrics_service_client.cc
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/chromecast/browser/metrics/cast_metrics_service_client.h
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics.gypi
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/BUILD.gn
[add] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/enabled_state_provider.cc
[add] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/enabled_state_provider.h
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/metrics_service_unittest.cc
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/metrics_state_manager.cc
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/metrics_state_manager.h
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/metrics_state_manager_unittest.cc
[add] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/test_enabled_state_provider.cc
[add] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/components/metrics/test_enabled_state_provider.h
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm
[modify] https://crrev.com/a5d188392c54189a2a044b8c436209995db1ed9d/ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm

Project Member

Comment 3 by sheriffbot@chromium.org, Jun 1 2016

Labels: -M-52 M-53 MovedFrom-52
Moving this nonessential bug to the next milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 11 2016

Labels: -M-53 MovedFrom-53
This issue has been moved once and is lower than Pri-1. Removing the milestone.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81

commit fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81
Author: jwd <jwd@chromium.org>
Date: Tue Aug 02 15:43:08 2016

Adding reporting of metrics sampling rate.

This rate is controlled by a variation param associated with the kMetricsReportingFeature. It is expressed as the number of clients per 1000.

BUG= 609987 

Review-Url: https://codereview.chromium.org/2180373003
Cr-Commit-Position: refs/heads/master@{#409198}

[modify] https://crrev.com/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81/chrome/browser/metrics/chrome_metrics_services_manager_client.h
[add] https://crrev.com/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81/chrome/browser/metrics/sampling_metrics_provider.cc
[add] https://crrev.com/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81/chrome/browser/metrics/sampling_metrics_provider.h
[modify] https://crrev.com/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81/chrome/chrome_browser.gypi
[modify] https://crrev.com/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81/components/variations/variations_associated_data.h
[modify] https://crrev.com/fbceca6039fa8d127d7b43a7e5fdb7b8f7e97a81/tools/metrics/histograms/histograms.xml

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c882e48d0f01744dd5e9de83395f45baa38ce731

commit c882e48d0f01744dd5e9de83395f45baa38ce731
Author: jwd <jwd@chromium.org>
Date: Fri Aug 19 00:14:42 2016

Adding support for sampling crashes in Chrome on Windows.

BUG= 609987 

Review-Url: https://codereview.chromium.org/2221833005
Cr-Commit-Position: refs/heads/master@{#412984}

[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/chrome/app/chrome_crash_reporter_client_win.cc
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/chrome/app/chrome_crash_reporter_client_win.h
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/chrome/browser/DEPS
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/chrome/browser/google/google_update_settings_posix.cc
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/chrome/browser/metrics/chrome_metrics_services_manager_client.cc
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/chrome/browser/metrics/chrome_metrics_services_manager_client.h
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/chrome/install_static/install_util.cc
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/chrome/install_static/install_util.h
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/components/crash/content/app/crash_reporter_client.cc
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/components/crash/content/app/crash_reporter_client.h
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/components/crash/content/app/crashpad.cc
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/components/crash/content/app/crashpad.h
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/components/metrics_services_manager/metrics_services_manager.cc
[modify] https://crrev.com/c882e48d0f01744dd5e9de83395f45baa38ce731/components/metrics_services_manager/metrics_services_manager_client.h

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c8e0974b783b3e22e09ae2560524c03e5518461

commit 0c8e0974b783b3e22e09ae2560524c03e5518461
Author: jwd <jwd@chromium.org>
Date: Thu Aug 25 18:23:44 2016

Enabling sampling of UMA and crash reports on Android.

This has a side effect of causing metrics reporting to be enabled during the session that the pref is changed.

BUG= 609987 

Review-Url: https://codereview.chromium.org/2248243002
Cr-Commit-Position: refs/heads/master@{#414482}

[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadCallable.java
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaUtils.java
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/CrashReportingPermissionManager.java
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadCallableTest.java
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/browser/android/metrics/uma_session_stats.cc
[modify] https://crrev.com/0c8e0974b783b3e22e09ae2560524c03e5518461/chrome/browser/android/metrics/uma_utils.cc

Comment 9 by jwd@chromium.org, Aug 29 2016

Labels: M-54

Comment 10 by jwd@chromium.org, Aug 29 2016

Blockedon: 642086

Comment 11 by jwd@chromium.org, Sep 1 2016

Status: Fixed (was: Started)

Sign in to add a comment