New issue
Advanced search Search tips

Issue 609942 link

Starred by 5 users
Status: Fixed
Owner:
rob@robwu.nl
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

chrome.windows.create({tabId: }) crashes when passed an incognito tab without incognito: true

Reported by 93m...@gmail.com, May 6 2016 
UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/49.0.2623.112 Safari/537.36

Steps to reproduce the problem:
1. Check "Allow in incognito" for an extension in chrome://extensions.
2. Have an incognito tab open.
3. Use chrome.windows.create({tabId: }) to adopt the tab into a new non-incognito window from the extension.

What is the expected behavior?
The browser doesn't quit, and chrome.windows.create fails, setting runtime.lastError. Alternatively, chrome.windows.create could silently force the new window to be incognito.

What went wrong?
The browser hangs and then quits.

Crashed report ID: 

How much crashed? Whole browser

Is it a problem with a plugin? No 

Did this work before? No 

Chrome version: 49.0.2623.112  Channel: n/a
OS Version: 
Flash Version: Shockwave Flash 21.0 r0

The issue can be duplicated by running

chrome.windows.create({incognito: true}, function (win) {
  chrome.tabs.query({windowId: win.id}, function (tabs) {
    chrome.windows.create({tabId: tabs[0].id});
  });
});

https://bugs.chromium.org/p/chromium/issues/detail?id=69285 seems to be related, and the same error message could be used.

Comment 1 by ajha@chromium.org, May 10 2016

Cc: ajha@chromium.org
Components: Platform>Extensions
Labels: Needs-Feedback
I was unable to reproduce this on the latest stable(50.0.2661.94) on Linux Ubuntu 14.04 as per the test steps as attached in the screen-cast.

Could you please review the attached screen-cast and confirm if the issue is seen on the latest stable? Please attach any crash id from chrome://version if the issue is seen on the latest.
609942.mp4
4.3 MB Download

Comment 2 by 93m...@gmail.com, May 10 2016 

#1 I can repro the bug, but *not* if I open an incognito window first. The tab passed to chrome.windows.create needs to be the last remaining incognito tab.

Presumably this is because Chrome attempts to GC the incognito session once no more incognito windows remain.

Crash ID f37a494a00000000.
Project Member

Comment 3 by sheriffbot@chromium.org, May 11 2016

Labels: -Needs-Feedback Needs-Review
Owner: ajha@chromium.org
Thank you for providing more feedback. Adding requester "ajha@chromium.org" for another review and adding "Needs-Review" label for tracking.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 4 by rob@robwu.nl, May 15 2016

Cc: -ajha@chromium.org
Labels: -Needs-Review M-52
Owner: rob@robwu.nl
Status: Started (was: Unconfirmed)
Thanks for the report, a fix is underway: https://codereview.chromium.org/1984573002


PS. At the time of the report Chrome 50 has been stable for over 3 weeks. I suggest to keep Chrome up-to-date to have the latest security patches.
Project Member

Comment 5 by bugdroid1@chromium.org, May 18 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbe4c7255f2c8ce9307aa20a73e4d293e9f60a2f

commit dbe4c7255f2c8ce9307aa20a73e4d293e9f60a2f
Author: rob <rob@robwu.nl>
Date: Wed May 18 19:51:54 2016

Prevent chrome.windows.create from moving a tab to another profile

BUG= 609942 
TEST=browser_tests --gtest_filter=ExtensionApiTest.Incognito

Review-Url: https://codereview.chromium.org/1984573002
Cr-Commit-Position: refs/heads/master@{#394513}

[modify] https://crrev.com/dbe4c7255f2c8ce9307aa20a73e4d293e9f60a2f/chrome/browser/extensions/api/tabs/tabs_api.cc
[modify] https://crrev.com/dbe4c7255f2c8ce9307aa20a73e4d293e9f60a2f/chrome/test/data/extensions/api_test/incognito/apis/background.js

Comment 6 by rob@robwu.nl, May 18 2016

Status: Fixed (was: Started)
►

Sign in to add a comment