New issue
Advanced search Search tips

Issue 609940 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

20.1%-24.4% regression in blink_perf.parser at 392003:392013

Project Member Reported by alexclarke@chromium.org, May 6 2016

Issue description

See the link to graphs below.
 
Cc: e...@chromium.org
Owner: e...@chromium.org

=== Auto-CCing suspected CL author eae@chromium.org ===

Hi eae@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Re-enable complex text path on android
Author  : eae
Commit description:
  
Trying to re-enable the complex text path on Android now that hb_font_t
is cached with the user data container instead of the hb_face_t object.

This should result in lower memory usage for the complex text code path,
we'll watch the memory bots though and revert as needed if it regresses.

BUG=577306
R=drott@chromium.org

Review-Url: https://codereview.chromium.org/1949053002
Cr-Commit-Position: refs/heads/master@{#392010}
Commit  : 9af72a88ea5b39c2c36c99f8b091c5feae82ef7d
Date    : Fri May 06 05:51:07 2016


===== TESTED REVISIONS =====
Revision         Mean     Std Dev  N  Good?
chromium@392002  23412.5  356.784  5  good
chromium@392008  23339.5  220.041  5  good
chromium@392009  23208.7  274.439  5  good
chromium@392010  29653.4  201.594  5  bad    <--
chromium@392011  29532.3  123.461  5  bad
chromium@392013  29483.0  190.871  5  bad

Bisect job ran on: android_nexus5X_perf_bisect
Bug ID: 609940

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --also-run-disabled-tests blink_perf.parser
Test Metric: html-parser-threaded/html-parser-threaded
Relative Change: 25.93%
Score: 99.9

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus5X_perf_bisect/builds/145
Job details: https://chromeperf.appspot.com/buildbucket_job_status/9013385407524990752


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5292662874177536

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Project Member

Comment 3 by bugdroid1@chromium.org, May 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5f972017cef8b77b697e0b339e1bba0c8897af00

commit 5f972017cef8b77b697e0b339e1bba0c8897af00
Author: eae <eae@chromium.org>
Date: Mon May 09 17:10:38 2016

Revert of Re-enable complex text path on android (patchset #1 id:1 of https://codereview.chromium.org/1949053002/ )

Reason for revert:
Memory and perf regression

BUG= 609940 

Original issue's description:
> Re-enable complex text path on android
>
> Trying to re-enable the complex text path on Android now that hb_font_t
> is cached with the user data container instead of the hb_face_t object.
>
> This should result in lower memory usage for the complex text code path,
> we'll watch the memory bots though and revert as needed if it regresses.
>
> BUG=577306
> R=drott@chromium.org
>
> Committed: https://crrev.com/9af72a88ea5b39c2c36c99f8b091c5feae82ef7d
> Cr-Commit-Position: refs/heads/master@{#392010}

TBR=drott@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=577306

Review-Url: https://codereview.chromium.org/1962703002
Cr-Commit-Position: refs/heads/master@{#392346}

[modify] https://crrev.com/5f972017cef8b77b697e0b339e1bba0c8897af00/third_party/WebKit/Source/platform/fonts/Font.cpp

Comment 4 by e...@chromium.org, May 9 2016

Status: Fixed (was: Assigned)

Sign in to add a comment