New issue
Advanced search Search tips

Issue 609932 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

OOPIF: Support tooltips

Project Member Reported by paulmeyer@chromium.org, May 6 2016

Issue description

Version: 52.0.2726.0
OS: All

What steps will reproduce the problem?
(1) Navigate an OOPIF to any page with tooltips, such as https://www.wikipedia.org/
(2) Hover mouse pointer over a link to create a tooltip (such as the "English" link on the Wikipedia front page).

What is the expected output?
I expect the tooltip to appear.

What do you see instead?
Nothing happens.

This is because tooltips are not yet supported for OOPIF. They should be.
 
Status: Started (was: Assigned)
It looks like there are actually 3 separate cases that need fixing here:

1) Tooltips in GuestView tags (such as <webview>) don't work when "--use-cross-process-frames-for-guests" flag is used. This flag makes GuestViews use OOPIFs instead of BrowserPlugins, and the current GuestView tooltip code is all in BrowserPlugin, so they don't work without it.

2) Tooltips in general OOPIFs don't work (with "--site-per-process" flag). This is the regular case of trying to get tooltips to show up when mousing over an element with tooltip text within an OOPIF. This never worked before, and needs to be implemented.

3) Tooltips don't work in GuestViews when using the "--site-per-process" flag without the "--use-cross-process-frames-for-guests" flag. In this case, GuestViews still use BrowserPlugin, so the same tooltip code in there is used, but the tooltip text never actually shows because with "--site-per-process" on, the title on the BrowserPlugin element isn't honored.
Project Member

Comment 3 by bugdroid1@chromium.org, Jun 3 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e1341b3fe622d53dffc76cd993a6c5dde25032e

commit 7e1341b3fe622d53dffc76cd993a6c5dde25032e
Author: paulmeyer <paulmeyer@chromium.org>
Date: Fri Jun 03 22:30:56 2016

Support tooltips in GuestViews with "--use-cross-process-frames-for-guests" flag.

This was just a matter of plumbing the text to the right place.

BUG= 609932 
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2041493002
Cr-Commit-Position: refs/heads/master@{#397824}

[modify] https://crrev.com/7e1341b3fe622d53dffc76cd993a6c5dde25032e/content/browser/frame_host/render_widget_host_view_child_frame.cc

Components: Platform>Apps>BrowserTag
Components: Internals>Sandbox>SiteIsolation
Status: Fixed (was: Started)

Comment 7 Deleted

Comment 8 by creis@chromium.org, Oct 7 2016

Cc: lfg@chromium.org
Sounds like r420991 was also part of this fix.

Sign in to add a comment