focus state for MD checkboxes |
||||||||
Issue descriptionwhat should MD checkboxes look like when checked? Here's the current appearance. Can we just get rid of the dotted line (rely on the blue outline) or do we need to replace the dotted line with something (like a blue roundrect)
,
May 9 2016
I haven't design the new checkboxes yet, I'll let you know.
,
May 10 2016
Here's what I specced out, similarly to how I specced the buttons states. You can also find the .svg for prog rendering attached.I also included the a selected radio and checkbox in .svg so you can grab the stroke spec. .svg are 2x based, no need for 1x. Simply scale.
,
May 18 2016
,
May 18 2016
are there ripples? A hover state? (including on text next to the radio/checkbox)
,
May 20 2016
So here's the best I can give you right now. Basically take the single tap ripple from core UI and apply it to the on-release state with a fade-in of the final state. Similar to the MDlite implementation you can find here: https://getmdl.io/components/index.html#toggles-section
,
May 20 2016
,
May 31 2016
,
Jun 1 2016
question for sgabriel - I assume, based on the on-release spec, that we don't want to show the focus state (or invisibly take focus) when the user clicks a checkbox or radio button. Is this assumption correct? If so this will be a behavioral change.
,
Jun 2 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/104196ecfadb1982e093752f6b01248b6448157a commit 104196ecfadb1982e093752f6b01248b6448157a Author: estade <estade@chromium.org> Date: Thu Jun 02 01:37:53 2016 MD - update checkbox and radio buttons TODO: ripples TODO: animating between states BUG= 609922 Review-Url: https://codereview.chromium.org/2026833003 Cr-Commit-Position: refs/heads/master@{#397289} [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/gfx/BUILD.gn [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/gfx/canvas.cc [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/gfx/canvas.h [add] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/gfx/vector_icons/checkbox_active.icon [add] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/gfx/vector_icons/checkbox_normal.icon [add] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/gfx/vector_icons/radio_button_active.icon [add] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/gfx/vector_icons/radio_button_normal.icon [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/views/controls/button/checkbox.h [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/views/controls/button/label_button.cc [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/views/controls/button/label_button.h [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/views/controls/button/radio_button.cc [modify] https://crrev.com/104196ecfadb1982e093752f6b01248b6448157a/ui/views/controls/button/radio_button.h
,
Jun 22 2016
,
Jul 8 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e38e0aa9cfd669abc777748cc47646d3cb8ea46 commit 4e38e0aa9cfd669abc777748cc47646d3cb8ea46 Author: estade <estade@chromium.org> Date: Fri Jul 08 17:22:13 2016 Add ripples to md checkboxes/radio buttons Not entirely sure this is what Sebastien had in mind, but it seems like a reasonable starting point. Will ping him to test it out after landing. BUG= 609922 Review-Url: https://codereview.chromium.org/2032683003 Cr-Commit-Position: refs/heads/master@{#404426} [modify] https://crrev.com/4e38e0aa9cfd669abc777748cc47646d3cb8ea46/ui/views/controls/button/checkbox.cc [modify] https://crrev.com/4e38e0aa9cfd669abc777748cc47646d3cb8ea46/ui/views/controls/button/checkbox.h
,
Jul 21 2016
,
Aug 5 2016
,
Jul 4 2017
Issue 728988 has been merged into this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by est...@chromium.org
, May 6 2016