New issue
Advanced search Search tips

Issue 609897 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 606672



Sign in to add a comment

cc: optimize color filter application for more complex filter effect DAGs

Project Member Reported by senorblanco@chromium.org, May 6 2016

Issue description

When the root of an image filter DAG consists of a single colorfilterimagefilter containing an SkColorMatrixFilter, apply the
matrix in cc's draw pass, and the remainder of the DAG in Skia. This
should save one draw pass.
 
Blocking: 606672
Project Member

Comment 2 by bugdroid1@chromium.org, May 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d0f2f2751803999b3b9b8cc04bf4628db67cf011

commit d0f2f2751803999b3b9b8cc04bf4628db67cf011
Author: senorblanco <senorblanco@chromium.org>
Date: Fri May 06 20:11:44 2016

cc: optimize color matrix application for more complex filter DAGs.

We previously optimized the case where a filter DAG consisted of a
single SkColorFilterImageFilter containing an SkColorMatrixFilter.
Here we extend it to support any DAG with such a filter at its root,
call skia to process the rest of the DAG, and apply the matrix in cc's
RenderSurface draw pass.

BUG= 609897 
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Review-Url: https://codereview.chromium.org/1961553002
Cr-Commit-Position: refs/heads/master@{#392134}

[modify] https://crrev.com/d0f2f2751803999b3b9b8cc04bf4628db67cf011/cc/output/gl_renderer.cc

Status: Fixed (was: Assigned)

Comment 4 by suzyh@chromium.org, Apr 5 2017

Components: -Blink>CSS>Filters Blink>Compositing>Filters

Sign in to add a comment