New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 609895 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Out until 24 Jan
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Redundant waits in WebContentsImplBrowserTests

Project Member Reported by paulmeyer@chromium.org, May 6 2016

Issue description

In a lot of the WebContentsImplBrowserTests, I see the following pattern:

  LoadStopNotificationObserver load_observer(
      &shell()->web_contents()->GetController());
  NavigateToURL(shell(), embedded_test_server()->GetURL("/title1.html"));
  load_observer.Wait();

For example, here: https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/web_contents/web_contents_impl_browsertest.cc&l=208

It doesn't seem like the observer's Wait() is needed here, since NavigateToURL() already waits for loadstop.
 
Status: Assigned (was: Untriaged)

Sign in to add a comment